mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Events: Remove default getCoalescingKey impls
Summary: Event.java's default implementation of `getCoalescingKey` returns 0. Most overrides of getCoalescingKey just return 0. Delete them. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D28650792 fbshipit-source-id: 374591fb4ba2305df934de412790b3397ca2fa1c
This commit is contained in:
committed by
Facebook GitHub Bot
parent
faaeb778df
commit
900fed576b
-6
@@ -33,10 +33,4 @@ public class DrawerClosedEvent extends Event<DrawerClosedEvent> {
|
||||
protected WritableMap getEventData() {
|
||||
return Arguments.createMap();
|
||||
}
|
||||
|
||||
@Override
|
||||
public short getCoalescingKey() {
|
||||
// All events for a given view can be coalesced.
|
||||
return 0;
|
||||
}
|
||||
}
|
||||
|
||||
-6
@@ -33,10 +33,4 @@ public class DrawerOpenedEvent extends Event<DrawerOpenedEvent> {
|
||||
protected WritableMap getEventData() {
|
||||
return Arguments.createMap();
|
||||
}
|
||||
|
||||
@Override
|
||||
public short getCoalescingKey() {
|
||||
// All events for a given view can be coalesced.
|
||||
return 0;
|
||||
}
|
||||
}
|
||||
|
||||
-6
@@ -37,12 +37,6 @@ public class DrawerSlideEvent extends Event<DrawerSlideEvent> {
|
||||
return EVENT_NAME;
|
||||
}
|
||||
|
||||
@Override
|
||||
public short getCoalescingKey() {
|
||||
// All slide events for a given view can be coalesced.
|
||||
return 0;
|
||||
}
|
||||
|
||||
@Override
|
||||
protected WritableMap getEventData() {
|
||||
WritableMap eventData = Arguments.createMap();
|
||||
|
||||
-6
@@ -36,12 +36,6 @@ public class DrawerStateChangedEvent extends Event<DrawerStateChangedEvent> {
|
||||
return EVENT_NAME;
|
||||
}
|
||||
|
||||
@Override
|
||||
public short getCoalescingKey() {
|
||||
// All events for a given view can be coalesced.
|
||||
return 0;
|
||||
}
|
||||
|
||||
@Override
|
||||
protected WritableMap getEventData() {
|
||||
WritableMap eventData = Arguments.createMap();
|
||||
|
||||
@@ -124,12 +124,6 @@ public class ScrollEvent extends Event<ScrollEvent> {
|
||||
return ScrollEventType.getJSEventName(Assertions.assertNotNull(mScrollEventType));
|
||||
}
|
||||
|
||||
@Override
|
||||
public short getCoalescingKey() {
|
||||
// All scroll events for a given view can be coalesced
|
||||
return 0;
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean canCoalesce() {
|
||||
// Only SCROLL events can be coalesced, all others can not be
|
||||
|
||||
@@ -39,11 +39,6 @@ public class ReactSliderEvent extends Event<ReactSliderEvent> {
|
||||
return EVENT_NAME;
|
||||
}
|
||||
|
||||
@Override
|
||||
public short getCoalescingKey() {
|
||||
return 0;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void dispatch(RCTEventEmitter rctEventEmitter) {
|
||||
rctEventEmitter.receiveEvent(getViewTag(), getEventName(), serializeEventData());
|
||||
|
||||
-5
@@ -47,11 +47,6 @@ public class ReactSlidingCompleteEvent extends Event<ReactSlidingCompleteEvent>
|
||||
return eventData;
|
||||
}
|
||||
|
||||
@Override
|
||||
public short getCoalescingKey() {
|
||||
return 0;
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean canCoalesce() {
|
||||
return false;
|
||||
|
||||
@@ -46,10 +46,4 @@ import com.facebook.react.uimanager.events.Event;
|
||||
eventData.putBoolean("value", getIsChecked());
|
||||
return eventData;
|
||||
}
|
||||
|
||||
@Override
|
||||
public short getCoalescingKey() {
|
||||
// All switch events for a given view can be coalesced.
|
||||
return 0;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user