From 8fc8cd9aeacde05cc9e85452bf25eed3e055e79b Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Mon, 10 Aug 2020 15:35:09 -0700 Subject: [PATCH] Add todo notes for nativeID hack Summary: Changelog: [internal] Reviewed By: JoshuaGross Differential Revision: D23003735 fbshipit-source-id: 7814de9e1d280604842e47a969ab3e8d453c50a8 --- Libraries/Animated/src/createAnimatedComponent.js | 4 +++- Libraries/Components/ScrollView/ScrollView.js | 2 +- Libraries/Inspector/InspectorOverlay.js | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/Libraries/Animated/src/createAnimatedComponent.js b/Libraries/Animated/src/createAnimatedComponent.js index 29c0dbaba79..4b5a75566e0 100644 --- a/Libraries/Animated/src/createAnimatedComponent.js +++ b/Libraries/Animated/src/createAnimatedComponent.js @@ -223,7 +223,9 @@ function createAnimatedComponent( {...passthruProps} style={mergedStyle} ref={this._setComponentRef} - nativeID={this._isFabric() ? 'animatedComponent' : undefined} + nativeID={ + this._isFabric() ? 'animatedComponent' : undefined + } /* TODO: T68258846. */ // The native driver updates views directly through the UI thread so we // have to make sure the view doesn't get optimized away because it cannot // go through the NativeViewHierarchyManager since it operates on the shadow diff --git a/Libraries/Components/ScrollView/ScrollView.js b/Libraries/Components/ScrollView/ScrollView.js index 4bdea9529d3..c8a56d12686 100644 --- a/Libraries/Components/ScrollView/ScrollView.js +++ b/Libraries/Components/ScrollView/ScrollView.js @@ -1078,7 +1078,7 @@ class ScrollView extends React.Component { return ( this._setStickyHeaderRef(key, ref)} nextHeaderLayoutY={this._headerLayoutYs.get( this._getKeyForIndex(nextIndex, childArray), diff --git a/Libraries/Inspector/InspectorOverlay.js b/Libraries/Inspector/InspectorOverlay.js index c2ad184abce..19fcfd93ba7 100644 --- a/Libraries/Inspector/InspectorOverlay.js +++ b/Libraries/Inspector/InspectorOverlay.js @@ -56,7 +56,7 @@ class InspectorOverlay extends React.Component { {content}