From 8dea0acc23d41672194d9566f0bc2dc1d16b6e87 Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Tue, 19 Nov 2019 16:59:50 -0800 Subject: [PATCH] Fabric: Using LOG(ERROR) instead of LOG(Fatal) in Scheduler Summary: FATAL crashes the app, which was never the intent of that log message. We need to use ERROR instead. Changelog: [INTERNAL] Reviewed By: fkgozali, zackargyle, mdvacca Differential Revision: D18597249 fbshipit-source-id: 523c96550f97e837e1957c933786acf28033e60a --- ReactCommon/fabric/uimanager/Scheduler.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ReactCommon/fabric/uimanager/Scheduler.cpp b/ReactCommon/fabric/uimanager/Scheduler.cpp index bcf88f10074..d81a7a253a5 100644 --- a/ReactCommon/fabric/uimanager/Scheduler.cpp +++ b/ReactCommon/fabric/uimanager/Scheduler.cpp @@ -107,7 +107,7 @@ Scheduler::~Scheduler() { return; } - LOG(FATAL) << "Scheduler was destroyed with outstanding Surfaces."; + LOG(ERROR) << "Scheduler was destroyed with outstanding Surfaces."; // If we are here, that means assert didn't fire which indicates that we in // production.