Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fabric: Using LOG(ERROR) instead of LOG(Fatal) in Scheduler

Browse Source 
Summary:
FATAL crashes the app, which was never the intent of that log message.
We need to use ERROR instead.

Changelog: [INTERNAL]

Reviewed By: fkgozali, zackargyle, mdvacca

Differential Revision: D18597249

fbshipit-source-id: 523c96550f97e837e1957c933786acf28033e60a
This commit is contained in:
Valentin Shergin
2019-11-19 17:01:55 -08:00
committed by Facebook Github Bot
parent 25a21b8e49
commit 8dea0acc23
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/fabric/uimanager/Scheduler.cpp
+1 -1
View File
@@ -107,7 +107,7 @@ Scheduler::~Scheduler() {
return;
}
LOG(FATAL) << "Scheduler was destroyed with outstanding Surfaces.";
LOG(ERROR) << "Scheduler was destroyed with outstanding Surfaces.";
// If we are here, that means assert didn't fire which indicates that we in
// production.