From 8da5924b57206f10a5d67a61ebfe4b82984edcc8 Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Mon, 16 Sep 2024 09:16:56 -0700 Subject: [PATCH] add std::move when adding task to taskQueue (#46511) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46511 changelog: [internal] task is not used after this line of code. Let's avoid copy shared_ptr's copy constructor. Reviewed By: rubennorte Differential Revision: D62751612 fbshipit-source-id: 92b0da44972b200870ef66f3a8482fbde55052ac --- .../react/renderer/runtimescheduler/RuntimeScheduler_Modern.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Modern.cpp b/packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Modern.cpp index 8d548155d96..faa13fd0571 100644 --- a/packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Modern.cpp +++ b/packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Modern.cpp @@ -253,7 +253,7 @@ void RuntimeScheduler_Modern::scheduleTask(std::shared_ptr task) { shouldScheduleEventLoop = true; } - taskQueue_.push(task); + taskQueue_.push(std::move(task)); } if (shouldScheduleEventLoop) {