Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix MapBuffer.getString() method

Browse Source 
Summary:
found a bug in MapBuffer.getString() method, this diff is fixing it

changelog: [internal] internal

Reviewed By: sammy-SC

Differential Revision: D27904644

fbshipit-source-id: 746812235539ff75c5ce53c6f872ede9779fa1fa
This commit is contained in:
David Vacca
2021-04-21 10:27:57 -07:00
committed by Facebook GitHub Bot
parent e92be1c14b
commit 8cdba40987
2 changed files with 21 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/react/renderer/mapbuffer/tests/MapBufferTest.cpp
+14 -2
View File
@@ -70,7 +70,8 @@ TEST(MapBufferTest, testNullEntries) {
EXPECT_EQ(map.getCount(), 2);
EXPECT_EQ(map.isNull(0), true);
EXPECT_EQ(map.isNull(1), false);
// TODO T83483191: serialize null values to be distinguishable from '0' values
// TODO T83483191: serialize null values to be distinguishable from '0'
// values
// EXPECT_EQ(map.isNull(1), false);
// EXPECT_EQ(map.getBool(1), false);
}
@@ -98,7 +99,7 @@ TEST(MapBufferTest, testStringEntries) {
EXPECT_EQ(map.getString(0), "This is a test");
}
TEST(MapBufferTest, testUTFStringEntries) {
TEST(MapBufferTest, testUTFStringEntry) {
auto builder = MapBufferBuilder();
builder.putString(0, "Let's count: 的, 一, 是");
@@ -107,6 +108,17 @@ TEST(MapBufferTest, testUTFStringEntries) {
EXPECT_EQ(map.getString(0), "Let's count: 的, 一, 是");
}
TEST(MapBufferTest, testUTFStringEntries) {
auto builder = MapBufferBuilder();
builder.putString(0, "Let's count: 的, 一, 是");
builder.putString(1, "This is a test");
auto map = builder.build();
EXPECT_EQ(map.getString(0), "Let's count: 的, 一, 是");
EXPECT_EQ(map.getString(1), "This is a test");
}
TEST(MapBufferTest, testEmptyMap) {
auto builder = MapBufferBuilder();
auto map = builder.build();