Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix MapBuffer.getString() method

Browse Source 
Summary:
found a bug in MapBuffer.getString() method, this diff is fixing it

changelog: [internal] internal

Reviewed By: sammy-SC

Differential Revision: D27904644

fbshipit-source-id: 746812235539ff75c5ce53c6f872ede9779fa1fa
This commit is contained in:
David Vacca
2021-04-21 10:27:57 -07:00
committed by Facebook GitHub Bot
parent e92be1c14b
commit 8cdba40987
2 changed files with 21 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/react/renderer/mapbuffer/MapBuffer.cpp
+7 -5
View File
@@ -12,6 +12,8 @@ using namespace facebook::react;
namespace facebook {
namespace react {
// TODO T83483191: Extend MapBuffer C++ implementation to support basic random
// access
MapBuffer::MapBuffer(uint8_t *const data, uint16_t dataSize) {
react_native_assert(
(data != nullptr) && "Error trying to build an invalid MapBuffer");
@@ -75,21 +77,21 @@ std::string MapBuffer::getString(Key key) const {
// of the map buffer
int dynamicDataOffset = getDynamicDataOffset();
int stringLength = 0;
int offset = getInt(key);
memcpy(
reinterpret_cast<uint8_t *>(&stringLength),
reinterpret_cast<const uint8_t *>(data_ + dynamicDataOffset),
reinterpret_cast<const uint8_t *>(data_ + dynamicDataOffset + offset),
INT_SIZE);
int valueOffset = getInt(key) + sizeof(stringLength);
char *value = new char[stringLength];
memcpy(
reinterpret_cast<char *>(value),
reinterpret_cast<const char *>(data_ + dynamicDataOffset + valueOffset),
reinterpret_cast<const char *>(
data_ + dynamicDataOffset + offset + INT_SIZE),
stringLength);
return std::string(value);
return std::string(value, 0, stringLength);
}
MapBuffer MapBuffer::getMapBuffer(Key key) const {