From 8c50bf0beb17ced7fdafeae7a734edfc03e6e0b2 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Tue, 5 Nov 2024 07:35:36 -0800 Subject: [PATCH] Stable API - Make `DevLoadingModule` internal (#47368) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/47368 This class should be internal and has no meaningful usages outside of React Native. See https://github.com/search?type=code&q=%22DevLoadingModule%3A%3Aclass%22 So technically breaking but I expect no impact for OSS at all. Changelog: [Android] [Breaking] - Make `DevLoadingModule` internal Reviewed By: javache Differential Revision: D64725164 fbshipit-source-id: 5f39e609c611662c71cc08bffa195f7bea5db5bd --- .../react-native/ReactAndroid/api/ReactAndroid.api | 11 ----------- .../react/modules/devloading/DevLoadingModule.kt | 2 +- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/packages/react-native/ReactAndroid/api/ReactAndroid.api b/packages/react-native/ReactAndroid/api/ReactAndroid.api index b238f03c159..1c62bbff571 100644 --- a/packages/react-native/ReactAndroid/api/ReactAndroid.api +++ b/packages/react-native/ReactAndroid/api/ReactAndroid.api @@ -3303,17 +3303,6 @@ public final class com/facebook/react/modules/deviceinfo/DeviceInfoModule : com/ public fun onHostResume ()V } -public final class com/facebook/react/modules/devloading/DevLoadingModule : com/facebook/fbreact/specs/NativeDevLoadingViewSpec { - public static final field Companion Lcom/facebook/react/modules/devloading/DevLoadingModule$Companion; - public static final field NAME Ljava/lang/String; - public fun (Lcom/facebook/react/bridge/ReactApplicationContext;)V - public fun hide ()V - public fun showMessage (Ljava/lang/String;Ljava/lang/Double;Ljava/lang/Double;)V -} - -public final class com/facebook/react/modules/devloading/DevLoadingModule$Companion { -} - public class com/facebook/react/modules/dialog/AlertFragment : androidx/fragment/app/DialogFragment, android/content/DialogInterface$OnClickListener { public fun ()V public fun (Lcom/facebook/react/modules/dialog/DialogModule$AlertFragmentListener;Landroid/os/Bundle;)V diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/devloading/DevLoadingModule.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/devloading/DevLoadingModule.kt index 3457b3ae78c..6796c8c6a03 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/devloading/DevLoadingModule.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/devloading/DevLoadingModule.kt @@ -18,7 +18,7 @@ import com.facebook.react.module.annotations.ReactModule /** [NativeModule] that allows JS to show dev loading view. */ @ReactModule(name = NativeDevLoadingViewSpec.NAME) -public class DevLoadingModule(reactContext: ReactApplicationContext) : +internal class DevLoadingModule(reactContext: ReactApplicationContext) : NativeDevLoadingViewSpec(reactContext) { private val jsExceptionHandler: JSExceptionHandler? = reactContext.jsExceptionHandler