From 8c3cb4e6dbed367fbf6dc1c82da14dca4f1ca723 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Wed, 15 Mar 2023 16:03:39 -0700 Subject: [PATCH] Refactor TextLayoutManager.isRTL() method Summary: Quick refactor of refactor TextLayoutManager.isRTL() method to cleanup the method and remove lint warning changelog: [internal] internal Reviewed By: javache Differential Revision: D43888197 fbshipit-source-id: 779fb84527f95b3c04504eaa4302be55ab328634 --- .../com/facebook/react/views/text/TextLayoutManager.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.java index 870545bc5f4..364679fa7e3 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.java @@ -72,11 +72,12 @@ public class TextLayoutManager { public static boolean isRTL(ReadableMap attributedString) { ReadableArray fragments = attributedString.getArray("fragments"); - for (int i = 0; i < fragments.size(); i++) { - ReadableMap fragment = fragments.getMap(i); + if (fragments != null && fragments.size() > 0) { + ReadableMap fragment = fragments.getMap(0); ReadableMap map = fragment.getMap("textAttributes"); - return TextAttributeProps.getLayoutDirection(map.getString(ViewProps.LAYOUT_DIRECTION)) - == LayoutDirection.RTL; + return map != null + && TextAttributeProps.getLayoutDirection(map.getString(ViewProps.LAYOUT_DIRECTION)) + == LayoutDirection.RTL; } return false; }