mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Pull PopupMenuAndroid out of React Native core
Summary: **History:** This component was originally introduced into React Native core in D52712758, to replace UIManagerModule.showPopupMenu(). **Problem:** But, React Native core should be lean. Adding this component to React Native bloats the core. **Changes:** So, this diff pulls PopupMenuAndroid out into its own package in the react-native GitHub repository. In the future, this will be migrated to a community package! Changelog: [Android][Removed] Move PopupMenu out of React Native core Reviewed By: NickGerleman Differential Revision: D53328110 fbshipit-source-id: 469d8dc3e756c06040c72e08fa004aafa1bd6e18
This commit is contained in:
1 parent
e6e5822d07
commit
8bced4b29d
37 files changed
+482
-129
No files matched your search
@@ -42,6 +42,7 @@ project.xcworkspace
|
||||
/packages/react-native/ReactAndroid/hermes-engine/.cxx/
|
||||
/packages/react-native/template/android/app/build/
|
||||
/packages/react-native/template/android/build/
|
||||
/packages/react-native-popup-menu-android/android/build/
|
||||
|
||||
# Buck
|
||||
.buckd
|
||||
|
||||
@@ -0,0 +1,35 @@
|
||||
/*
|
||||
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
||||
*
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*/
|
||||
|
||||
plugins {
|
||||
id("com.facebook.react")
|
||||
alias(libs.plugins.android.library)
|
||||
alias(libs.plugins.kotlin.android)
|
||||
}
|
||||
|
||||
android {
|
||||
compileSdk = libs.versions.compileSdk.get().toInt()
|
||||
buildToolsVersion = libs.versions.buildTools.get()
|
||||
namespace = "com.facebook.react.popupmenu"
|
||||
|
||||
defaultConfig {
|
||||
minSdk = libs.versions.minSdk.get().toInt()
|
||||
targetSdk = libs.versions.targetSdk.get().toInt()
|
||||
}
|
||||
|
||||
compileOptions {
|
||||
sourceCompatibility = JavaVersion.VERSION_17
|
||||
targetCompatibility = JavaVersion.VERSION_17
|
||||
}
|
||||
|
||||
kotlinOptions { jvmTarget = "17" }
|
||||
}
|
||||
|
||||
dependencies {
|
||||
// Build React Native from source
|
||||
implementation(project(":packages:react-native:ReactAndroid"))
|
||||
}
|
||||
@@ -0,0 +1,3 @@
|
||||
# We want to have more fine grained control on the Java version for
|
||||
# ReactAndroid, therefore we disable RGNP Java version alignment mechanism
|
||||
react.internal.disableJavaVersionAlignment=true
|
||||
+20
@@ -0,0 +1,20 @@
|
||||
|
||||
/**
|
||||
* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
|
||||
*
|
||||
* Do not edit this file as changes may cause incorrect behavior and will be lost
|
||||
* once the code is regenerated.
|
||||
*
|
||||
* @generated by codegen project: GenerateComponentDescriptorH.js
|
||||
*/
|
||||
|
||||
#pragma once
|
||||
|
||||
#include "ShadowNodes.h"
|
||||
#include <react/renderer/core/ConcreteComponentDescriptor.h>
|
||||
|
||||
namespace facebook::react {
|
||||
|
||||
using AndroidPopupMenuComponentDescriptor = ConcreteComponentDescriptor<AndroidPopupMenuShadowNode>;
|
||||
|
||||
} // namespace facebook::react
|
||||
+24
@@ -0,0 +1,24 @@
|
||||
|
||||
/**
|
||||
* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
|
||||
*
|
||||
* Do not edit this file as changes may cause incorrect behavior and will be lost
|
||||
* once the code is regenerated.
|
||||
*
|
||||
* @generated by codegen project: GenerateEventEmitterCpp.js
|
||||
*/
|
||||
|
||||
#include "EventEmitters.h"
|
||||
|
||||
|
||||
namespace facebook::react {
|
||||
|
||||
void AndroidPopupMenuEventEmitter::onSelectionChange(OnSelectionChange $event) const {
|
||||
dispatchEvent("selectionChange", [$event=std::move($event)](jsi::Runtime &runtime) {
|
||||
auto $payload = jsi::Object(runtime);
|
||||
$payload.setProperty(runtime, "item", $event.item);
|
||||
return $payload;
|
||||
});
|
||||
}
|
||||
|
||||
} // namespace facebook::react
|
||||
+25
@@ -0,0 +1,25 @@
|
||||
|
||||
/**
|
||||
* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
|
||||
*
|
||||
* Do not edit this file as changes may cause incorrect behavior and will be lost
|
||||
* once the code is regenerated.
|
||||
*
|
||||
* @generated by codegen project: GenerateEventEmitterH.js
|
||||
*/
|
||||
#pragma once
|
||||
|
||||
#include <react/renderer/components/view/ViewEventEmitter.h>
|
||||
|
||||
|
||||
namespace facebook::react {
|
||||
class AndroidPopupMenuEventEmitter : public ViewEventEmitter {
|
||||
public:
|
||||
using ViewEventEmitter::ViewEventEmitter;
|
||||
|
||||
struct OnSelectionChange {
|
||||
int item;
|
||||
};
|
||||
void onSelectionChange(OnSelectionChange value) const;
|
||||
};
|
||||
} // namespace facebook::react
|
||||
+25
@@ -0,0 +1,25 @@
|
||||
|
||||
/**
|
||||
* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
|
||||
*
|
||||
* Do not edit this file as changes may cause incorrect behavior and will be lost
|
||||
* once the code is regenerated.
|
||||
*
|
||||
* @generated by codegen project: GeneratePropsCpp.js
|
||||
*/
|
||||
|
||||
#include "Props.h"
|
||||
#include <react/renderer/core/PropsParserContext.h>
|
||||
#include <react/renderer/core/propsConversions.h>
|
||||
|
||||
namespace facebook::react {
|
||||
|
||||
AndroidPopupMenuProps::AndroidPopupMenuProps(
|
||||
const PropsParserContext &context,
|
||||
const AndroidPopupMenuProps &sourceProps,
|
||||
const RawProps &rawProps): ViewProps(context, sourceProps, rawProps),
|
||||
|
||||
menuItems(convertRawProp(context, rawProps, "menuItems", sourceProps.menuItems, {}))
|
||||
{}
|
||||
|
||||
} // namespace facebook::react
|
||||
+28
@@ -0,0 +1,28 @@
|
||||
|
||||
/**
|
||||
* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
|
||||
*
|
||||
* Do not edit this file as changes may cause incorrect behavior and will be lost
|
||||
* once the code is regenerated.
|
||||
*
|
||||
* @generated by codegen project: GeneratePropsH.js
|
||||
*/
|
||||
#pragma once
|
||||
|
||||
#include <react/renderer/components/view/ViewProps.h>
|
||||
#include <react/renderer/core/PropsParserContext.h>
|
||||
#include <vector>
|
||||
|
||||
namespace facebook::react {
|
||||
|
||||
class AndroidPopupMenuProps final : public ViewProps {
|
||||
public:
|
||||
AndroidPopupMenuProps() = default;
|
||||
AndroidPopupMenuProps(const PropsParserContext& context, const AndroidPopupMenuProps &sourceProps, const RawProps &rawProps);
|
||||
|
||||
#pragma mark - Props
|
||||
|
||||
std::vector<std::string> menuItems{};
|
||||
};
|
||||
|
||||
} // namespace facebook::react
|
||||
+17
@@ -0,0 +1,17 @@
|
||||
|
||||
/**
|
||||
* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
|
||||
*
|
||||
* Do not edit this file as changes may cause incorrect behavior and will be lost
|
||||
* once the code is regenerated.
|
||||
*
|
||||
* @generated by codegen project: GenerateShadowNodeCpp.js
|
||||
*/
|
||||
|
||||
#include "ShadowNodes.h"
|
||||
|
||||
namespace facebook::react {
|
||||
|
||||
extern const char AndroidPopupMenuComponentName[] = "AndroidPopupMenu";
|
||||
|
||||
} // namespace facebook::react
|
||||
+32
@@ -0,0 +1,32 @@
|
||||
|
||||
/**
|
||||
* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
|
||||
*
|
||||
* Do not edit this file as changes may cause incorrect behavior and will be lost
|
||||
* once the code is regenerated.
|
||||
*
|
||||
* @generated by codegen project: GenerateShadowNodeH.js
|
||||
*/
|
||||
|
||||
#pragma once
|
||||
|
||||
#include "EventEmitters.h"
|
||||
#include "Props.h"
|
||||
#include "States.h"
|
||||
#include <react/renderer/components/view/ConcreteViewShadowNode.h>
|
||||
#include <jsi/jsi.h>
|
||||
|
||||
namespace facebook::react {
|
||||
|
||||
JSI_EXPORT extern const char AndroidPopupMenuComponentName[];
|
||||
|
||||
/*
|
||||
* `ShadowNode` for <AndroidPopupMenu> component.
|
||||
*/
|
||||
using AndroidPopupMenuShadowNode = ConcreteViewShadowNode<
|
||||
AndroidPopupMenuComponentName,
|
||||
AndroidPopupMenuProps,
|
||||
AndroidPopupMenuEventEmitter,
|
||||
AndroidPopupMenuState>;
|
||||
|
||||
} // namespace facebook::react
|
||||
+16
@@ -0,0 +1,16 @@
|
||||
|
||||
/**
|
||||
* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
|
||||
*
|
||||
* Do not edit this file as changes may cause incorrect behavior and will be lost
|
||||
* once the code is regenerated.
|
||||
*
|
||||
* @generated by codegen project: GenerateStateCpp.js
|
||||
*/
|
||||
#include "States.h"
|
||||
|
||||
namespace facebook::react {
|
||||
|
||||
|
||||
|
||||
} // namespace facebook::react
|
||||
+34
@@ -0,0 +1,34 @@
|
||||
/**
|
||||
* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
|
||||
*
|
||||
* Do not edit this file as changes may cause incorrect behavior and will be lost
|
||||
* once the code is regenerated.
|
||||
*
|
||||
* @generated by codegen project: GenerateStateH.js
|
||||
*/
|
||||
#pragma once
|
||||
|
||||
#ifdef ANDROID
|
||||
#include <folly/dynamic.h>
|
||||
#include <react/renderer/mapbuffer/MapBuffer.h>
|
||||
#include <react/renderer/mapbuffer/MapBufferBuilder.h>
|
||||
#endif
|
||||
|
||||
namespace facebook::react {
|
||||
|
||||
class AndroidPopupMenuState {
|
||||
public:
|
||||
AndroidPopupMenuState() = default;
|
||||
|
||||
#ifdef ANDROID
|
||||
AndroidPopupMenuState(AndroidPopupMenuState const &previousState, folly::dynamic data){};
|
||||
folly::dynamic getDynamic() const {
|
||||
return {};
|
||||
};
|
||||
MapBuffer getMapBuffer() const {
|
||||
return MapBufferBuilder::EMPTY();
|
||||
};
|
||||
#endif
|
||||
};
|
||||
|
||||
} // namespace facebook::react
|
||||
+56
@@ -0,0 +1,56 @@
|
||||
/*
|
||||
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
||||
*
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*/
|
||||
|
||||
package com.facebook.react.popupmenu
|
||||
|
||||
import com.facebook.react.BaseReactPackage
|
||||
import com.facebook.react.ViewManagerOnDemandReactPackage
|
||||
import com.facebook.react.bridge.ModuleSpec
|
||||
import com.facebook.react.bridge.NativeModule
|
||||
import com.facebook.react.bridge.ReactApplicationContext
|
||||
import com.facebook.react.module.annotations.ReactModuleList
|
||||
import com.facebook.react.module.model.ReactModuleInfoProvider
|
||||
import com.facebook.react.uimanager.ViewManager
|
||||
|
||||
@ReactModuleList(nativeModules = arrayOf())
|
||||
class PopupMenuPackage() : BaseReactPackage(), ViewManagerOnDemandReactPackage {
|
||||
private var viewManagersMap: Map<String, ModuleSpec>? = null
|
||||
|
||||
override fun getModule(name: String, context: ReactApplicationContext): NativeModule? {
|
||||
return null
|
||||
}
|
||||
|
||||
private fun getViewManagersMap(): Map<String, ModuleSpec> {
|
||||
val viewManagers =
|
||||
viewManagersMap
|
||||
?: mapOf(
|
||||
ReactPopupMenuManager.REACT_CLASS to
|
||||
ModuleSpec.viewManagerSpec({ ReactPopupMenuManager() }))
|
||||
viewManagersMap = viewManagers
|
||||
return viewManagers
|
||||
}
|
||||
|
||||
protected override fun getViewManagers(context: ReactApplicationContext): List<ModuleSpec> {
|
||||
return ArrayList(getViewManagersMap().values)
|
||||
}
|
||||
|
||||
override fun getViewManagerNames(context: ReactApplicationContext): Collection<String> {
|
||||
return getViewManagersMap().keys
|
||||
}
|
||||
|
||||
override fun createViewManager(
|
||||
reactContext: ReactApplicationContext,
|
||||
viewManagerName: String
|
||||
): ViewManager<*, *>? {
|
||||
val spec: ModuleSpec? = getViewManagersMap().get(viewManagerName)
|
||||
return if (spec != null) (spec.getProvider().get() as ViewManager<*, *>) else null
|
||||
}
|
||||
|
||||
override fun getReactModuleInfoProvider(): ReactModuleInfoProvider {
|
||||
return ReactModuleInfoProvider { emptyMap() }
|
||||
}
|
||||
}
|
||||
+1
-3
@@ -5,9 +5,7 @@
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*/
|
||||
|
||||
@file:Suppress("DEPRECATION") // We want to use RCTEventEmitter for interop purposes
|
||||
|
||||
package com.facebook.react.views.popupmenu
|
||||
package com.facebook.react.popupmenu
|
||||
|
||||
import com.facebook.react.bridge.Arguments
|
||||
import com.facebook.react.bridge.WritableMap
|
||||
+1
-1
@@ -5,7 +5,7 @@
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*/
|
||||
|
||||
package com.facebook.react.views.popupmenu
|
||||
package com.facebook.react.popupmenu
|
||||
|
||||
import android.content.Context
|
||||
import android.os.Build
|
||||
+1
-1
@@ -5,7 +5,7 @@
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*/
|
||||
|
||||
package com.facebook.react.views.popupmenu
|
||||
package com.facebook.react.popupmenu
|
||||
|
||||
import com.facebook.react.bridge.ReadableArray
|
||||
import com.facebook.react.module.annotations.ReactModule
|
||||
+41
@@ -0,0 +1,41 @@
|
||||
/**
|
||||
* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
|
||||
*
|
||||
* Do not edit this file as changes may cause incorrect behavior and will be lost
|
||||
* once the code is regenerated.
|
||||
*
|
||||
* @generated by codegen project: GeneratePropsJavaDelegate.js
|
||||
*/
|
||||
|
||||
package com.facebook.react.viewmanagers;
|
||||
|
||||
import android.view.View;
|
||||
import androidx.annotation.Nullable;
|
||||
import com.facebook.react.bridge.ReadableArray;
|
||||
import com.facebook.react.uimanager.BaseViewManagerDelegate;
|
||||
import com.facebook.react.uimanager.BaseViewManagerInterface;
|
||||
|
||||
public class AndroidPopupMenuManagerDelegate<T extends View, U extends BaseViewManagerInterface<T> & AndroidPopupMenuManagerInterface<T>> extends BaseViewManagerDelegate<T, U> {
|
||||
public AndroidPopupMenuManagerDelegate(U viewManager) {
|
||||
super(viewManager);
|
||||
}
|
||||
@Override
|
||||
public void setProperty(T view, String propName, @Nullable Object value) {
|
||||
switch (propName) {
|
||||
case "menuItems":
|
||||
mViewManager.setMenuItems(view, (ReadableArray) value);
|
||||
break;
|
||||
default:
|
||||
super.setProperty(view, propName, value);
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
public void receiveCommand(T view, String commandName, ReadableArray args) {
|
||||
switch (commandName) {
|
||||
case "show":
|
||||
mViewManager.show(view);
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
+19
@@ -0,0 +1,19 @@
|
||||
/**
|
||||
* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
|
||||
*
|
||||
* Do not edit this file as changes may cause incorrect behavior and will be lost
|
||||
* once the code is regenerated.
|
||||
*
|
||||
* @generated by codegen project: GeneratePropsJavaInterface.js
|
||||
*/
|
||||
|
||||
package com.facebook.react.viewmanagers;
|
||||
|
||||
import android.view.View;
|
||||
import androidx.annotation.Nullable;
|
||||
import com.facebook.react.bridge.ReadableArray;
|
||||
|
||||
public interface AndroidPopupMenuManagerInterface<T extends View> {
|
||||
void setMenuItems(T view, @Nullable ReadableArray value);
|
||||
void show(T view);
|
||||
}
|
||||
@@ -0,0 +1,11 @@
|
||||
/**
|
||||
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
||||
*
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @format
|
||||
*/
|
||||
|
||||
export type {default} from './PopupMenuAndroid';
|
||||
export type {PopupMenuAndroidInstance} from './PopupMenuAndroid';
|
||||
@@ -0,0 +1,12 @@
|
||||
/**
|
||||
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
||||
*
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @flow strict-local
|
||||
* @format
|
||||
*/
|
||||
|
||||
export {default} from './js/PopupMenuAndroid';
|
||||
export type {PopupMenuAndroidInstance} from './js/PopupMenuAndroid';
|
||||
+2
-2
@@ -8,9 +8,9 @@
|
||||
* @flow strict-local
|
||||
*/
|
||||
|
||||
import type {HostComponent} from '../../Renderer/shims/ReactNativeTypes';
|
||||
import type {SyntheticEvent} from '../../Types/CoreEventTypes';
|
||||
import type {RefObject} from 'react';
|
||||
import type {HostComponent} from 'react-native';
|
||||
import type {SyntheticEvent} from 'react-native/Libraries/Types/CoreEventTypes';
|
||||
|
||||
import PopupMenuAndroidNativeComponent, {
|
||||
Commands,
|
||||
+1
-1
@@ -8,7 +8,7 @@
|
||||
*/
|
||||
|
||||
import type * as React from 'react';
|
||||
import {HostComponent} from '../../../types/public/ReactNativeTypes';
|
||||
import {HostComponent} from 'react-native';
|
||||
|
||||
type PopupMenuAndroidInstance = {
|
||||
show: () => void;
|
||||
+23
-2
@@ -12,8 +12,29 @@ import type {RefObject} from 'react';
|
||||
import type {Node} from 'react';
|
||||
|
||||
import * as React from 'react';
|
||||
import {StyleSheet, View} from 'react-native';
|
||||
|
||||
const UnimplementedView = require('../UnimplementedViews/UnimplementedView');
|
||||
/**
|
||||
* Common implementation for a simple stubbed view. Simply applies the view's styles to the inner
|
||||
* View component and renders its children.
|
||||
*/
|
||||
class UnimplementedView extends React.Component<{children: Node}> {
|
||||
render(): React.Node {
|
||||
return (
|
||||
<View style={[styles.unimplementedView]}>{this.props.children}</View>
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
const styles = StyleSheet.create({
|
||||
unimplementedView: __DEV__
|
||||
? {
|
||||
alignSelf: 'flex-start',
|
||||
borderColor: 'red',
|
||||
borderWidth: 1,
|
||||
}
|
||||
: {},
|
||||
});
|
||||
|
||||
export type PopupMenuAndroidInstance = {
|
||||
+show: () => void,
|
||||
@@ -27,7 +48,7 @@ type Props = {
|
||||
};
|
||||
|
||||
function PopupMenuAndroid(props: Props): Node {
|
||||
return <UnimplementedView />;
|
||||
return <UnimplementedView>{props.children}</UnimplementedView>;
|
||||
}
|
||||
|
||||
export default PopupMenuAndroid;
|
||||
+5
-5
@@ -8,16 +8,16 @@
|
||||
* @format
|
||||
*/
|
||||
|
||||
import type {ViewProps} from '../../../../Libraries/Components/View/ViewPropTypes';
|
||||
import type {HostComponent} from '../../../../Libraries/Renderer/shims/ReactNativeTypes';
|
||||
import type {ViewProps} from 'react-native/Libraries/Components/View/ViewPropTypes';
|
||||
import type {HostComponent} from 'react-native/Libraries/Renderer/shims/ReactNativeTypes';
|
||||
import type {
|
||||
DirectEventHandler,
|
||||
Int32,
|
||||
} from '../../../../Libraries/Types/CodegenTypes';
|
||||
} from 'react-native/Libraries/Types/CodegenTypes';
|
||||
|
||||
import codegenNativeCommands from '../../../../Libraries/Utilities/codegenNativeCommands';
|
||||
import codegenNativeComponent from '../../../../Libraries/Utilities/codegenNativeComponent';
|
||||
import * as React from 'react';
|
||||
import codegenNativeCommands from 'react-native/Libraries/Utilities/codegenNativeCommands';
|
||||
import codegenNativeComponent from 'react-native/Libraries/Utilities/codegenNativeComponent';
|
||||
|
||||
type PopupMenuSelectionEvent = $ReadOnly<{
|
||||
item: Int32,
|
||||
@@ -0,0 +1,39 @@
|
||||
{
|
||||
"name": "@react-native/popup-menu-android",
|
||||
"version": "0.74.0",
|
||||
"description": "PopupMenu for the Android platform",
|
||||
"react-native": "js/PopupMenuAndroid",
|
||||
"source": "js/PopupMenuAndroid",
|
||||
"files": [
|
||||
"js",
|
||||
"android",
|
||||
"!android/build",
|
||||
"!**/__tests__",
|
||||
"!**/__fixtures__",
|
||||
"!**/__mocks__"
|
||||
],
|
||||
"keywords": ["react-native", "android"],
|
||||
"license": "MIT",
|
||||
"devDependencies": {
|
||||
"@react-native/codegen": "*"
|
||||
},
|
||||
"peerDependencies": {
|
||||
"react": "*",
|
||||
"react-native": "*"
|
||||
},
|
||||
"dependencies": {
|
||||
"nullthrows": "^1.1.1"
|
||||
},
|
||||
"codegenConfig": {
|
||||
"name": "ReactPopupMenuAndroidSpecs",
|
||||
"type": "components",
|
||||
"jsSrcsDir": "js",
|
||||
"outputDir": {
|
||||
"android": "android"
|
||||
},
|
||||
"includesGeneratedCode": true,
|
||||
"android": {
|
||||
"javaPackageName": "com.facebook.react.viewmanagers"
|
||||
}
|
||||
}
|
||||
}
|
||||
Vendored
-13
@@ -1,13 +0,0 @@
|
||||
/**
|
||||
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
||||
*
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @format
|
||||
* @flow strict-local
|
||||
*/
|
||||
|
||||
export * from '../../../src/private/specs/components/PopupMenuAndroidNativeComponent';
|
||||
import PopupMenuAndroidNativeComponent from '../../../src/private/specs/components/PopupMenuAndroidNativeComponent';
|
||||
export default PopupMenuAndroidNativeComponent;
|
||||
@@ -1773,41 +1773,6 @@ declare export default typeof NativeKeyboardObserver;
|
||||
"
|
||||
`;
|
||||
|
||||
exports[`public API should not change unintentionally Libraries/Components/PopupMenuAndroid/PopupMenuAndroid.android.js 1`] = `
|
||||
"export type PopupMenuAndroidInstance = {
|
||||
+show: () => void,
|
||||
};
|
||||
type Props = {
|
||||
menuItems: $ReadOnlyArray<string>,
|
||||
onSelectionChange: (number) => void,
|
||||
children: React.Node,
|
||||
instanceRef: RefObject<?PopupMenuAndroidInstance>,
|
||||
};
|
||||
declare export default function PopupMenuAndroid(Props): React.Node;
|
||||
"
|
||||
`;
|
||||
|
||||
exports[`public API should not change unintentionally Libraries/Components/PopupMenuAndroid/PopupMenuAndroid.js 1`] = `
|
||||
"export type PopupMenuAndroidInstance = {
|
||||
+show: () => void,
|
||||
};
|
||||
type Props = {
|
||||
menuItems: $ReadOnlyArray<string>,
|
||||
onSelectionChange: (number) => void,
|
||||
children: Node,
|
||||
instanceRef: RefObject<?PopupMenuAndroidInstance>,
|
||||
};
|
||||
declare function PopupMenuAndroid(props: Props): Node;
|
||||
declare export default typeof PopupMenuAndroid;
|
||||
"
|
||||
`;
|
||||
|
||||
exports[`public API should not change unintentionally Libraries/Components/PopupMenuAndroid/PopupMenuAndroidNativeComponent.js 1`] = `
|
||||
"export * from \\"../../../src/private/specs/components/PopupMenuAndroidNativeComponent\\";
|
||||
declare export default typeof PopupMenuAndroidNativeComponent;
|
||||
"
|
||||
`;
|
||||
|
||||
exports[`public API should not change unintentionally Libraries/Components/Pressable/Pressable.js 1`] = `
|
||||
"type ViewStyleProp = $ElementType<React.ElementConfig<typeof View>, \\"style\\">;
|
||||
export type StateCallbackType = $ReadOnly<{|
|
||||
@@ -9026,7 +8991,6 @@ declare module.exports: {
|
||||
get ImageBackground(): ImageBackground,
|
||||
get InputAccessoryView(): InputAccessoryView,
|
||||
get KeyboardAvoidingView(): KeyboardAvoidingView,
|
||||
get PopupMenuAndroid(): PopupMenuAndroid,
|
||||
get Modal(): Modal,
|
||||
get Pressable(): Pressable,
|
||||
get ProgressBarAndroid(): ProgressBarAndroid,
|
||||
|
||||
@@ -5657,17 +5657,6 @@ public abstract interface class com/facebook/react/viewmanagers/AndroidHorizonta
|
||||
public abstract fun setRemoveClippedSubviews (Landroid/view/View;Z)V
|
||||
}
|
||||
|
||||
public class com/facebook/react/viewmanagers/AndroidPopupMenuManagerDelegate : com/facebook/react/uimanager/BaseViewManagerDelegate {
|
||||
public fun <init> (Lcom/facebook/react/uimanager/BaseViewManagerInterface;)V
|
||||
public fun receiveCommand (Landroid/view/View;Ljava/lang/String;Lcom/facebook/react/bridge/ReadableArray;)V
|
||||
public fun setProperty (Landroid/view/View;Ljava/lang/String;Ljava/lang/Object;)V
|
||||
}
|
||||
|
||||
public abstract interface class com/facebook/react/viewmanagers/AndroidPopupMenuManagerInterface {
|
||||
public abstract fun setMenuItems (Landroid/view/View;Lcom/facebook/react/bridge/ReadableArray;)V
|
||||
public abstract fun show (Landroid/view/View;)V
|
||||
}
|
||||
|
||||
public class com/facebook/react/viewmanagers/AndroidProgressBarManagerDelegate : com/facebook/react/uimanager/BaseViewManagerDelegate {
|
||||
public fun <init> (Lcom/facebook/react/uimanager/BaseViewManagerInterface;)V
|
||||
public fun setProperty (Landroid/view/View;Ljava/lang/String;Ljava/lang/Object;)V
|
||||
@@ -6137,47 +6126,6 @@ public abstract interface class com/facebook/react/views/modal/ReactModalHostVie
|
||||
public abstract fun onRequestClose (Landroid/content/DialogInterface;)V
|
||||
}
|
||||
|
||||
public final class com/facebook/react/views/popupmenu/PopupMenuSelectionEvent : com/facebook/react/uimanager/events/Event {
|
||||
public static final field Companion Lcom/facebook/react/views/popupmenu/PopupMenuSelectionEvent$Companion;
|
||||
public static final field EVENT_NAME Ljava/lang/String;
|
||||
public fun <init> (III)V
|
||||
public fun dispatch (Lcom/facebook/react/uimanager/events/RCTEventEmitter;)V
|
||||
public fun getEventName ()Ljava/lang/String;
|
||||
}
|
||||
|
||||
public final class com/facebook/react/views/popupmenu/PopupMenuSelectionEvent$Companion {
|
||||
}
|
||||
|
||||
public final class com/facebook/react/views/popupmenu/ReactPopupMenuContainer : android/widget/FrameLayout {
|
||||
public fun <init> (Landroid/content/Context;)V
|
||||
public final fun setMenuItems (Lcom/facebook/react/bridge/ReadableArray;)V
|
||||
public final fun showPopupMenu ()V
|
||||
}
|
||||
|
||||
public final class com/facebook/react/views/popupmenu/ReactPopupMenuManager : com/facebook/react/uimanager/ViewGroupManager, com/facebook/react/viewmanagers/AndroidPopupMenuManagerInterface {
|
||||
public static final field Companion Lcom/facebook/react/views/popupmenu/ReactPopupMenuManager$Companion;
|
||||
public static final field REACT_CLASS Ljava/lang/String;
|
||||
public fun <init> ()V
|
||||
public synthetic fun createViewInstance (Lcom/facebook/react/uimanager/ThemedReactContext;)Landroid/view/View;
|
||||
public fun getName ()Ljava/lang/String;
|
||||
public synthetic fun receiveCommand (Landroid/view/View;Ljava/lang/String;Lcom/facebook/react/bridge/ReadableArray;)V
|
||||
public fun receiveCommand (Lcom/facebook/react/views/popupmenu/ReactPopupMenuContainer;Ljava/lang/String;Lcom/facebook/react/bridge/ReadableArray;)V
|
||||
public synthetic fun setMenuItems (Landroid/view/View;Lcom/facebook/react/bridge/ReadableArray;)V
|
||||
public fun setMenuItems (Lcom/facebook/react/views/popupmenu/ReactPopupMenuContainer;Lcom/facebook/react/bridge/ReadableArray;)V
|
||||
public synthetic fun show (Landroid/view/View;)V
|
||||
public fun show (Lcom/facebook/react/views/popupmenu/ReactPopupMenuContainer;)V
|
||||
}
|
||||
|
||||
public class com/facebook/react/views/popupmenu/ReactPopupMenuManager$$PropsSetter : com/facebook/react/uimanager/ViewManagerPropertyUpdater$ViewManagerSetter {
|
||||
public fun <init> ()V
|
||||
public fun getProperties (Ljava/util/Map;)V
|
||||
public synthetic fun setProperty (Lcom/facebook/react/uimanager/ViewManager;Landroid/view/View;Ljava/lang/String;Ljava/lang/Object;)V
|
||||
public fun setProperty (Lcom/facebook/react/views/popupmenu/ReactPopupMenuManager;Lcom/facebook/react/views/popupmenu/ReactPopupMenuContainer;Ljava/lang/String;Ljava/lang/Object;)V
|
||||
}
|
||||
|
||||
public final class com/facebook/react/views/popupmenu/ReactPopupMenuManager$Companion {
|
||||
}
|
||||
|
||||
public class com/facebook/react/views/progressbar/ProgressBarShadowNode : com/facebook/react/uimanager/LayoutShadowNode, com/facebook/yoga/YogaMeasureFunction {
|
||||
public fun <init> ()V
|
||||
public fun getStyle ()Ljava/lang/String;
|
||||
|
||||
-3
@@ -47,7 +47,6 @@ import com.facebook.react.uimanager.ViewManager;
|
||||
import com.facebook.react.views.drawer.ReactDrawerLayoutManager;
|
||||
import com.facebook.react.views.image.ReactImageManager;
|
||||
import com.facebook.react.views.modal.ReactModalHostManager;
|
||||
import com.facebook.react.views.popupmenu.ReactPopupMenuManager;
|
||||
import com.facebook.react.views.progressbar.ReactProgressBarViewManager;
|
||||
import com.facebook.react.views.scroll.ReactHorizontalScrollContainerViewManager;
|
||||
import com.facebook.react.views.scroll.ReactHorizontalScrollViewManager;
|
||||
@@ -171,7 +170,6 @@ public class MainReactPackage extends TurboReactPackage implements ViewManagerOn
|
||||
viewManagers.add(new ReactScrollViewManager());
|
||||
viewManagers.add(new ReactSwitchManager());
|
||||
viewManagers.add(new SwipeRefreshLayoutManager());
|
||||
viewManagers.add(new ReactPopupMenuManager());
|
||||
|
||||
// Native equivalents
|
||||
viewManagers.add(new FrescoBasedReactTextInlineImageViewManager());
|
||||
@@ -213,7 +211,6 @@ public class MainReactPackage extends TurboReactPackage implements ViewManagerOn
|
||||
appendMap(viewManagers, ReactSwitchManager.REACT_CLASS, ReactSwitchManager::new);
|
||||
appendMap(
|
||||
viewManagers, SwipeRefreshLayoutManager.REACT_CLASS, SwipeRefreshLayoutManager::new);
|
||||
appendMap(viewManagers, ReactPopupMenuManager.REACT_CLASS, ReactPopupMenuManager::new);
|
||||
appendMap(
|
||||
viewManagers,
|
||||
FrescoBasedReactTextInlineImageViewManager.REACT_CLASS,
|
||||
|
||||
-2
@@ -67,8 +67,6 @@ CoreComponentsRegistry::sharedProviderRegistry() {
|
||||
AndroidDrawerLayoutComponentDescriptor>());
|
||||
providerRegistry->add(concreteComponentDescriptorProvider<
|
||||
DebuggingOverlayComponentDescriptor>());
|
||||
providerRegistry->add(concreteComponentDescriptorProvider<
|
||||
AndroidPopupMenuComponentDescriptor>());
|
||||
|
||||
return providerRegistry;
|
||||
}();
|
||||
|
||||
Vendored
-5
@@ -27,7 +27,6 @@ import typeof Clipboard from './Libraries/Components/Clipboard/Clipboard';
|
||||
import typeof DrawerLayoutAndroid from './Libraries/Components/DrawerAndroid/DrawerLayoutAndroid';
|
||||
import typeof Keyboard from './Libraries/Components/Keyboard/Keyboard';
|
||||
import typeof KeyboardAvoidingView from './Libraries/Components/Keyboard/KeyboardAvoidingView';
|
||||
import typeof PopupMenuAndroid from './Libraries/Components/PopupMenuAndroid/PopupMenuAndroid';
|
||||
import typeof Pressable from './Libraries/Components/Pressable/Pressable';
|
||||
import typeof ProgressBarAndroid from './Libraries/Components/ProgressBarAndroid/ProgressBarAndroid';
|
||||
import typeof RefreshControl from './Libraries/Components/RefreshControl/RefreshControl';
|
||||
@@ -135,10 +134,6 @@ module.exports = {
|
||||
return require('./Libraries/Components/Keyboard/KeyboardAvoidingView')
|
||||
.default;
|
||||
},
|
||||
get PopupMenuAndroid(): PopupMenuAndroid {
|
||||
return require('./Libraries/Components/PopupMenuAndroid/PopupMenuAndroid')
|
||||
.default;
|
||||
},
|
||||
get Modal(): Modal {
|
||||
return require('./Libraries/Modal/Modal');
|
||||
},
|
||||
|
||||
@@ -151,6 +151,7 @@ android {
|
||||
dependencies {
|
||||
// Build React Native from source
|
||||
implementation(project(":packages:react-native:ReactAndroid"))
|
||||
implementation(project(":packages:react-native-popup-menu-android:android"))
|
||||
|
||||
// Consume Hermes as built from source only for the Hermes variant.
|
||||
"hermesImplementation"(project(":packages:react-native:ReactAndroid:hermes-engine"))
|
||||
|
||||
+2
@@ -25,6 +25,7 @@ import com.facebook.react.defaults.DefaultReactHost
|
||||
import com.facebook.react.defaults.DefaultReactNativeHost
|
||||
import com.facebook.react.module.model.ReactModuleInfo
|
||||
import com.facebook.react.module.model.ReactModuleInfoProvider
|
||||
import com.facebook.react.popupmenu.PopupMenuPackage
|
||||
import com.facebook.react.shell.MainReactPackage
|
||||
import com.facebook.react.uiapp.component.MyLegacyViewManager
|
||||
import com.facebook.react.uiapp.component.MyNativeViewManager
|
||||
@@ -44,6 +45,7 @@ class RNTesterApplication : Application(), ReactApplication {
|
||||
public override fun getPackages(): List<ReactPackage> {
|
||||
return listOf(
|
||||
MainReactPackage(),
|
||||
PopupMenuPackage(),
|
||||
object : TurboReactPackage() {
|
||||
override fun getModule(
|
||||
name: String,
|
||||
|
||||
@@ -10,11 +10,12 @@
|
||||
|
||||
'use strict';
|
||||
|
||||
import type {PopupMenuAndroidInstance} from '@react-native/popup-menu-android';
|
||||
import type {Node} from 'react';
|
||||
import type {PopupMenuAndroidInstance} from 'react-native/Libraries/Components/PopupMenuAndroid/PopupMenuAndroid';
|
||||
|
||||
import PopupMenuAndroid from '@react-native/popup-menu-android';
|
||||
import * as React from 'react';
|
||||
import {Button, PopupMenuAndroid, StyleSheet, Text, View} from 'react-native';
|
||||
import {Button, StyleSheet, Text, View} from 'react-native';
|
||||
|
||||
type Fruit = 'Apple' | 'Pear' | 'Banana' | 'Orange' | 'Kiwi';
|
||||
|
||||
|
||||
@@ -30,6 +30,7 @@ const config = {
|
||||
path.resolve(__dirname, '../polyfills'),
|
||||
path.resolve(__dirname, '../react-native'),
|
||||
path.resolve(__dirname, '../virtualized-lists'),
|
||||
path.resolve(__dirname, '../react-native-popup-menu-android'),
|
||||
],
|
||||
resolver: {
|
||||
blockList: [/..\/react-native\/sdks\/hermes/],
|
||||
|
||||
@@ -25,7 +25,8 @@
|
||||
"dependencies": {
|
||||
"flow-enums-runtime": "^0.0.6",
|
||||
"invariant": "^2.2.4",
|
||||
"nullthrows": "^1.1.1"
|
||||
"nullthrows": "^1.1.1",
|
||||
"@react-native/popup-menu-android": "^0.74.0"
|
||||
},
|
||||
"peerDependencies": {
|
||||
"react": "18.2.0",
|
||||
|
||||
@@ -17,6 +17,7 @@ include(
|
||||
":packages:react-native:ReactAndroid",
|
||||
":packages:react-native:ReactAndroid:hermes-engine",
|
||||
":packages:react-native:ReactAndroid:external-artifacts",
|
||||
":packages:react-native-popup-menu-android:android",
|
||||
":packages:rn-tester:android:app")
|
||||
|
||||
includeBuild("packages/react-native-gradle-plugin/")
|
||||
|
||||
Reference in new issue
Block a user