mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Gradle: Deprecate reactRoot in favor of root and reactNativeDir (#33142)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/33142 The `reactRoot` property was confusing as we were using it for both the root of the project and the react-native NPM Package root. I'm deprecating it and splitting it in two. I've added several warning in the codebase to tell the people how to migrate away from it. Moreover this is specifying default values that are more user-friendly. Users won't have to configure anything unless they are in a monorepo. Changelog: [Android] [Changed] - Gradle: Deprecate `reactRoot` in favor of `root` and `reactNativeDir` Reviewed By: ShikaSD Differential Revision: D34277050 fbshipit-source-id: fc7f45017452b086726516a9586cacd9a661c287
This commit is contained in:
1 parent
16feabf676
commit
8bc324fd34
9 files changed
+104
-46
No files matched your search
@@ -407,7 +407,7 @@ react {
|
||||
// This should be changed to a more generic name, e.g. `ReactCoreSpec`.
|
||||
libraryName = "rncore"
|
||||
jsRootDir = file("../Libraries")
|
||||
reactRoot = file("$projectDir/..")
|
||||
reactNativeDir = file("$projectDir/..")
|
||||
useJavaGenerator = System.getenv("USE_CODEGEN_JAVAPOET")?.toBoolean() ?: false
|
||||
// We search for the codegen in either one of the `node_modules` folder or in the
|
||||
// root packages folder (that's for when we build from source without calling `yarn install`).
|
||||
|
||||
Reference in new issue
Block a user