From 8b1ae7a4ae22ec5cd2abd68901e2a6f05b1dd6ef Mon Sep 17 00:00:00 2001 From: Ramanpreet Nara Date: Thu, 15 Oct 2020 22:50:19 -0700 Subject: [PATCH] Annotate Component parser's output with 'Component' type Summary: NOTE: Flow and Jest won't pass on this diff. Sandcastle, should, however, be green on D24236405 (i.e: the tip of this stack). ## Changes 1. Update the RN Codegen Component Parser 2. Update all RN Codegen Component Parser snapshots. Changelog: [Internal] (Note: this ignores all push blocking failures!) Reviewed By: PeteTheHeat Differential Revision: D24236503 fbshipit-source-id: 975d97dd29bb5ca08e5de96e7814290c3dc4357b --- .../__snapshots__/component-parser-test.js.snap | 14 ++++++++++++++ .../src/parsers/flow/components/schema.js | 1 + 2 files changed, 15 insertions(+) diff --git a/packages/react-native-codegen/src/parsers/flow/components/__tests__/__snapshots__/component-parser-test.js.snap b/packages/react-native-codegen/src/parsers/flow/components/__tests__/__snapshots__/component-parser-test.js.snap index b8db619b9bb..b66ee965af5 100644 --- a/packages/react-native-codegen/src/parsers/flow/components/__tests__/__snapshots__/component-parser-test.js.snap +++ b/packages/react-native-codegen/src/parsers/flow/components/__tests__/__snapshots__/component-parser-test.js.snap @@ -38,6 +38,7 @@ exports[`RN Codegen Flow Parser can generate fixture ALL_PROP_TYPES_NO_EVENTS 1` "{ 'modules': { 'Module': { + 'type': 'Component', 'components': { 'Module': { 'extendsProps': [ @@ -564,6 +565,7 @@ exports[`RN Codegen Flow Parser can generate fixture ARRAY_PROP_TYPES_NO_EVENTS "{ 'modules': { 'Module': { + 'type': 'Component', 'components': { 'Module': { 'extendsProps': [ @@ -1278,6 +1280,7 @@ exports[`RN Codegen Flow Parser can generate fixture COMMANDS_AND_EVENTS_TYPES_E "{ 'modules': { 'Module': { + 'type': 'Component', 'components': { 'Module': { 'extendsProps': [ @@ -2525,6 +2528,7 @@ exports[`RN Codegen Flow Parser can generate fixture COMMANDS_DEFINED_WITH_ALL_T "{ 'modules': { 'Module': { + 'type': 'Component', 'components': { 'Module': { 'extendsProps': [ @@ -2618,6 +2622,7 @@ exports[`RN Codegen Flow Parser can generate fixture COMMANDS_WITH_EXTERNAL_TYPE "{ 'modules': { 'Module': { + 'type': 'Component', 'components': { 'Module': { 'extendsProps': [ @@ -2662,6 +2667,7 @@ exports[`RN Codegen Flow Parser can generate fixture EVENTS_DEFINED_AS_NULL_INLI "{ 'modules': { 'Module': { + 'type': 'Component', 'components': { 'Module': { 'extendsProps': [ @@ -2807,6 +2813,7 @@ exports[`RN Codegen Flow Parser can generate fixture EVENTS_DEFINED_INLINE_WITH_ "{ 'modules': { 'Module': { + 'type': 'Component', 'components': { 'Module': { 'extendsProps': [ @@ -5832,6 +5839,7 @@ exports[`RN Codegen Flow Parser can generate fixture NO_PROPS_EVENTS_ONLY_DEPREC "{ 'modules': { 'Module': { + 'type': 'Component', 'components': { 'Module': { 'deprecatedViewConfigName': 'DeprecateModuleName', @@ -5855,6 +5863,7 @@ exports[`RN Codegen Flow Parser can generate fixture OBJECT_PROP_TYPES_NO_EVENTS "{ 'modules': { 'Module': { + 'type': 'Component', 'components': { 'Module': { 'extendsProps': [ @@ -6520,6 +6529,7 @@ exports[`RN Codegen Flow Parser can generate fixture ONE_OF_EACH_PROP_EVENT_DEFA "{ 'modules': { 'Module': { + 'type': 'Component', 'components': { 'Module': { 'interfaceOnly': true, @@ -6578,6 +6588,7 @@ exports[`RN Codegen Flow Parser can generate fixture ONE_OF_EACH_PROP_EVENT_DEFA "{ 'modules': { 'Module': { + 'type': 'Component', 'components': { 'Module': { 'interfaceOnly': true, @@ -6639,6 +6650,7 @@ exports[`RN Codegen Flow Parser can generate fixture PROPS_ALIASED_LOCALLY 1`] = "{ 'modules': { 'Module': { + 'type': 'Component', 'components': { 'Module': { 'extendsProps': [ @@ -6755,6 +6767,7 @@ exports[`RN Codegen Flow Parser can generate fixture PROPS_AND_EVENTS_TYPES_EXPO "{ 'modules': { 'Module': { + 'type': 'Component', 'components': { 'Module': { 'extendsProps': [ @@ -7980,6 +7993,7 @@ exports[`RN Codegen Flow Parser can generate fixture PROPS_AS_EXTERNAL_TYPES 1`] "{ 'modules': { 'Module': { + 'type': 'Component', 'components': { 'Module': { 'extendsProps': [], diff --git a/packages/react-native-codegen/src/parsers/flow/components/schema.js b/packages/react-native-codegen/src/parsers/flow/components/schema.js index c561f9e0b18..9ca89ebc12e 100644 --- a/packages/react-native-codegen/src/parsers/flow/components/schema.js +++ b/packages/react-native-codegen/src/parsers/flow/components/schema.js @@ -41,6 +41,7 @@ function wrapComponentSchema({ return { modules: { [filename]: { + type: 'Component', components: { [componentName]: { ...(options || {}),