From 8ad4b7d0cf236f148cf9c357a29f969dc047c2ab Mon Sep 17 00:00:00 2001 From: Jorge Cabiedes Acosta Date: Mon, 23 Sep 2024 11:57:39 -0700 Subject: [PATCH] Fix outline drawing 1px width when outlineWidth = 0 (#46586) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46586 When Paint.strokeWidth is set to 0 its not actually 0 but "hairline mode" so the fix is just to make outline not draw at all when outlineWidth = 0 {F1879399325} Changelog: [Internal] Reviewed By: joevilches Differential Revision: D63136220 fbshipit-source-id: 81ef7ce0b72158c6b7c332191d332008c5a919b4 --- .../com/facebook/react/uimanager/drawable/OutlineDrawable.kt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/drawable/OutlineDrawable.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/drawable/OutlineDrawable.kt index e23562bc539..cb7e2f10494 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/drawable/OutlineDrawable.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/drawable/OutlineDrawable.kt @@ -109,6 +109,10 @@ internal class OutlineDrawable( ((outlinePaint.alpha / 255f) / (Color.alpha(outlineColor) / 255f) * 255f).roundToInt() override fun draw(canvas: Canvas) { + if (outlineWidth == 0f) { + return + } + pathForOutline.reset() computedBorderRadius =