From 8accd77c45a4b051bf02904c3485d6a0dcd27631 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Fri, 15 Nov 2019 17:24:41 -0800 Subject: [PATCH] Deprecate CallerContext from ReactImageManager Summary: This diff deprecates the constructors and getter method exposing CallerContext in ReactImageManager. This will be replaced by the ReactCallerContextFactory class Changelog: Deprecation of constructors and methods that expose CallerContext in ReactImageManager class Reviewed By: JoshuaGross Differential Revision: D18474012 fbshipit-source-id: d8190f938e00da0499bfef7e81522dc8022a8836 --- .../react/views/image/ReactImageManager.java | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageManager.java index 82c3ae16c90..fdc7ec2c0e1 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageManager.java @@ -41,12 +41,22 @@ public class ReactImageManager extends SimpleViewManager { private final @Nullable Object mCallerContext; private final @Nullable ReactCallerContextFactory mCallerContextFactory; + /** + * @deprecated use {@link ReactImageManager#ReactImageManager(AbstractDraweeControllerBuilder, + * ReactCallerContextFactory)} instead. + */ + @Deprecated public ReactImageManager( @Nullable AbstractDraweeControllerBuilder draweeControllerBuilder, @Nullable Object callerContext) { this(draweeControllerBuilder, null, callerContext); } + /** + * @deprecated use {@link ReactImageManager#ReactImageManager(AbstractDraweeControllerBuilder, + * GlobalImageLoadListener, ReactCallerContextFactory)} instead. + */ + @Deprecated public ReactImageManager( @Nullable AbstractDraweeControllerBuilder draweeControllerBuilder, @Nullable GlobalImageLoadListener globalImageLoadListener, @@ -87,6 +97,8 @@ public class ReactImageManager extends SimpleViewManager { return mDraweeControllerBuilder; } + /** @deprecated use {@link ReactCallerContextFactory} instead */ + @Deprecated public Object getCallerContext() { return mCallerContext; }