From 8a8c15f9fa96ee98f366c341f3223c4bc370e237 Mon Sep 17 00:00:00 2001 From: Ramanpreet Nara Date: Wed, 9 Sep 2020 16:00:52 -0700 Subject: [PATCH] Remove log when TurboModule cannot be created Summary: This log was necessary to get to the bottom of the TurboModule Fb4a eager init crash. It's no longer necessary, plus it's okay for TurboModules to be null, so we'll remove it for now. Changelog: [Internal] Differential Revision: D23607208 fbshipit-source-id: 083b00abe6bdefc5986f842cd6f9438f47cce1ce --- .../facebook/react/turbomodule/core/TurboModuleManager.java | 6 ------ 1 file changed, 6 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManager.java b/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManager.java index 35f393a82e4..e6e6fcce69e 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManager.java @@ -10,7 +10,6 @@ package com.facebook.react.turbomodule.core; import androidx.annotation.GuardedBy; import androidx.annotation.NonNull; import androidx.annotation.Nullable; -import com.facebook.common.logging.FLog; import com.facebook.infer.annotation.Assertions; import com.facebook.jni.HybridData; import com.facebook.proguard.annotations.DoNotStrip; @@ -18,7 +17,6 @@ import com.facebook.react.bridge.CxxModuleWrapper; import com.facebook.react.bridge.JSIModule; import com.facebook.react.bridge.JavaScriptContextHolder; import com.facebook.react.bridge.NativeModule; -import com.facebook.react.common.ReactConstants; import com.facebook.react.turbomodule.core.interfaces.CallInvokerHolder; import com.facebook.react.turbomodule.core.interfaces.TurboModule; import com.facebook.react.turbomodule.core.interfaces.TurboModuleRegistry; @@ -218,10 +216,6 @@ public class TurboModuleManager implements JSIModule, TurboModuleRegistry { * Therefore, we should initialize on the TurboModule now. */ ((NativeModule) turboModule).initialize(); - } else { - FLog.e( - ReactConstants.TAG, - "TurboModuleManager.getModule: TurboModule " + moduleName + " not found in delegate"); } TurboModulePerfLogger.moduleCreateSetUpEnd(moduleName, moduleHolder.getModuleId());