From 8a6b88eeafef4eb63ee537c4ce71f9928f81a766 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Thu, 20 Jun 2024 11:06:46 -0700 Subject: [PATCH] Back out "Add Float and Int type support for Android modules" (#45087) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45087 Original commit changeset: 32b3bbdf5fd2 Fixes https://github.com/facebook/react-native/issues/44963 Closes https://github.com/facebook/react-native/pull/45024 Original Phabricator Diff: D52420921 Changelog: [Internal] [Changed] - Back out "[RN][Codegen]Add Float and Int type support for Android modules" Reviewed By: dmytrorykun Differential Revision: D58820544 fbshipit-source-id: 59cd0e7cc17a681785c57b5ce1a9d50d28a348af --- .../src/generators/modules/GenerateModuleJavaSpec.js | 4 ++-- .../src/generators/modules/GenerateModuleJniCpp.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/react-native-codegen/src/generators/modules/GenerateModuleJavaSpec.js b/packages/react-native-codegen/src/generators/modules/GenerateModuleJavaSpec.js index efbf63c9733..ee3237d5d8c 100644 --- a/packages/react-native-codegen/src/generators/modules/GenerateModuleJavaSpec.js +++ b/packages/react-native-codegen/src/generators/modules/GenerateModuleJavaSpec.js @@ -136,11 +136,11 @@ function translateFunctionParamToJavaType( case 'NumberTypeAnnotation': return wrapOptional('double', isRequired); case 'FloatTypeAnnotation': - return wrapOptional('float', isRequired); + return wrapOptional('double', isRequired); case 'DoubleTypeAnnotation': return wrapOptional('double', isRequired); case 'Int32TypeAnnotation': - return wrapOptional('int', isRequired); + return wrapOptional('double', isRequired); case 'BooleanTypeAnnotation': return wrapOptional('boolean', isRequired); case 'EnumDeclaration': diff --git a/packages/react-native-codegen/src/generators/modules/GenerateModuleJniCpp.js b/packages/react-native-codegen/src/generators/modules/GenerateModuleJniCpp.js index eb2cf1ca133..2930ab1be9a 100644 --- a/packages/react-native-codegen/src/generators/modules/GenerateModuleJniCpp.js +++ b/packages/react-native-codegen/src/generators/modules/GenerateModuleJniCpp.js @@ -334,9 +334,9 @@ function translateReturnTypeToJniType( case 'DoubleTypeAnnotation': return nullable ? 'Ljava/lang/Double;' : 'D'; case 'FloatTypeAnnotation': - return nullable ? 'Ljava/lang/Float;' : 'F'; + return nullable ? 'Ljava/lang/Double;' : 'D'; case 'Int32TypeAnnotation': - return nullable ? 'Ljava/lang/Integer;' : 'I'; + return nullable ? 'Ljava/lang/Double;' : 'D'; case 'PromiseTypeAnnotation': return 'Lcom/facebook/react/bridge/Promise;'; case 'GenericObjectTypeAnnotation':