From 8a390ba9b8c1b8889dd0933fe1477083a24ff71d Mon Sep 17 00:00:00 2001 From: Ingrid Wang Date: Thu, 8 Aug 2024 16:27:49 -0700 Subject: [PATCH] Mark setNetworkActivityIndicatorVisible as deprecated (#45950) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45950 Changelog: [iOS][Deprecated] Deprecated StatusBar.setNetworkActivityIndicatorVisible The status bar network activity indicator is deprecated in iOS 13. Setting its visibility has no effect in iOS 13 and later. It will be completely removed in a future release. Reviewed By: philIip Differential Revision: D60977517 fbshipit-source-id: 31e79113fffd0201c4393b61236d3911e82b40d1 --- .../Components/StatusBar/StatusBar.js | 4 +- .../React/CoreModules/RCTStatusBarManager.mm | 4 ++ .../js/examples/StatusBar/StatusBarExample.js | 63 ------------------- 3 files changed, 7 insertions(+), 64 deletions(-) diff --git a/packages/react-native/Libraries/Components/StatusBar/StatusBar.js b/packages/react-native/Libraries/Components/StatusBar/StatusBar.js index 20c2cf49d9f..f3be5e02ad9 100644 --- a/packages/react-native/Libraries/Components/StatusBar/StatusBar.js +++ b/packages/react-native/Libraries/Components/StatusBar/StatusBar.js @@ -272,8 +272,10 @@ class StatusBar extends React.Component { } /** - * Control the visibility of the network activity indicator + * DEPRECATED - The status bar network activity indicator is not supported in iOS 13 and later. This will be removed in a future release. * @param visible Show the indicator. + * + * @deprecated */ static setNetworkActivityIndicatorVisible(visible: boolean) { if (Platform.OS !== 'ios') { diff --git a/packages/react-native/React/CoreModules/RCTStatusBarManager.mm b/packages/react-native/React/CoreModules/RCTStatusBarManager.mm index 015a91098e9..f7dab676af2 100644 --- a/packages/react-native/React/CoreModules/RCTStatusBarManager.mm +++ b/packages/react-native/React/CoreModules/RCTStatusBarManager.mm @@ -161,7 +161,11 @@ RCT_EXPORT_METHOD(setHidden : (BOOL)hidden withAnimation : (NSString *)withAnima RCT_EXPORT_METHOD(setNetworkActivityIndicatorVisible : (BOOL)visible) { dispatch_async(dispatch_get_main_queue(), ^{ +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wdeprecated-declarations" + // This is no longer supported in iOS 13 and later. We will remove this method in a future release. RCTSharedApplication().networkActivityIndicatorVisible = visible; +#pragma clang diagnostic pop }); } diff --git a/packages/rn-tester/js/examples/StatusBar/StatusBarExample.js b/packages/rn-tester/js/examples/StatusBar/StatusBarExample.js index 7b0f94e2f4a..18667a51e4d 100644 --- a/packages/rn-tester/js/examples/StatusBar/StatusBarExample.js +++ b/packages/rn-tester/js/examples/StatusBar/StatusBarExample.js @@ -149,44 +149,6 @@ class StatusBarStyleExample extends React.Component<{...}, $FlowFixMeState> { } } -class StatusBarNetworkActivityExample extends React.Component< - {...}, - $FlowFixMeState, -> { - state: $FlowFixMe | {networkActivityIndicatorVisible: boolean} = { - networkActivityIndicatorVisible: false, - }; - - _onChangeNetworkIndicatorVisible = () => { - this.setState({ - networkActivityIndicatorVisible: - !this.state.networkActivityIndicatorVisible, - }); - }; - - render(): React.Node { - return ( - - - - - - networkActivityIndicatorVisible: - {this.state.networkActivityIndicatorVisible ? 'true' : 'false'} - - - - - ); - } -} - class StatusBarBackgroundColorExample extends React.Component< {...}, $FlowFixMeState, @@ -308,24 +270,6 @@ class StatusBarStaticIOSExample extends React.Component<{...}> { setBarStyle('light-content', true) - { - StatusBar.setNetworkActivityIndicatorVisible(true); - }}> - - setNetworkActivityIndicatorVisible(true) - - - { - StatusBar.setNetworkActivityIndicatorVisible(false); - }}> - - setNetworkActivityIndicatorVisible(false) - - ); } @@ -490,13 +434,6 @@ exports.examples = [ return ; }, }, - { - title: 'StatusBar network activity indicator', - render(): React.Node { - return ; - }, - platform: 'ios', - }, { title: 'StatusBar background color', render(): React.Node {