From 89d331209a069267abdff437c304e6bf8a26d8dc Mon Sep 17 00:00:00 2001
From: Nicola Corti <ncor@meta.com>
Date: Mon, 19 Feb 2024 07:59:22 -0800
Subject: [PATCH] Remove test_windows from CircleCI (#43090)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/43090

I'm removing test_windows from CircleCI as the job is often flaky for various reasons.
The cost of maintainaining it is so high at the moment, and it brings little to no value to our developers.
We'll re-evaluate what to do with it once we move to GHA.

Changelog:
[Internal] [Changed] - Remove test_windows from CircleCI

Reviewed By: cipolleschi

Differential Revision: D53918601

fbshipit-source-id: b76c92f1eb3d2302595773dff9f8bbc292c0bfcf
---
 .circleci/configurations/jobs.yml             | 65 -------------------
 .../configurations/test_workflows/testJS.yml  |  1 -
 .circleci/configurations/top_level.yml        |  5 --
 3 files changed, 71 deletions(-)

diff --git a/.circleci/configurations/jobs.yml b/.circleci/configurations/jobs.yml
index cdbb25cf506..39eb852857d 100644
--- a/.circleci/configurations/jobs.yml
+++ b/.circleci/configurations/jobs.yml
@@ -590,71 +590,6 @@ jobs:
                       steps:
                           - run_ios_tests
 
-  # -------------------------
-  #    JOBS: Windows
-  # -------------------------
-  test_windows:
-    executor:
-      name: win/default
-    environment:
-      - CHOCO_CACHE_DIR: "C:\\ChocoCache"
-    steps:
-      - checkout_code_with_cache
-
-      - restore_cache:
-          keys:
-            - *windows_choco_cache_key
-
-      - run:
-          name: Choco cache
-          # Cache our dependencies which can be flakey to download
-          command: |
-            if (!Test-Path $env:CHOCO_CACHE_DIR) {
-              mkdir $env:CHOCO_CACHE_DIR
-            }
-            choco config set --name cacheLocation --value $env:CHOCO_CACHE_DIR
-
-      - run:
-          name: Disable NVM
-          # Use choco to manage node versions due to https://github.com/npm/cli/issues/4234
-          command: nvm off
-
-      - run:
-          name: Install Node JS
-          # Note: Version set separately for non-Windows builds, see above.
-          command: choco install nodejs --version=18.18.0 --allow-downgrade -y
-
-      # Setup Dependencies
-      - run:
-          name: Enable Yarn with corepack
-          command: corepack enable
-
-      - restore_cache:
-          keys:
-            - *windows_yarn_cache_key
-      - run:
-          name: "Yarn: Install Dependencies"
-          command: yarn install --frozen-lockfile --non-interactive
-
-      - save_cache:
-          key: *windows_yarn_cache_key
-          paths:
-            - C:\Users\circleci\AppData\Local\Yarn
-
-      - save_cache:
-          key: *windows_choco_cache_key
-          paths:
-            - $env:CHOCO_CACHE_DIR
-
-      # -------------------------
-      # Run Tests
-      - run:
-          name: "Flow Check"
-          command: yarn flow-check
-      - run:
-          name: "Run Tests: JavaScript Tests"
-          command: yarn test
-
   # -------------------------
   #      JOBS: Build Hermes
   # -------------------------
diff --git a/.circleci/configurations/test_workflows/testJS.yml b/.circleci/configurations/test_workflows/testJS.yml
index 6d97de14d4d..6c5ea93e1c7 100644
--- a/.circleci/configurations/test_workflows/testJS.yml
+++ b/.circleci/configurations/test_workflows/testJS.yml
@@ -9,4 +9,3 @@
       - test_js:
           name: test_js_prev_lts
           executor: nodeprevlts
-      - test_windows
diff --git a/.circleci/configurations/top_level.yml b/.circleci/configurations/top_level.yml
index 0a83293cbd9..5d3281d3640 100644
--- a/.circleci/configurations/top_level.yml
+++ b/.circleci/configurations/top_level.yml
@@ -98,11 +98,6 @@ references:
     template_cocoapods_cache_key: &template_cocoapods_cache_key v6-cocoapods-{{ .Environment.CIRCLE_JOB }}-{{ checksum "/tmp/iOSTemplateProject/ios/Podfile.lock" }}-{{ checksum "/tmp/iOSTemplateProject/ios/Podfile" }}-{{ checksum "/tmp/hermes/hermesversion" }}-{{ checksum "packages/rn-tester/Podfile.lock" }}
     template_podfile_lock_cache_key: &template_podfile_lock_cache_key v6-podfilelock-{{ .Environment.CIRCLE_JOB }}-{{ checksum "/tmp/iOSTemplateProject/ios/Podfile" }}-{{ checksum "/tmp/week_year" }}-{{ checksum "/tmp/hermes/hermesversion" }}-{{ checksum "packages/rn-tester/Podfile.lock" }}
 
-    # Windows
-    windows_yarn_cache_key: &windows_yarn_cache_key v1-win-yarn-cache-{{ arch }}-{{ checksum "yarn.lock" }}
-    windows_choco_cache_key: &windows_choco_cache_key v1-win-choco-cache-{{ .Environment.CIRCLE_JOB }}
-
-
   cache_paths:
     hermes_workspace_macos_cache_paths: &hermes_workspace_macos_cache_paths
       - ~/react-native/packages/react-native/sdks/hermes/build_macosx