From 895763736491c932d0a9dbf4df49dafd0c69cd48 Mon Sep 17 00:00:00 2001 From: Joshua Gross Date: Fri, 14 Jun 2019 19:03:34 -0700 Subject: [PATCH] Add a few Fabric systrace sections Summary: Just adding a few systrace sections to add perf visibility in a few more areas. Reviewed By: ejanzer Differential Revision: D15823394 fbshipit-source-id: 6ac1773cbd8e01a747ad015726e16c0bf0e8596b --- .../src/main/java/com/facebook/react/fabric/jni/Binding.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp b/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp index 80295048094..319f9bd8ab8 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp +++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp @@ -50,6 +50,7 @@ void Binding::startSurface( jint surfaceId, jni::alias_ref moduleName, NativeMap *initialProps) { + SystraceSection s("FabricUIManagerBinding::startSurface"); if (scheduler_) { scheduler_->startSurface( surfaceId, moduleName->toStdString(), initialProps->consume()); @@ -57,6 +58,7 @@ void Binding::startSurface( } void Binding::renderTemplateToSurface(jint surfaceId, jstring uiTemplate) { + SystraceSection s("FabricUIManagerBinding::renderTemplateToSurface"); if (scheduler_) { auto env = Environment::current(); const char *nativeString = env->GetStringUTFChars(uiTemplate, JNI_FALSE); @@ -100,6 +102,7 @@ void Binding::installFabricUIManager( jni::alias_ref jsMessageQueueThread, ComponentFactoryDelegate *componentsRegistry, jni::alias_ref reactNativeConfig) { + SystraceSection s("FabricUIManagerBinding::installFabricUIManager"); javaUIManager_ = make_global(javaUIManager); ContextContainer::Shared contextContainer = @@ -360,7 +363,7 @@ local_ref createCreateMountItem( void Binding::schedulerDidFinishTransaction( MountingCoordinator::Shared const &mountingCoordinator) { - SystraceSection s("FabricUIManager::schedulerDidFinishTransaction"); + SystraceSection s("FabricUIManagerBinding::schedulerDidFinishTransaction"); auto mountingTransaction = mountingCoordinator->pullTransaction();