From 88293d391aaad981b8952a3a031d18edf447202b Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Sat, 4 Aug 2018 09:30:11 -0700 Subject: [PATCH] Fabric: Using `const &` pattern everywhere in RCTConversions Summary: @public Trivial. Reviewed By: mdvacca Differential Revision: D8923599 fbshipit-source-id: 06f760ad7940af247ca81396fd48b08fbcd562c6 --- React/Fabric/RCTConversions.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/React/Fabric/RCTConversions.h b/React/Fabric/RCTConversions.h index e38cd04febf..ff521a10f53 100644 --- a/React/Fabric/RCTConversions.h +++ b/React/Fabric/RCTConversions.h @@ -27,24 +27,24 @@ inline CGColorRef RCTCGColorRefFromSharedColor(const facebook::react::SharedColo return sharedColor ? CGColorCreateCopy(sharedColor.get()) : nil; } -inline CGPoint RCTCGPointFromPoint(facebook::react::Point point) { +inline CGPoint RCTCGPointFromPoint(const facebook::react::Point &point) { return {point.x, point.y}; } -inline CGSize RCTCGSizeFromSize(facebook::react::Size size) { +inline CGSize RCTCGSizeFromSize(const facebook::react::Size &size) { return {size.width, size.height}; } -inline CGRect RCTCGRectFromRect(facebook::react::Rect rect) { +inline CGRect RCTCGRectFromRect(const facebook::react::Rect &rect) { return {RCTCGPointFromPoint(rect.origin), RCTCGSizeFromSize(rect.size)}; } -inline UIEdgeInsets RCTUIEdgeInsetsFromEdgeInsets(facebook::react::EdgeInsets edgeInsets) { +inline UIEdgeInsets RCTUIEdgeInsetsFromEdgeInsets(const facebook::react::EdgeInsets &edgeInsets) { return {edgeInsets.top, edgeInsets.left, edgeInsets.bottom, edgeInsets.right}; } -inline CATransform3D RCTCATransform3DFromTransformMatrix(facebook::react::Transform transformMatrix) { +inline CATransform3D RCTCATransform3DFromTransformMatrix(const facebook::react::Transform &transformMatrix) { return { (CGFloat)transformMatrix.matrix[0], (CGFloat)transformMatrix.matrix[1], @@ -65,18 +65,18 @@ inline CATransform3D RCTCATransform3DFromTransformMatrix(facebook::react::Transf }; } -inline facebook::react::Point RCTPointFromCGPoint(CGPoint point) { +inline facebook::react::Point RCTPointFromCGPoint(const CGPoint &point) { return {point.x, point.y}; } -inline facebook::react::Size RCTSizeFromCGSize(CGSize size) { +inline facebook::react::Size RCTSizeFromCGSize(const CGSize &size) { return {size.width, size.height}; } -inline facebook::react::Rect RCTRectFromCGRect(CGRect rect) { +inline facebook::react::Rect RCTRectFromCGRect(const CGRect &rect) { return {RCTPointFromCGPoint(rect.origin), RCTSizeFromCGSize(rect.size)}; } -inline facebook::react::EdgeInsets RCTEdgeInsetsFromUIEdgeInsets(UIEdgeInsets edgeInsets) { +inline facebook::react::EdgeInsets RCTEdgeInsetsFromUIEdgeInsets(const UIEdgeInsets &edgeInsets) { return {edgeInsets.top, edgeInsets.left, edgeInsets.bottom, edgeInsets.right}; }