From 84f40da990dfd21eb1c21e20f2be0f8b2c5a78e4 Mon Sep 17 00:00:00 2001 From: Dulmandakh Date: Wed, 13 Feb 2019 05:26:26 -0800 Subject: [PATCH] @Nonnull annotation for ReactPackage (#23415) Summary: Here are some leftovers from nullable annotations for native modules, discovered while developing native module in Kotlin. This will help improve Kotlin developer experience [Android] [Changed] - Add Nonnull annotations to ReactPackage Pull Request resolved: https://github.com/facebook/react-native/pull/23415 Differential Revision: D14064607 Pulled By: cpojer fbshipit-source-id: af2ce1fc1911ee03c54b20a4fc3a6d1aba9267da --- .../src/main/java/com/facebook/react/ReactPackage.java | 2 ++ .../facebook/react/modules/core/DeviceEventManagerModule.java | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactPackage.java b/ReactAndroid/src/main/java/com/facebook/react/ReactPackage.java index 527db0ace2e..7bf8569d7bc 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/ReactPackage.java +++ b/ReactAndroid/src/main/java/com/facebook/react/ReactPackage.java @@ -34,10 +34,12 @@ public interface ReactPackage { * @param reactContext react application context that can be used to create modules * @return list of native modules to register with the newly created catalyst instance */ + @Nonnull List createNativeModules(@Nonnull ReactApplicationContext reactContext); /** * @return a list of view managers that should be registered with {@link UIManagerModule} */ + @Nonnull List createViewManagers(@Nonnull ReactApplicationContext reactContext); } diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/core/DeviceEventManagerModule.java b/ReactAndroid/src/main/java/com/facebook/react/modules/core/DeviceEventManagerModule.java index 56109af8af0..c78527208cc 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/core/DeviceEventManagerModule.java +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/core/DeviceEventManagerModule.java @@ -7,6 +7,7 @@ package com.facebook.react.modules.core; +import javax.annotation.Nonnull; import javax.annotation.Nullable; import android.net.Uri; @@ -27,7 +28,7 @@ import com.facebook.react.module.annotations.ReactModule; public class DeviceEventManagerModule extends ReactContextBaseJavaModule { public static final String NAME = "DeviceEventManager"; public interface RCTDeviceEventEmitter extends JavaScriptModule { - void emit(String eventName, @Nullable Object data); + void emit(@Nonnull String eventName, @Nullable Object data); } private final Runnable mInvokeDefaultBackPressRunnable;