From 848e34e753ca4ea7cc3e3262d3354a557467efca Mon Sep 17 00:00:00 2001 From: Ramanpreet Nara Date: Tue, 11 Jan 2022 00:23:24 -0800 Subject: [PATCH] Fix SVC/NVC for AndroidDrawerLayout Summary: ## Failures ``` LOG SVC AndroidDrawerLayout Invalid LOG { "missing": {}, "unexpected": { "directEventTypes": { "topDrawerOpened": { "registrationName": "onDrawerOpen" }, "topDrawerClosed": { "registrationName": "onDrawerClose" } }, "validAttributes": { "keyboardDismissMode": true, "drawerBackgroundColor": { "process": "[Function processColor]" }, "statusBarBackgroundColor": { "process": "[Function processColor]" } } }, "unequal": [] } ``` Changelog: [Internal] Reviewed By: JoshuaGross Differential Revision: D33409393 fbshipit-source-id: 9fa5b6cd5c8fc9bc01d825eb8fb7965c5cb691d2 --- .../DrawerAndroid/AndroidDrawerLayoutNativeComponent.js | 4 ++-- .../facebook/react/views/drawer/ReactDrawerLayoutManager.java | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Libraries/Components/DrawerAndroid/AndroidDrawerLayoutNativeComponent.js b/Libraries/Components/DrawerAndroid/AndroidDrawerLayoutNativeComponent.js index 868ee9a2a36..c0c1bf05375 100644 --- a/Libraries/Components/DrawerAndroid/AndroidDrawerLayoutNativeComponent.js +++ b/Libraries/Components/DrawerAndroid/AndroidDrawerLayoutNativeComponent.js @@ -92,12 +92,12 @@ type NativeProps = $ReadOnly<{| /** * Function called whenever the navigation view has been opened. */ - onDrawerOpen?: ?DirectEventHandler, + onDrawerOpen?: ?DirectEventHandler, /** * Function called whenever the navigation view has been closed. */ - onDrawerClose?: ?DirectEventHandler, + onDrawerClose?: ?DirectEventHandler, /** * Make the drawer take the entire screen and draw the background of the diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/drawer/ReactDrawerLayoutManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/drawer/ReactDrawerLayoutManager.java index 67066aa5299..f3b50120c4b 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/drawer/ReactDrawerLayoutManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/drawer/ReactDrawerLayoutManager.java @@ -154,12 +154,15 @@ public class ReactDrawerLayoutManager extends ViewGroupManager