From 847f8902ffe6c97aceadc885a94ada72d23c8a79 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Fri, 7 Feb 2025 14:28:12 -0800 Subject: [PATCH] Update non-codegen ViewManagerInterfaces to extend ViewManagerWithGeneratedInterface (#49274) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/49274 In this diff I'm updating all the non-codegen ViewManagerInterfaces to extend ViewManagerWithGeneratedInterface to make it consistent with codenerated ViewManagerInterfaces changelog: [internal] internal Reviewed By: javache Differential Revision: D69206247 fbshipit-source-id: 6a577d9ee7410be990a03e78847333b61b429e88 --- .../react/viewmanagers/AndroidPopupMenuManagerInterface.java | 3 ++- .../viewmanagers/SampleNativeComponentManagerInterface.java | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/react-native-popup-menu-android/android/src/main/java/com/facebook/react/viewmanagers/AndroidPopupMenuManagerInterface.java b/packages/react-native-popup-menu-android/android/src/main/java/com/facebook/react/viewmanagers/AndroidPopupMenuManagerInterface.java index 83e94ab5e29..e9369187ef9 100644 --- a/packages/react-native-popup-menu-android/android/src/main/java/com/facebook/react/viewmanagers/AndroidPopupMenuManagerInterface.java +++ b/packages/react-native-popup-menu-android/android/src/main/java/com/facebook/react/viewmanagers/AndroidPopupMenuManagerInterface.java @@ -12,8 +12,9 @@ package com.facebook.react.viewmanagers; import android.view.View; import androidx.annotation.Nullable; import com.facebook.react.bridge.ReadableArray; +import com.facebook.react.uimanager.ViewManagerWithGeneratedInterface; -public interface AndroidPopupMenuManagerInterface { +public interface AndroidPopupMenuManagerInterface extends ViewManagerWithGeneratedInterface { void setMenuItems(T view, @Nullable ReadableArray value); void show(T view); } diff --git a/packages/react-native-test-library/android/src/main/java/com/facebook/react/viewmanagers/SampleNativeComponentManagerInterface.java b/packages/react-native-test-library/android/src/main/java/com/facebook/react/viewmanagers/SampleNativeComponentManagerInterface.java index 83cdf8fbfa3..576aec6af7c 100644 --- a/packages/react-native-test-library/android/src/main/java/com/facebook/react/viewmanagers/SampleNativeComponentManagerInterface.java +++ b/packages/react-native-test-library/android/src/main/java/com/facebook/react/viewmanagers/SampleNativeComponentManagerInterface.java @@ -12,8 +12,9 @@ package com.facebook.react.viewmanagers; import android.view.View; import androidx.annotation.Nullable; import com.facebook.react.bridge.ReadableArray; +import com.facebook.react.uimanager.ViewManagerWithGeneratedInterface; -public interface SampleNativeComponentManagerInterface { +public interface SampleNativeComponentManagerInterface extends ViewManagerWithGeneratedInterface { void setOpacity(T view, float value); void setValues(T view, @Nullable ReadableArray value); void changeBackgroundColor(T view, String color);