From 847b44353a2229b8e3ba86151576bb426307d549 Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Mon, 24 Aug 2026 03:21:14 -0700 Subject: [PATCH] Cover `jsinspector-modern/cdp:jsinspector_cdp` with Stable API guards (#58042) Summary: Pull Request resolved: https://github.com/react/react-native/pull/58042 Classifies `jsinspector-modern/cdp:jsinspector_cdp` as a "for frameworks" target under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get a warning if they include its headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guard is inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: javache Differential Revision: D116917710 fbshipit-source-id: e34b6d2fe2b410d9a67f620deafa13a3d1dca354 --- .../ReactCommon/jsinspector-modern/cdp/CMakeLists.txt | 1 + .../react-native/ReactCommon/jsinspector-modern/cdp/CdpJson.h | 2 ++ .../jsinspector-modern/cdp/React-jsinspectorcdp.podspec | 2 ++ 3 files changed, 5 insertions(+) diff --git a/packages/react-native/ReactCommon/jsinspector-modern/cdp/CMakeLists.txt b/packages/react-native/ReactCommon/jsinspector-modern/cdp/CMakeLists.txt index 0931f76246f..43c0637dbf8 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/cdp/CMakeLists.txt +++ b/packages/react-native/ReactCommon/jsinspector-modern/cdp/CMakeLists.txt @@ -23,4 +23,5 @@ target_include_directories(jsinspector_cdp PUBLIC ${REACT_COMMON_DIR}) target_link_libraries(jsinspector_cdp folly_runtime + react_cxxstableapi ) diff --git a/packages/react-native/ReactCommon/jsinspector-modern/cdp/CdpJson.h b/packages/react-native/ReactCommon/jsinspector-modern/cdp/CdpJson.h index 89576d96295..6a0fd5cc696 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/cdp/CdpJson.h +++ b/packages/react-native/ReactCommon/jsinspector-modern/cdp/CdpJson.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include #include diff --git a/packages/react-native/ReactCommon/jsinspector-modern/cdp/React-jsinspectorcdp.podspec b/packages/react-native/ReactCommon/jsinspector-modern/cdp/React-jsinspectorcdp.podspec index 8a7eaf0496d..238487ff4ca 100644 --- a/packages/react-native/ReactCommon/jsinspector-modern/cdp/React-jsinspectorcdp.podspec +++ b/packages/react-native/ReactCommon/jsinspector-modern/cdp/React-jsinspectorcdp.podspec @@ -46,5 +46,7 @@ Pod::Spec.new do |s| add_rn_third_party_dependencies(s) add_rncore_dependency(s) + s.dependency "React-cxxstableapi" + mark_as_react_native_build(s) end