mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Generate pojo for Component Props
Summary: ## What This Does - **Phase 1:** Given a component, convert its props (and all its ObjectTypeAnnotations) into this Pojo data structure under some namespace. This is a recursive operation. - **Phase 2:** Loop over each Pojo data structure, and serialize it to Java class. So... - Each Component has its own namespace (i.e: its hasteModuleName) for Java Pojo objects. - Each Component generates 1 Pojo object, for its props. - Each Component generates 1 Pojo object for every ObjectTypeAnnotation in its props. ## Decisions By design, [JNI can read/write to private properties on Java objects](https://stackoverflow.com/a/12208643). So, each Pojo, which represents an ObjectTypeAnnotation, contains only a private member variable for each of its properties, and a getter to retrieve the data from each of its private members. ## Todos - Improved type-safety: - ReservedTypeAnnotation (e.g: PointPrimitive). These currently map to ReadableMap. - String enums, and Int enums don't actually generate Java enums. - Verify if there are any compilation issues by wiring this up to the Codegen buck infra. - To actually use the Pojos, we'll need C++/Jni codegen to transform C++ props into these Pojos. Building this out will give a more accurate assessment of the app-size cost of Pojos. However, we can do that if we deem that the app-size increase from adding just the Pojo classes is negligible enough to **not** rule out this entire approach. - ~~Add some annotations to prevent these Pojo classes from being stripped at compile-time.~~ D26041103 Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D26038189 fbshipit-source-id: c137c4ca6b043ee76adb354105aff6e0f270df86
This commit is contained in:
1 parent
dc0b917fb5
commit
8461409e88
12 files changed
+1621
-18
No files matched your search
Vendored
+2
-1
@@ -22,7 +22,8 @@ import type {AliasResolver} from '../Utils';
|
||||
|
||||
const invariant = require('invariant');
|
||||
const {StructCollector} = require('./StructCollector');
|
||||
const {capitalize, getNamespacedStructName} = require('./Utils');
|
||||
const {getNamespacedStructName} = require('./Utils');
|
||||
const {capitalize} = require('../../Utils');
|
||||
const {
|
||||
wrapNullable,
|
||||
unwrapNullable,
|
||||
|
||||
Reference in new issue
Block a user