From 83d38501b85882298b457f0185c73fbdf98cff18 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Tue, 5 Nov 2024 03:19:06 -0800 Subject: [PATCH] setup-gradle v4 + Remove unnecessary Gradle Wrapper Validation (#47389) Summary: As per: https://github.com/gradle/actions#the-wrapper-validation-action > Starting with v4 the setup-gradle action will [perform wrapper validation](https://github.com/gradle/actions/blob/main/docs/setup-gradle.md#gradle-wrapper-validation) on each execution. If you are using setup-gradle in your workflows, it is unlikely that you will need to use the wrapper-validation action. I'm moving to setup-gradle v4 and remove this unnecessary extra action. ## Changelog: [INTERNAL] - setup-gradle v4 + Remove unnecessary Gradle Wrapper Validation Pull Request resolved: https://github.com/facebook/react-native/pull/47389 Test Plan: CI Reviewed By: blakef Differential Revision: D65435069 Pulled By: cortinico fbshipit-source-id: c28b4d520e91fea9c59a341fb94598db5fc69900 --- .github/actions/setup-gradle/action.yml | 2 +- .github/workflows/gradle-wrapper-validation.yml | 13 ------------- 2 files changed, 1 insertion(+), 14 deletions(-) delete mode 100644 .github/workflows/gradle-wrapper-validation.yml diff --git a/.github/actions/setup-gradle/action.yml b/.github/actions/setup-gradle/action.yml index c146592c191..b815c62839f 100644 --- a/.github/actions/setup-gradle/action.yml +++ b/.github/actions/setup-gradle/action.yml @@ -8,7 +8,7 @@ runs: using: "composite" steps: - name: Setup gradle - uses: gradle/actions/setup-gradle@v3 + uses: gradle/actions/setup-gradle@v4 with: gradle-version: wrapper # We want the Gradle cache to be written only on main/-stable branches run, and only for jobs with `cache-read-only` == false (i.e. `build_android`). diff --git a/.github/workflows/gradle-wrapper-validation.yml b/.github/workflows/gradle-wrapper-validation.yml deleted file mode 100644 index eb1ab715d17..00000000000 --- a/.github/workflows/gradle-wrapper-validation.yml +++ /dev/null @@ -1,13 +0,0 @@ -name: "Validate Gradle Wrapper" - -on: - push: - pull_request: - -jobs: - validation: - name: "Validation" - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - uses: gradle/actions/wrapper-validation@v3