Implement layout constraint when measuring text

Summary: This diff adds support for layout constraint when measuring text

Reviewed By: shergin

Differential Revision: D13111434

fbshipit-source-id: 0c8689e9ac8ce2281b03386f275d2a8e034f88d8
This commit is contained in:
David Vacca authored and Facebook Github Bot committed 2018-11-17 02:27:20 -08:00
1 parent 2dbe769c5a
commit 8367fa9644
3 files changed
+21 -13

No files matched your search

@@ -38,10 +38,16 @@ Size TextLayoutManager::measure(
ReadableNativeMap::javaobject,
ReadableNativeMap::javaobject,
jint,
jint,
jint,
jint)>("measure");
int width = (int)layoutConstraints.maximumSize.width;
int height = (int)layoutConstraints.maximumSize.height;
auto minimumSize = layoutConstraints.minimumSize;
auto maximumSize = layoutConstraints.maximumSize;
int minWidth = (int)minimumSize.width;
int minHeight = (int)minimumSize.height;
int maxWidth = (int)maximumSize.width;
int maxHeight = (int)maximumSize.height;
local_ref<JString> componentName = make_jstring("RCTText");
auto values = measure(
fabricUIManager,
@@ -49,8 +55,10 @@ Size TextLayoutManager::measure(
componentName.get(),
ReadableNativeMap::newObjectCxxArgs(toDynamic(attributedString)).get(),
ReadableNativeMap::newObjectCxxArgs(toDynamic(paragraphAttributes)).get(),
width,
height);
minWidth,
maxWidth,
minHeight,
maxHeight);
std::vector<float> indices;
indices.resize(values->size());