From 82bc2d7168727d3bf300869f1e62df459c1a334b Mon Sep 17 00:00:00 2001
From: Moti Zilberman <moti@meta.com>
Date: Wed, 20 Dec 2023 06:20:38 -0800
Subject: [PATCH] Back out "Add log message if App moves to background"
 (#41971)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/41971

Original commit changeset: 29e1aba9c4ea

Original Phabricator Diff: D49956535

D49956535 added the new behaviour of logging helpful messages to the CDP console when the app is backgrounded/foregrounded. The underlying UX issue is legitimate: how do we reinforce the mental connection between the debugger frontend and the app being debugged, when they might be running in different windows or even machines, and particularly when the app might be backgrounded while the debugger frontend remains active.

However, this implementation is too closely coupled to the socket management layer, and is iOS-specific to boot. I'm removing it here to simplify porting `RCTInspectorPackagerConnection` to C++. We can revisit this UX problem later - preferably by investigating how it's handled in the case of Chrome Android and a remote DevTools client.

This feature has not been included in an OSS release of React Native yet, so very few users will be affected by its removal.

Changelog: [iOS][Removed] - Revert D49956535; remove console.log notification in DevTools if app transitions between back/foreground.

Reviewed By: blakef

Differential Revision: D51468311

fbshipit-source-id: b875d6cf03d3521c8e876c358b2299f20d395400
---
 .../RCTInspectorPackagerConnection.h          |  1 -
 .../RCTInspectorPackagerConnection.m          | 39 -------------------
 2 files changed, 40 deletions(-)

diff --git a/packages/react-native/React/Inspector/RCTInspectorPackagerConnection.h b/packages/react-native/React/Inspector/RCTInspectorPackagerConnection.h
index 26c56f8b967..96bb8416b77 100644
--- a/packages/react-native/React/Inspector/RCTInspectorPackagerConnection.h
+++ b/packages/react-native/React/Inspector/RCTInspectorPackagerConnection.h
@@ -30,7 +30,6 @@ typedef RCTBundleStatus * (^RCTBundleStatusProvider)(void);
 @interface RCTInspectorRemoteConnection : NSObject
 - (void)onMessage:(NSString *)message;
 - (void)onDisconnect;
-- (void)handleBackgroundEvent:(NSNotification *)notification;
 @end
 
 #endif
diff --git a/packages/react-native/React/Inspector/RCTInspectorPackagerConnection.m b/packages/react-native/React/Inspector/RCTInspectorPackagerConnection.m
index 07b1b404b5b..97e005f8fd6 100644
--- a/packages/react-native/React/Inspector/RCTInspectorPackagerConnection.m
+++ b/packages/react-native/React/Inspector/RCTInspectorPackagerConnection.m
@@ -325,49 +325,10 @@ RCT_NOT_IMPLEMENTED(-(instancetype)init)
   if (self = [super init]) {
     _owningPackagerConnection = owningPackagerConnection;
     _pageId = pageId;
-    [self addObserverFor:UIApplicationDidEnterBackgroundNotification];
-    [self addObserverFor:UIApplicationWillEnterForegroundNotification];
   }
   return self;
 }
 
-- (void)addObserverFor:(NSString *)notificationName
-{
-  [[NSNotificationCenter defaultCenter] addObserver:self
-                                           selector:@selector(handleBackgroundEvent:)
-                                               name:notificationName
-                                             object:nil];
-}
-
-- (void)consoleInfo:(NSString *)message format:(NSString *)format
-{
-  if (!message) {
-    return;
-  }
-  NSNumber *now = @([[NSDate date] timeIntervalSince1970] * 1000);
-  NSDictionary *json = @{
-    @"method" : @"Runtime.consoleAPICalled",
-    @"params" : @{@"type" : @"info", @"args" : format == nil ? @[ message ] : @[ message, format ], @"timestamp" : now}
-  };
-  NSError *error = nil;
-  NSData *data = [NSJSONSerialization dataWithJSONObject:json options:0 error:&error];
-  if (error != nil) {
-    NSLog(@"Unable to serialize a console.warn() message: %@", error);
-    return;
-  }
-  NSString *str = [[NSString alloc] initWithData:data encoding:NSUTF8StringEncoding];
-  [self onMessage:str];
-}
-
-- (void)handleBackgroundEvent:(NSNotification *)notification
-{
-  if ([notification.name isEqualToString:UIApplicationWillEnterForegroundNotification]) {
-    [self consoleInfo:@"App has moved into the %cforeground" format:@"font-weight: bold"];
-  } else if ([notification.name isEqualToString:UIApplicationDidEnterBackgroundNotification]) {
-    [self consoleInfo:@"App has moved into the %cbackground" format:@"font-weight: bold"];
-  }
-}
-
 - (void)onMessage:(NSString *)message
 {
   [_owningPackagerConnection sendWrappedEvent:_pageId message:message];