From 829a76afa7882bf2cd8e53aa353386bdb07469ac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dawid=20Ma=C5=82ecki?= Date: Tue, 31 Mar 2026 08:32:57 -0700 Subject: [PATCH] Exclude InputAccessory component from the ReactAndroid C++ API snapshot (#56251) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/56251 Excludes InputAccessory which is an iOS-only component with no Android support at any layer. In the `InputAccessoryView.js` there is explicit iOS guard which logs warning on Android. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D98478125 fbshipit-source-id: 871923e001024971167a7bb2eb900ca3867983a4 --- .../api-snapshots/ReactAndroidDebugCxx.api | 29 ------------------- .../api-snapshots/ReactAndroidReleaseCxx.api | 29 ------------------- scripts/cxx-api/config.yml | 3 ++ 3 files changed, 3 insertions(+), 58 deletions(-) diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api index 668a8c43765..596a0c6afd7 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api @@ -457,7 +457,6 @@ const char facebook::react::AndroidTextInputComponentName[]; const char facebook::react::ImageComponentName[]; const char facebook::react::ImageFetcherKey[]; const char facebook::react::ImageManagerKey[]; -const char facebook::react::InputAccessoryComponentName[]; const char facebook::react::LegacyViewManagerAndroidInteropComponentName[]; const char facebook::react::LegacyViewManagerInteropComponentName[]; const char facebook::react::ModalHostViewComponentName[]; @@ -2674,34 +2673,6 @@ class facebook::react::ImageTelemetry { public facebook::react::TelemetryTimePoint getWillRequestUrlTime() const; } -class facebook::react::InputAccessoryComponentDescriptor : public facebook::react::ConcreteComponentDescriptor { - public InputAccessoryComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters, facebook::react::RawPropsParser&& rawPropsParser = {}); - public virtual void adopt(facebook::react::ShadowNode& shadowNode) const override; -} - -class facebook::react::InputAccessoryEventEmitter : public facebook::react::BaseViewEventEmitter { -} - -class facebook::react::InputAccessoryProps : public facebook::react::HostPlatformViewProps { - public InputAccessoryProps() = default; - public InputAccessoryProps(const facebook::react::PropsParserContext& context, const facebook::react::InputAccessoryProps& sourceProps, const facebook::react::RawProps& rawProps); - public facebook::react::SharedColor backgroundColor; - public virtual facebook::react::ComponentName getDiffPropsImplementationTarget() const override; - public virtual folly::dynamic getDiffProps(const facebook::react::Props* prevProps) const override; -} - -class facebook::react::InputAccessoryShadowNode : public facebook::react::ConcreteViewShadowNode { - public InputAccessoryShadowNode(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment); - public InputAccessoryShadowNode(const facebook::react::ShadowNodeFragment& fragment, const facebook::react::ShadowNodeFamily::Shared& family, facebook::react::ShadowNodeTraits traits); - public static facebook::react::ShadowNodeTraits BaseTraits(); -} - -class facebook::react::InputAccessoryState { - public InputAccessoryState(); - public InputAccessoryState(facebook::react::Size viewportSize_); - public const facebook::react::Size viewportSize; -} - class facebook::react::InspectorNetworkRequestListener : public jni::HybridClass { public static constexpr auto kJavaDescriptor; public static void registerNatives(); diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api index bcb202834cb..0de2da5e2c9 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api @@ -457,7 +457,6 @@ const char facebook::react::AndroidTextInputComponentName[]; const char facebook::react::ImageComponentName[]; const char facebook::react::ImageFetcherKey[]; const char facebook::react::ImageManagerKey[]; -const char facebook::react::InputAccessoryComponentName[]; const char facebook::react::LegacyViewManagerAndroidInteropComponentName[]; const char facebook::react::LegacyViewManagerInteropComponentName[]; const char facebook::react::ModalHostViewComponentName[]; @@ -2671,34 +2670,6 @@ class facebook::react::ImageTelemetry { public facebook::react::TelemetryTimePoint getWillRequestUrlTime() const; } -class facebook::react::InputAccessoryComponentDescriptor : public facebook::react::ConcreteComponentDescriptor { - public InputAccessoryComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters, facebook::react::RawPropsParser&& rawPropsParser = {}); - public virtual void adopt(facebook::react::ShadowNode& shadowNode) const override; -} - -class facebook::react::InputAccessoryEventEmitter : public facebook::react::BaseViewEventEmitter { -} - -class facebook::react::InputAccessoryProps : public facebook::react::HostPlatformViewProps { - public InputAccessoryProps() = default; - public InputAccessoryProps(const facebook::react::PropsParserContext& context, const facebook::react::InputAccessoryProps& sourceProps, const facebook::react::RawProps& rawProps); - public facebook::react::SharedColor backgroundColor; - public virtual facebook::react::ComponentName getDiffPropsImplementationTarget() const override; - public virtual folly::dynamic getDiffProps(const facebook::react::Props* prevProps) const override; -} - -class facebook::react::InputAccessoryShadowNode : public facebook::react::ConcreteViewShadowNode { - public InputAccessoryShadowNode(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment); - public InputAccessoryShadowNode(const facebook::react::ShadowNodeFragment& fragment, const facebook::react::ShadowNodeFamily::Shared& family, facebook::react::ShadowNodeTraits traits); - public static facebook::react::ShadowNodeTraits BaseTraits(); -} - -class facebook::react::InputAccessoryState { - public InputAccessoryState(); - public InputAccessoryState(facebook::react::Size viewportSize_); - public const facebook::react::Size viewportSize; -} - class facebook::react::InspectorNetworkRequestListener : public jni::HybridClass { public static constexpr auto kJavaDescriptor; public static void registerNatives(); diff --git a/scripts/cxx-api/config.yml b/scripts/cxx-api/config.yml index 35bc28210f8..f6cf24fbf8c 100644 --- a/scripts/cxx-api/config.yml +++ b/scripts/cxx-api/config.yml @@ -44,10 +44,13 @@ platforms: exclude_patterns: - "*/ReactAndroid/src/main/jni/react/featureflags/*" - "*/components/switch/iosswitch/*" + - "*/components/inputaccessory/*" - "*/platform/cxx/*" - "*/platform/windows/*" - "*/platform/macos/*" - "*/platform/ios/*" + exclude_symbols: + - "InputAccessory" input_filter: false definitions: RN_SERIALIZABLE_STATE: 1