Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Call Turbo Module methods 'methods' in the Turbo Module JSON schema (#44919)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/44919

## Changelog:

[Internal] [Fixed] - Call Turbo Module methods 'methods' in the Turbo Module JSON schema

We don't support `properties` on Turbo Modules. We only support methods (even eventEmitters are just methods)

Reviewed By: javache

Differential Revision: D58510557

fbshipit-source-id: 02b1dc93a37b58b47bb9fd94a9658b5a7301bf55
This commit is contained in:
Christoph Purrer
2024-06-14 10:36:31 -07:00
committed by Facebook GitHub Bot
parent 358fe46969
commit 810a516475
16 changed files with 108 additions and 117 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native-codegen/src/generators/modules/GenerateModuleH.js
Vendored
+2 -2
View File
@@ -606,7 +606,7 @@ module.exports = {
return [
ModuleClassDeclarationTemplate({
hasteModuleName,
moduleProperties: spec.properties.map(prop =>
moduleProperties: spec.methods.map(prop =>
translatePropertyToCpp(
hasteModuleName,
prop,
@@ -629,7 +629,7 @@ module.exports = {
enumMap,
),
),
moduleProperties: spec.properties.map(prop =>
moduleProperties: spec.methods.map(prop =>
translatePropertyToCpp(
hasteModuleName,
prop,