From 8056cd7f05d7959fce658af3a29619e7d0af3cd9 Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Mon, 30 Jan 2023 04:25:26 -0800 Subject: [PATCH] Add Tests in CircleCI to check dynamic frameworks with the old arch (#36003) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/36003 This diff adds 4 tests in CircleCI to make sure we don't regress in the support of Dynamic Frameworks for the old architecture. ## Changelog [iOS][Fixed] - Add CircleCI tests for dynamic frameworks with the Old Architecture. Reviewed By: cortinico Differential Revision: D42829895 fbshipit-source-id: 5669be45d4f55161a11a6ece161b2a2aa384a644 --- .circleci/config.yml | 66 ++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 64 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 464cef6c10b..14cc5daaabc 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -853,7 +853,7 @@ jobs: default: "StaticLibraries" description: Which kind of option we want to use for `use_frameworks!` type: enum - enum: ["StaticLibraries", "StaticFrameworks"] #TODO: Add "DynamicFrameworks" + enum: ["StaticLibraries", "StaticFrameworks", "DynamicFrameworks"] environment: - PROJECT_NAME: "iOSTemplateProject" - HERMES_WS_DIR: *hermes_workspace_root @@ -906,6 +906,8 @@ jobs: if [[ << parameters.use_frameworks >> == "StaticFrameworks" ]]; then export USE_FRAMEWORKS=static + elif [[ << parameters.use_frameworks >> == "DynamicFrameworks" ]]; then + export USE_FRAMEWORKS=dynamic fi bundle exec pod install @@ -1636,7 +1638,7 @@ workflows: flavor: ["Debug", "Release"] jsengine: ["Hermes", "JSC"] flipper: ["WithFlipper", "WithoutFlipper"] - use_frameworks: [ "StaticLibraries", "StaticFrameworks" ] #TODO: make it works with DynamicFrameworks + use_frameworks: ["StaticLibraries", "StaticFrameworks", "DynamicFrameworks"] exclude: - architecture: "NewArch" flavor: "Release" @@ -1648,11 +1650,21 @@ workflows: jsengine: "Hermes" flipper: "WithFlipper" use_frameworks: "StaticFrameworks" + - architecture: "NewArch" + flavor: "Release" + jsengine: "Hermes" + flipper: "WithFlipper" + use_frameworks: "DynamicFrameworks" - architecture: "NewArch" flavor: "Release" jsengine: "Hermes" flipper: "WithoutFlipper" use_frameworks: "StaticFrameworks" + - architecture: "NewArch" + flavor: "Release" + jsengine: "Hermes" + flipper: "WithoutFlipper" + use_frameworks: "DynamicFrameworks" - architecture: "NewArch" flavor: "Release" jsengine: "JSC" @@ -1663,11 +1675,21 @@ workflows: jsengine: "JSC" flipper: "WithFlipper" use_frameworks: "StaticFrameworks" + - architecture: "NewArch" + flavor: "Release" + jsengine: "JSC" + flipper: "WithFlipper" + use_frameworks: "DynamicFrameworks" - architecture: "NewArch" flavor: "Release" jsengine: "JSC" flipper: "WithoutFlipper" use_frameworks: "StaticFrameworks" + - architecture: "NewArch" + flavor: "Release" + jsengine: "JSC" + flipper: "WithoutFlipper" + use_frameworks: "DynamicFrameworks" - architecture: "OldArch" flavor: "Release" jsengine: "Hermes" @@ -1678,6 +1700,11 @@ workflows: jsengine: "Hermes" flipper: "WithFlipper" use_frameworks: "StaticFrameworks" + - architecture: "OldArch" + flavor: "Release" + jsengine: "Hermes" + flipper: "WithFlipper" + use_frameworks: "DynamicFrameworks" - architecture: "OldArch" flavor: "Release" jsengine: "JSC" @@ -1688,6 +1715,11 @@ workflows: jsengine: "JSC" flipper: "WithFlipper" use_frameworks: "StaticFrameworks" + - architecture: "OldArch" + flavor: "Release" + jsengine: "JSC" + flipper: "WithFlipper" + use_frameworks: "DynamicFrameworks" - architecture: "NewArch" flavor: "Debug" jsengine: "Hermes" @@ -1718,6 +1750,36 @@ workflows: jsengine: "JSC" flipper: "WithFlipper" use_frameworks: "StaticFrameworks" + - architecture: "NewArch" + flavor: "Debug" + jsengine: "Hermes" + flipper: "WithFlipper" + use_frameworks: "DynamicFrameworks" + - architecture: "NewArch" + flavor: "Debug" + jsengine: "Hermes" + flipper: "WithoutFlipper" + use_frameworks: "DynamicFrameworks" + - architecture: "NewArch" + flavor: "Debug" + jsengine: "JSC" + flipper: "WithFlipper" + use_frameworks: "DynamicFrameworks" + - architecture: "NewArch" + flavor: "Debug" + jsengine: "JSC" + flipper: "WithoutFlipper" + use_frameworks: "DynamicFrameworks" + - architecture: "OldArch" + flavor: "Debug" + jsengine: "Hermes" + flipper: "WithFlipper" + use_frameworks: "DynamicFrameworks" + - architecture: "OldArch" + flavor: "Debug" + jsengine: "JSC" + flipper: "WithFlipper" + use_frameworks: "DynamicFrameworks" - test_ios_rntester: requires: - build_hermes_macos