From 7f20deb4284e2c2e06a1cb56577d7a37c087aeb4 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Mon, 13 Feb 2023 05:24:00 -0800 Subject: [PATCH] Use namespace for ReactAndroid and hermes-engine Summary: Our first party modules are still using `namespace`. This cleans this up. The Manifest file for ReactAndroid is also not needed anymore. The one from hermes-engine can also be removed from facebook/hermes in a separate diff. Changelog: [Internal] [Changed] - Use namespace for ReactAndroid and hermes-engine Reviewed By: cipolleschi Differential Revision: D43198514 fbshipit-source-id: d988cfa81ecc4484b6b2add4ae2c1d9376febc3e --- ReactAndroid/build.gradle | 1 + ReactAndroid/hermes-engine/build.gradle | 1 + ReactAndroid/src/main/AndroidManifest.xml | 5 ----- 3 files changed, 2 insertions(+), 5 deletions(-) delete mode 100644 ReactAndroid/src/main/AndroidManifest.xml diff --git a/ReactAndroid/build.gradle b/ReactAndroid/build.gradle index 9ef5b784dc9..6cfc6a248c9 100644 --- a/ReactAndroid/build.gradle +++ b/ReactAndroid/build.gradle @@ -417,6 +417,7 @@ task installArchives { android { buildToolsVersion = "33.0.0" compileSdkVersion 33 + namespace "com.facebook.react" // Used to override the NDK path/version on internal CI or by allowing // users to customize the NDK path/version from their root project (e.g. for M1 support) diff --git a/ReactAndroid/hermes-engine/build.gradle b/ReactAndroid/hermes-engine/build.gradle index f9f57f2c797..5bf2330276f 100644 --- a/ReactAndroid/hermes-engine/build.gradle +++ b/ReactAndroid/hermes-engine/build.gradle @@ -119,6 +119,7 @@ def reactNativeArchitectures() { android { compileSdkVersion 31 buildToolsVersion = "31.0.0" + namespace "com.facebook.hermes" // Used to override the NDK path/version on internal CI or by allowing // users to customize the NDK path/version from their root project (e.g. for M1 support) diff --git a/ReactAndroid/src/main/AndroidManifest.xml b/ReactAndroid/src/main/AndroidManifest.xml deleted file mode 100644 index ec2751f1bac..00000000000 --- a/ReactAndroid/src/main/AndroidManifest.xml +++ /dev/null @@ -1,5 +0,0 @@ - - - - -