Remove enableExperimentalStateUpdateRetry feature flag

Summary:
In practice this has been enabled in production for months and is fine. Remove feature-flag and gating.

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D25451697

fbshipit-source-id: 9e70db3ed4e00de7b8295d9225d43ba09e4e68e9

ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java

@@ -74,9 +74,6 @@ public class ReactFeatureFlags {
   /** Feature flag to configure eager initialization of Fabric */
   public static boolean eagerInitializeFabric = false;
 
-  /** Use experimental SetState retry mechanism in view? */
-  public static boolean enableExperimentalStateUpdateRetry = false;
-
   /** Use lock-free data structures for Fabric MountItems. */
   public static boolean enableLockFreeMountInstructions = false;
 

ReactAndroid/src/main/java/com/facebook/react/uimanager/FabricViewStateManager.java

@@ -11,7 +11,6 @@ import androidx.annotation.Nullable;
 import com.facebook.common.logging.FLog;
 import com.facebook.react.bridge.ReadableMap;
 import com.facebook.react.bridge.WritableMap;
-import com.facebook.react.config.ReactFeatureFlags;
 
 /**
  * This is a helper base class for ViewGroups that use Fabric State.
@@ -67,18 +66,15 @@ public class FabricViewStateManager {
       return;
     }
 
-    Runnable failureRunnable = null;
-    if (ReactFeatureFlags.enableExperimentalStateUpdateRetry) {
-      failureRunnable =
-          new Runnable() {
-            @Override
-            // Run on the UI thread
-            public void run() {
-              FLog.e(TAG, "UpdateState failed - retrying! " + numTries);
-              setState(stateWrapper, stateUpdateCallback, numTries + 1);
-            }
-          };
-    }
+    Runnable failureRunnable =
+        new Runnable() {
+          @Override
+          // Run on the UI thread
+          public void run() {
+            FLog.e(TAG, "UpdateState failed - retrying! " + numTries);
+            setState(stateWrapper, stateUpdateCallback, numTries + 1);
+          }
+        };
     @Nullable WritableMap stateUpdate = stateUpdateCallback.getStateUpdate();
     if (stateUpdate == null) {
       return;