From 7eafaa2db7267dacb5cc73367da63c93a7fcc182 Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Thu, 27 Aug 2026 01:26:04 -0700 Subject: [PATCH] Cover the intersection observer modules with Stable API guards (#58125) Summary: Pull Request resolved: https://github.com/react/react-native/pull/58125 Classifies `react/renderer/observers/intersection:intersection` and `react/nativemodule/intersectionobserver:intersectionobserver` as private targets under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get an error if they include their headers directly; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D117324071 fbshipit-source-id: 0ee34eea6ba8688da5f4e51b51d0e945ee295df8 --- .../react/nativemodule/intersectionobserver/CMakeLists.txt | 1 + .../intersectionobserver/NativeIntersectionObserver.h | 2 ++ .../React-intersectionobservernativemodule.podspec | 1 + .../react/renderer/observers/intersection/CMakeLists.txt | 1 + .../renderer/observers/intersection/IntersectionObserver.h | 2 ++ .../observers/intersection/IntersectionObserverManager.h | 2 ++ .../renderer/observers/intersection/IntersectionObserverState.h | 2 ++ 7 files changed, 11 insertions(+) diff --git a/packages/react-native/ReactCommon/react/nativemodule/intersectionobserver/CMakeLists.txt b/packages/react-native/ReactCommon/react/nativemodule/intersectionobserver/CMakeLists.txt index caceb4cb9f1..54b803672ac 100644 --- a/packages/react-native/ReactCommon/react/nativemodule/intersectionobserver/CMakeLists.txt +++ b/packages/react-native/ReactCommon/react/nativemodule/intersectionobserver/CMakeLists.txt @@ -16,6 +16,7 @@ target_include_directories(react_nativemodule_intersectionobserver PUBLIC ${REAC target_link_libraries(react_nativemodule_intersectionobserver react_codegen_rncore react_cxxreact + react_cxxstableapi react_renderer_bridging react_renderer_core react_renderer_graphics diff --git a/packages/react-native/ReactCommon/react/nativemodule/intersectionobserver/NativeIntersectionObserver.h b/packages/react-native/ReactCommon/react/nativemodule/intersectionobserver/NativeIntersectionObserver.h index 7399355346b..17b5ddd9eab 100644 --- a/packages/react-native/ReactCommon/react/nativemodule/intersectionobserver/NativeIntersectionObserver.h +++ b/packages/react-native/ReactCommon/react/nativemodule/intersectionobserver/NativeIntersectionObserver.h @@ -7,6 +7,8 @@ #pragma once +#include + #if __has_include("FBReactNativeSpecJSI.h") // CocoaPod headers on Apple #include "FBReactNativeSpecJSI.h" #else diff --git a/packages/react-native/ReactCommon/react/nativemodule/intersectionobserver/React-intersectionobservernativemodule.podspec b/packages/react-native/ReactCommon/react/nativemodule/intersectionobserver/React-intersectionobservernativemodule.podspec index d390a2844ba..b971c5d5986 100644 --- a/packages/react-native/ReactCommon/react/nativemodule/intersectionobserver/React-intersectionobservernativemodule.podspec +++ b/packages/react-native/ReactCommon/react/nativemodule/intersectionobserver/React-intersectionobservernativemodule.podspec @@ -60,6 +60,7 @@ Pod::Spec.new do |s| s.dependency "React-Fabric" s.dependency "React-Fabric/bridging" s.dependency "React-runtimescheduler" + s.dependency "React-cxxstableapi" add_dependency(s, "React-RCTFBReactNativeSpec") add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"]) add_dependency(s, "React-graphics", :additional_framework_paths => ["react/renderer/graphics/platform/ios"]) diff --git a/packages/react-native/ReactCommon/react/renderer/observers/intersection/CMakeLists.txt b/packages/react-native/ReactCommon/react/renderer/observers/intersection/CMakeLists.txt index 62e0229cf62..8892e3bc70a 100644 --- a/packages/react-native/ReactCommon/react/renderer/observers/intersection/CMakeLists.txt +++ b/packages/react-native/ReactCommon/react/renderer/observers/intersection/CMakeLists.txt @@ -16,6 +16,7 @@ target_include_directories(react_renderer_observers_intersection PUBLIC ${REACT_ target_link_libraries(react_renderer_observers_intersection react_cxxreact react_bridging + react_cxxstableapi react_debug react_renderer_core react_renderer_graphics diff --git a/packages/react-native/ReactCommon/react/renderer/observers/intersection/IntersectionObserver.h b/packages/react-native/ReactCommon/react/renderer/observers/intersection/IntersectionObserver.h index 4a689f18469..9fa5cce71df 100644 --- a/packages/react-native/ReactCommon/react/renderer/observers/intersection/IntersectionObserver.h +++ b/packages/react-native/ReactCommon/react/renderer/observers/intersection/IntersectionObserver.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/observers/intersection/IntersectionObserverManager.h b/packages/react-native/ReactCommon/react/renderer/observers/intersection/IntersectionObserverManager.h index 06e7daa0a70..ddd3cb1af6a 100644 --- a/packages/react-native/ReactCommon/react/renderer/observers/intersection/IntersectionObserverManager.h +++ b/packages/react-native/ReactCommon/react/renderer/observers/intersection/IntersectionObserverManager.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/observers/intersection/IntersectionObserverState.h b/packages/react-native/ReactCommon/react/renderer/observers/intersection/IntersectionObserverState.h index 610354f0504..a1d92e735ed 100644 --- a/packages/react-native/ReactCommon/react/renderer/observers/intersection/IntersectionObserverState.h +++ b/packages/react-native/ReactCommon/react/renderer/observers/intersection/IntersectionObserverState.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include