From 7e5a2663f997beb3179e2b6e464cd1c6c240ea63 Mon Sep 17 00:00:00 2001 From: Tim Yung Date: Mon, 12 May 2025 09:15:43 -0700 Subject: [PATCH] RN: Simplify `createAnimatedPropsHook-test.js` (#51234) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/51234 Since `createAnimatedPropsHook-test.js` no longer needs to override feature flags, clean up some of the extra logic. Changelog: [Internal] Reviewed By: javache Differential Revision: D74535116 fbshipit-source-id: 09dd4c5085f6ee1cbf7d87ab2b7c320119e69651 --- .../__tests__/createAnimatedPropsHook-test.js | 30 ++----------------- 1 file changed, 2 insertions(+), 28 deletions(-) diff --git a/packages/react-native/src/private/animated/__tests__/createAnimatedPropsHook-test.js b/packages/react-native/src/private/animated/__tests__/createAnimatedPropsHook-test.js index 2b6f4e71177..207568db86a 100644 --- a/packages/react-native/src/private/animated/__tests__/createAnimatedPropsHook-test.js +++ b/packages/react-native/src/private/animated/__tests__/createAnimatedPropsHook-test.js @@ -9,37 +9,13 @@ * @oncall react_native */ -import type {ReactNativeFeatureFlagsJsOnlyOverrides} from '../../featureflags/ReactNativeFeatureFlags'; - import {create, update} from '../../../../jest/renderer'; +import {AnimatedEvent} from '../../../../Libraries/Animated/AnimatedEvent'; +import createAnimatedPropsHook from '../createAnimatedPropsHook'; import {useLayoutEffect} from 'react'; describe('useAnimatedProps', () => { - function importModules(overrides: ReactNativeFeatureFlagsJsOnlyOverrides) { - const ReactNativeFeatureFlags = require('../../featureflags/ReactNativeFeatureFlags'); - - // Make sure to setup overrides before importing any modules. - ReactNativeFeatureFlags.override(overrides); - - return { - // $FlowIgnore[unsafe-getters-setters] - get AnimatedEvent() { - return require('../../../../Libraries/Animated/AnimatedEvent') - .AnimatedEvent; - }, - // $FlowIgnore[unsafe-getters-setters] - get createAnimatedPropsHook() { - return require('../createAnimatedPropsHook').default; - }, - }; - } - - beforeEach(() => { - jest.resetModules(); - }); - it('returns the same ref callback when `props` changes', async () => { - const {createAnimatedPropsHook} = importModules({}); const useAnimatedProps = createAnimatedPropsHook(null); const refs = []; @@ -60,7 +36,6 @@ describe('useAnimatedProps', () => { }); it('returns the same ref callback when `AnimatedEvent` is the same', async () => { - const {AnimatedEvent, createAnimatedPropsHook} = importModules({}); const useAnimatedProps = createAnimatedPropsHook(null); const refs = []; @@ -83,7 +58,6 @@ describe('useAnimatedProps', () => { }); it('returns a new ref callback when `AnimatedEvent` changes', async () => { - const {AnimatedEvent, createAnimatedPropsHook} = importModules({}); const useAnimatedProps = createAnimatedPropsHook(null); const refs = [];