From 7d8aeb4955a4101ca7e8e486f935309c21ab76ff Mon Sep 17 00:00:00 2001 From: fabriziobertoglio1987 Date: Wed, 1 Jul 2020 17:43:25 -0700 Subject: [PATCH] do not call setHyphenationFrequency on AndroidSdk < 23 (#29258) Summary: JoshuaGross This issue fixes https://github.com/facebook/react-native/issues/28279 as discussed in https://github.com/facebook/react-native/pull/29157#issuecomment-649993571 Avoid calling [setHyphenationFrequency](https://developer.android.com/reference/android/widget/TextView#setHyphenationFrequency(int)) on Android Sdk < 23. ## Changelog [Android] [Fixed] - do not call setHyphenationFrequency on AndroidSdk < 23 Pull Request resolved: https://github.com/facebook/react-native/pull/29258 Test Plan: | **BEFORE** | **AFTER** | |:-------------------------:|:-------------------------:| | | | The warning displayed with `adb logcat | grep -P "ReactTextAnchorViewManager"` ![image](https://user-images.githubusercontent.com/24992535/86214242-34d57f80-bb7b-11ea-9945-30ae25332bfb.png) I remain available to do improvements. Thanks a lot. Fabrizio. Reviewed By: JoshuaGross Differential Revision: D22337095 Pulled By: mdvacca fbshipit-source-id: d0943397af180929c48044ccbc7a9388549021b8 --- .../react/views/text/ReactTextAnchorViewManager.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextAnchorViewManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextAnchorViewManager.java index 4fdbd76abab..ffc8655c0a4 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextAnchorViewManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextAnchorViewManager.java @@ -7,6 +7,7 @@ package com.facebook.react.views.text; +import android.os.Build; import android.text.Layout; import android.text.Spannable; import android.text.TextUtils; @@ -14,6 +15,7 @@ import android.text.util.Linkify; import android.view.Gravity; import android.view.View; import androidx.annotation.Nullable; +import com.facebook.common.logging.FLog; import com.facebook.react.bridge.JSApplicationIllegalArgumentException; import com.facebook.react.uimanager.BaseViewManager; import com.facebook.react.uimanager.PixelUtil; @@ -39,6 +41,7 @@ public abstract class ReactTextAnchorViewManager