Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove class-loading experiment for View Managers.

Browse Source 
Reviewed By: fkgozali

Differential Revision: D7418876

fbshipit-source-id: 52f8dce29a509233b9545a564c4f0d390fa81f13
This commit is contained in:
Dmitry Zakharov
2018-03-28 13:22:58 -07:00
committed by Facebook Github Bot
parent 88ba7ebcc7
commit 7cbb222cd5
4 changed files with 8 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/CompositeReactPackage.java
+4 -6
View File
@@ -98,14 +98,13 @@ public class CompositeReactPackage extends ReactInstancePackage
/** {@inheritDoc} */
@Override
public List<String> getViewManagerNames(
ReactApplicationContext reactContext, boolean loadClasses) {
public List<String> getViewManagerNames(ReactApplicationContext reactContext) {
Set<String> uniqueNames = new HashSet<>();
for (ReactPackage reactPackage : mChildReactPackages) {
if (reactPackage instanceof ViewManagerOnDemandReactPackage) {
List<String> names =
((ViewManagerOnDemandReactPackage) reactPackage)
.getViewManagerNames(reactContext, loadClasses);
.getViewManagerNames(reactContext);
if (names != null) {
uniqueNames.addAll(names);
}
@@ -116,15 +115,14 @@ public class CompositeReactPackage extends ReactInstancePackage
/** {@inheritDoc} */
@Override
public @Nullable ViewManager createViewManager(
ReactApplicationContext reactContext, String viewManagerName, boolean loadClasses) {
public @Nullable ViewManager createViewManager(ReactApplicationContext reactContext, String viewManagerName) {
ListIterator<ReactPackage> iterator = mChildReactPackages.listIterator(mChildReactPackages.size());
while (iterator.hasPrevious()) {
ReactPackage reactPackage = iterator.previous();
if (reactPackage instanceof ViewManagerOnDemandReactPackage) {
ViewManager viewManager =
((ViewManagerOnDemandReactPackage) reactPackage)
.createViewManager(reactContext, viewManagerName, loadClasses);
.createViewManager(reactContext, viewManagerName);
if (viewManager != null) {
return viewManager;
}