From 7c3f3e3146c9d1ef3da0d5e022e5b8bd20152a59 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Tue, 2 Jul 2019 14:40:01 -0700 Subject: [PATCH] Prevent execution of MountItems without mounting instructions Summary: This diff prevents the execution of MountItems without mounting instructions Reviewed By: JoshuaGross Differential Revision: D16063571 fbshipit-source-id: 97ff93c6880c7d8857f61d4998df4327f41fafdd --- .../src/main/java/com/facebook/react/fabric/jni/Binding.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp b/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp index 6280960556a..bb52df9d89f 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp +++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp @@ -596,6 +596,11 @@ void Binding::schedulerDidFinishTransaction( } } + if (position <= 0) { + // If there are no mountItems to be sent to the platform, then it is not necessary to even call. + return; + } + static auto createMountItemsBatchContainer = jni::findClassStatic(UIManagerJavaDescriptor) ->getMethod(