NativeAnimatedModule: don't restore default values when disconnected nodes in Fabric

Summary:
See title.

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D22488069

fbshipit-source-id: a0cb2dc65e5ea4befd7921acd194a67840b1498d
This commit is contained in:
Joshua Gross
2020-07-10 23:32:37 -07:00
committed by Facebook GitHub Bot
parent 80f13412e5
commit 7bf56e1902
2 changed files with 22 additions and 3 deletions
@@ -183,6 +183,15 @@ public class NativeAnimatedNodeTraversalTest {
};
}
});
PowerMockito.when(mUIManagerMock.resolveCustomDirectEventName(any(String.class)))
.thenAnswer(
new Answer<String>() {
@Override
public String answer(InvocationOnMock invocation) throws Throwable {
String arg = invocation.getArguments()[0].toString();
return "on" + arg.substring(3);
}
});
mNativeAnimatedNodesManager = new NativeAnimatedNodesManager(mReactApplicationContextMock);
}
@@ -946,7 +955,7 @@ public class NativeAnimatedNodeTraversalTest {
mNativeAnimatedNodesManager.addAnimatedEventToView(
viewTag,
"topScroll",
"onScroll",
JavaOnlyMap.of(
"animatedValueTag", 1, "nativeEventPath", JavaOnlyArray.of("contentOffset", "y")));
@@ -999,7 +1008,7 @@ public class NativeAnimatedNodeTraversalTest {
public Object answer(InvocationOnMock invocation) throws Throwable {
return MapBuilder.of(
"customDirectEventTypes",
MapBuilder.of("topScroll", MapBuilder.of("registrationName", "onScroll")));
MapBuilder.of("onScroll", MapBuilder.of("registrationName", "onScroll")));
}
});
mNativeAnimatedNodesManager = new NativeAnimatedNodesManager(mReactApplicationContextMock);
@@ -1024,7 +1033,7 @@ public class NativeAnimatedNodeTraversalTest {
@Test
public void testRestoreDefaultProps() {
int viewTag = 1000;
int viewTag = 1001; // restoreDefaultProps not called in Fabric, make sure it's a non-Fabric tag
int propsNodeTag = 3;
mNativeAnimatedNodesManager.createAnimatedNode(
1, JavaOnlyMap.of("type", "value", "value", 1d, "offset", 0d));