From 7bb7a6037bd78bbfa6d9e8499973ea921e9c70e1 Mon Sep 17 00:00:00 2001 From: Soe Lynn Date: Tue, 13 Aug 2024 20:12:48 -0700 Subject: [PATCH] Back out "Fixes NSDataBigString length calculation" (#46011) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46011 Backing out D58561775 in the meantime while we are trying to do proper fix in Hermes engine D61058869 Changelog: [Internal] Temporarily revert this diff https://github.com/facebook/react-native/pull/44900 while we wait for https://github.com/facebook/react-native/pull/45966 to land Reviewed By: makovkastar Differential Revision: D61246120 fbshipit-source-id: 8c205efe9d29cd34f24676c4a48d55f0493d73ab --- packages/react-native/React/CxxBridge/NSDataBigString.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native/React/CxxBridge/NSDataBigString.mm b/packages/react-native/React/CxxBridge/NSDataBigString.mm index 1c26bae624f..620d97ecf3b 100644 --- a/packages/react-native/React/CxxBridge/NSDataBigString.mm +++ b/packages/react-native/React/CxxBridge/NSDataBigString.mm @@ -34,8 +34,8 @@ static NSData *ensureNullTerminated(NSData *source) NSDataBigString::NSDataBigString(NSData *data) { + m_length = [data length]; m_data = ensureNullTerminated(data); - m_length = MAX([m_data length], 1) - 1; } } // namespace facebook::react