From 7b7b538d6b3e5002c03f8b4ebbeaab4792ed8ae7 Mon Sep 17 00:00:00 2001 From: Andrew Datsenko Date: Mon, 23 Jun 2025 04:25:59 -0700 Subject: [PATCH] fix cmake empty spaces and naming (#52186) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/52186 Changelog: [Internal] Minor fixes to spacing in cmake files and naming inconsistency Reviewed By: cortinico Differential Revision: D77141854 fbshipit-source-id: d1e12e571dbc0f7630d9d38faad7b22d0833dd2f --- .../fantomtestspecificmethods/CMakeLists.txt | 4 ++-- .../nativemodule/intersectionobserver/CMakeLists.txt | 4 ++-- .../nativemodule/mutationobserver/CMakeLists.txt | 12 ++++++------ .../renderer/observers/intersection/CMakeLists.txt | 4 ++-- .../react/renderer/observers/mutation/CMakeLists.txt | 4 ++-- .../react/coremodules/CMakeLists.txt | 8 ++++---- .../react/renderer/scheduler/CMakeLists.txt | 8 ++++---- 7 files changed, 22 insertions(+), 22 deletions(-) diff --git a/packages/react-native/ReactCommon/react/nativemodule/fantomtestspecificmethods/CMakeLists.txt b/packages/react-native/ReactCommon/react/nativemodule/fantomtestspecificmethods/CMakeLists.txt index 31cdedc8ea0..7505729b340 100644 --- a/packages/react-native/ReactCommon/react/nativemodule/fantomtestspecificmethods/CMakeLists.txt +++ b/packages/react-native/ReactCommon/react/nativemodule/fantomtestspecificmethods/CMakeLists.txt @@ -8,8 +8,8 @@ set(CMAKE_VERBOSE_MAKEFILE on) include(${REACT_COMMON_DIR}/cmake-utils/react-native-flags.cmake) -file(GLOB react_nativemodule_webperformance_SRC CONFIGURE_DEPENDS *.cpp internal/*.cpp) -add_library(react_nativemodule_fantomspecificmethods OBJECT ${react_nativemodule_webperformance_SRC}) +file(GLOB react_nativemodule_fantomspecificmethods_SRC CONFIGURE_DEPENDS *.cpp internal/*.cpp) +add_library(react_nativemodule_fantomspecificmethods OBJECT ${react_nativemodule_fantomspecificmethods_SRC}) target_include_directories(react_nativemodule_fantomspecificmethods PUBLIC ${REACT_COMMON_DIR}) target_include_directories(react_nativemodule_fantomspecificmethods PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/internal) diff --git a/packages/react-native/ReactCommon/react/nativemodule/intersectionobserver/CMakeLists.txt b/packages/react-native/ReactCommon/react/nativemodule/intersectionobserver/CMakeLists.txt index d67c4abf2bd..caceb4cb9f1 100644 --- a/packages/react-native/ReactCommon/react/nativemodule/intersectionobserver/CMakeLists.txt +++ b/packages/react-native/ReactCommon/react/nativemodule/intersectionobserver/CMakeLists.txt @@ -8,8 +8,8 @@ set(CMAKE_VERBOSE_MAKEFILE on) include(${REACT_COMMON_DIR}/cmake-utils/react-native-flags.cmake) -file(GLOB react_nativemodule_webperformance_SRC CONFIGURE_DEPENDS *.cpp) -add_library(react_nativemodule_intersectionobserver OBJECT ${react_nativemodule_webperformance_SRC}) +file(GLOB react_nativemodule_intersectionobserver_SRC CONFIGURE_DEPENDS *.cpp) +add_library(react_nativemodule_intersectionobserver OBJECT ${react_nativemodule_intersectionobserver_SRC}) target_include_directories(react_nativemodule_intersectionobserver PUBLIC ${REACT_COMMON_DIR}) diff --git a/packages/react-native/ReactCommon/react/nativemodule/mutationobserver/CMakeLists.txt b/packages/react-native/ReactCommon/react/nativemodule/mutationobserver/CMakeLists.txt index 65be719c3c5..ec75f853034 100644 --- a/packages/react-native/ReactCommon/react/nativemodule/mutationobserver/CMakeLists.txt +++ b/packages/react-native/ReactCommon/react/nativemodule/mutationobserver/CMakeLists.txt @@ -5,14 +5,14 @@ cmake_minimum_required(VERSION 3.13) set(CMAKE_VERBOSE_MAKEFILE on) -​​​ + include(${REACT_COMMON_DIR}/cmake-utils/react-native-flags.cmake) -​​​ -file(GLOB react_nativemodule_webperformance_SRC CONFIGURE_DEPENDS *.cpp) -add_library(react_nativemodule_mutationobserver OBJECT ${react_nativemodule_webperformance_SRC}) -​​​ + +file(GLOB react_nativemodule_mutationobserver_SRC CONFIGURE_DEPENDS *.cpp) +add_library(react_nativemodule_mutationobserver OBJECT ${react_nativemodule_mutationobserver_SRC}) + target_include_directories(react_nativemodule_mutationobserver PUBLIC ${REACT_COMMON_DIR}) -​​​ + target_link_libraries(react_nativemodule_mutationobserver react_codegen_rncore react_renderer_bridging diff --git a/packages/react-native/ReactCommon/react/renderer/observers/intersection/CMakeLists.txt b/packages/react-native/ReactCommon/react/renderer/observers/intersection/CMakeLists.txt index 96cf0c7c639..62e0229cf62 100644 --- a/packages/react-native/ReactCommon/react/renderer/observers/intersection/CMakeLists.txt +++ b/packages/react-native/ReactCommon/react/renderer/observers/intersection/CMakeLists.txt @@ -8,8 +8,8 @@ set(CMAKE_VERBOSE_MAKEFILE on) include(${REACT_COMMON_DIR}/cmake-utils/react-native-flags.cmake) -file(GLOB react_nativemodule_webperformance_SRC CONFIGURE_DEPENDS *.cpp) -add_library(react_renderer_observers_intersection OBJECT ${react_nativemodule_webperformance_SRC}) +file(GLOB react_renderer_observers_intersection_SRC CONFIGURE_DEPENDS *.cpp) +add_library(react_renderer_observers_intersection OBJECT ${react_renderer_observers_intersection_SRC}) target_include_directories(react_renderer_observers_intersection PUBLIC ${REACT_COMMON_DIR}) diff --git a/packages/react-native/ReactCommon/react/renderer/observers/mutation/CMakeLists.txt b/packages/react-native/ReactCommon/react/renderer/observers/mutation/CMakeLists.txt index 24feb65c4f5..c65739a00f8 100644 --- a/packages/react-native/ReactCommon/react/renderer/observers/mutation/CMakeLists.txt +++ b/packages/react-native/ReactCommon/react/renderer/observers/mutation/CMakeLists.txt @@ -8,8 +8,8 @@ set(CMAKE_VERBOSE_MAKEFILE on) include(${REACT_COMMON_DIR}/cmake-utils/react-native-flags.cmake) -file(GLOB react_nativemodule_webperformance_SRC CONFIGURE_DEPENDS *.cpp) -add_library(react_renderer_observers_mutation OBJECT ${react_nativemodule_webperformance_SRC}) +file(GLOB react_renderer_observers_mutation_SRC CONFIGURE_DEPENDS *.cpp) +add_library(react_renderer_observers_mutation OBJECT ${react_renderer_observers_mutation_SRC}) target_include_directories(react_renderer_observers_mutation PUBLIC ${REACT_COMMON_DIR}) diff --git a/packages/react-native/ReactCxxPlatform/react/coremodules/CMakeLists.txt b/packages/react-native/ReactCxxPlatform/react/coremodules/CMakeLists.txt index 25132961953..401bb8616aa 100644 --- a/packages/react-native/ReactCxxPlatform/react/coremodules/CMakeLists.txt +++ b/packages/react-native/ReactCxxPlatform/react/coremodules/CMakeLists.txt @@ -5,14 +5,14 @@ cmake_minimum_required(VERSION 3.13) set(CMAKE_VERBOSE_MAKEFILE on) -​​​ + include(${REACT_COMMON_DIR}/cmake-utils/react-native-flags.cmake) -​​​ + file(GLOB react_cxx_platform_react_coremodules_SRC CONFIGURE_DEPENDS *.cpp) add_library(react_cxx_platform_react_coremodules OBJECT ${react_cxx_platform_react_coremodules_SRC}) -​​​ + target_include_directories(react_cxx_platform_react_coremodules PUBLIC ${REACT_CXX_PLATFORM_DIR}) -​​​ + target_link_libraries(react_cxx_platform_react_coremodules folly_runtime jsi diff --git a/packages/react-native/ReactCxxPlatform/react/renderer/scheduler/CMakeLists.txt b/packages/react-native/ReactCxxPlatform/react/renderer/scheduler/CMakeLists.txt index e750683d5d3..0f47b39da82 100644 --- a/packages/react-native/ReactCxxPlatform/react/renderer/scheduler/CMakeLists.txt +++ b/packages/react-native/ReactCxxPlatform/react/renderer/scheduler/CMakeLists.txt @@ -5,14 +5,14 @@ cmake_minimum_required(VERSION 3.13) set(CMAKE_VERBOSE_MAKEFILE on) -​​​ + include(${REACT_COMMON_DIR}/cmake-utils/react-native-flags.cmake) -​​​ + file(GLOB react_cxx_platform_react_renderer_scheduler_SRC CONFIGURE_DEPENDS *.cpp) add_library(react_cxx_platform_react_renderer_scheduler OBJECT ${react_cxx_platform_react_renderer_scheduler_SRC}) -​​​ + target_include_directories(react_cxx_platform_react_renderer_scheduler PUBLIC ${REACT_CXX_PLATFORM_DIR}) -​​​ + target_link_libraries(react_cxx_platform_react_renderer_scheduler react_renderer_mounting react_renderer_scheduler