From 7b302dc8bd4c806efd239c70ade26f2bc1a05c4d Mon Sep 17 00:00:00 2001 From: Fabrizio Cucci Date: Tue, 2 Apr 2024 16:17:39 -0700 Subject: [PATCH] Kotlinify RequestOnlyHandler (#43743) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/43743 Changelog: [Internal] As part of the Sustainability Week (see [post](https://fb.workplace.com/groups/251759413609061/permalink/742797531171911/)). Reviewed By: tdn120 Differential Revision: D55588782 fbshipit-source-id: 89f15fb55eaa338be97c938d6b23c3e77ce610f0 --- .../RequestOnlyHandler.java | 23 ------------------- .../packagerconnection/RequestOnlyHandler.kt | 19 +++++++++++++++ 2 files changed, 19 insertions(+), 23 deletions(-) delete mode 100644 packages/react-native/ReactAndroid/src/main/java/com/facebook/react/packagerconnection/RequestOnlyHandler.java create mode 100644 packages/react-native/ReactAndroid/src/main/java/com/facebook/react/packagerconnection/RequestOnlyHandler.kt diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/packagerconnection/RequestOnlyHandler.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/packagerconnection/RequestOnlyHandler.java deleted file mode 100644 index ef66ca2519c..00000000000 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/packagerconnection/RequestOnlyHandler.java +++ /dev/null @@ -1,23 +0,0 @@ -/* - * Copyright (c) Meta Platforms, Inc. and affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - */ - -package com.facebook.react.packagerconnection; - -import androidx.annotation.Nullable; -import com.facebook.common.logging.FLog; -import com.facebook.infer.annotation.Nullsafe; - -@Nullsafe(Nullsafe.Mode.LOCAL) -public abstract class RequestOnlyHandler implements RequestHandler { - private static final String TAG = JSPackagerClient.class.getSimpleName(); - - public abstract void onRequest(@Nullable Object params, Responder responder); - - public final void onNotification(@Nullable Object params) { - FLog.e(TAG, "Notification is not supported"); - } -} diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/packagerconnection/RequestOnlyHandler.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/packagerconnection/RequestOnlyHandler.kt new file mode 100644 index 00000000000..a4239caa071 --- /dev/null +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/packagerconnection/RequestOnlyHandler.kt @@ -0,0 +1,19 @@ +/* + * Copyright (c) Meta Platforms, Inc. and affiliates. + * + * This source code is licensed under the MIT license found in the + * LICENSE file in the root directory of this source tree. + */ + +package com.facebook.react.packagerconnection + +import com.facebook.common.logging.FLog + +public abstract class RequestOnlyHandler : RequestHandler { + + override abstract fun onRequest(params: Any?, responder: Responder) + + override final fun onNotification(params: Any?) { + FLog.e(JSPackagerClient::class.java.simpleName, "Notification is not supported") + } +}