From 7a81fd7a8a96bd602f27c5cbd28c63ca84c27312 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rub=C3=A9n=20Norte?= Date: Thu, 5 Dec 2024 17:06:11 -0800 Subject: [PATCH] Migrate all feature flags to pragmas (#48098) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48098 Changelog: [internal] TSIA. No more manual feature flag overrides in Fantom tests :D Reviewed By: sammy-SC Differential Revision: D66760120 fbshipit-source-id: a0493d6ca57f4fdad33a0667e3af99ed0f0b66ca --- .../ReactFabricPublicInstance-Legacy-itest.js | 1 + .../ReactFabricPublicInstance-Modern-itest.js | 2 +- .../__tests__/setUpFeatureFlags.js | 16 ---------------- .../__tests__/IntersectionObserver-itest.js | 2 +- .../__tests__/setUpFeatureFlags.js | 16 ---------------- .../__tests__/MutationObserver-itest.js | 2 +- .../__tests__/setUpFeatureFlags.js | 16 ---------------- 7 files changed, 4 insertions(+), 51 deletions(-) delete mode 100644 packages/react-native/Libraries/ReactNative/ReactFabricPublicInstance/__tests__/setUpFeatureFlags.js delete mode 100644 packages/react-native/src/private/webapis/intersectionobserver/__tests__/setUpFeatureFlags.js delete mode 100644 packages/react-native/src/private/webapis/mutationobserver/__tests__/setUpFeatureFlags.js diff --git a/packages/react-native/Libraries/ReactNative/ReactFabricPublicInstance/__tests__/ReactFabricPublicInstance-Legacy-itest.js b/packages/react-native/Libraries/ReactNative/ReactFabricPublicInstance/__tests__/ReactFabricPublicInstance-Legacy-itest.js index 6c1477aa7b5..1970056a68f 100644 --- a/packages/react-native/Libraries/ReactNative/ReactFabricPublicInstance/__tests__/ReactFabricPublicInstance-Legacy-itest.js +++ b/packages/react-native/Libraries/ReactNative/ReactFabricPublicInstance/__tests__/ReactFabricPublicInstance-Legacy-itest.js @@ -7,6 +7,7 @@ * @flow strict-local * @format * @oncall react_native + * @fantom_flags enableAccessToHostTreeInFabric:false */ import setUpReactFabricPublicInstanceFantomTests from './setUpReactFabricPublicInstanceFantomTests'; diff --git a/packages/react-native/Libraries/ReactNative/ReactFabricPublicInstance/__tests__/ReactFabricPublicInstance-Modern-itest.js b/packages/react-native/Libraries/ReactNative/ReactFabricPublicInstance/__tests__/ReactFabricPublicInstance-Modern-itest.js index 9f66d43eacc..f6ca539c85b 100644 --- a/packages/react-native/Libraries/ReactNative/ReactFabricPublicInstance/__tests__/ReactFabricPublicInstance-Modern-itest.js +++ b/packages/react-native/Libraries/ReactNative/ReactFabricPublicInstance/__tests__/ReactFabricPublicInstance-Modern-itest.js @@ -7,9 +7,9 @@ * @flow strict-local * @format * @oncall react_native + * @fantom_flags enableAccessToHostTreeInFabric:true */ -import './setUpFeatureFlags'; import setUpReactFabricPublicInstanceFantomTests from './setUpReactFabricPublicInstanceFantomTests'; setUpReactFabricPublicInstanceFantomTests({isModern: true}); diff --git a/packages/react-native/Libraries/ReactNative/ReactFabricPublicInstance/__tests__/setUpFeatureFlags.js b/packages/react-native/Libraries/ReactNative/ReactFabricPublicInstance/__tests__/setUpFeatureFlags.js deleted file mode 100644 index a5a75c44ac4..00000000000 --- a/packages/react-native/Libraries/ReactNative/ReactFabricPublicInstance/__tests__/setUpFeatureFlags.js +++ /dev/null @@ -1,16 +0,0 @@ -/** - * Copyright (c) Meta Platforms, Inc. and affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - * - * @flow strict-local - * @format - * @oncall react_native - */ - -import * as ReactNativeFeatureFlags from '../../../../src/private/featureflags/ReactNativeFeatureFlags'; - -ReactNativeFeatureFlags.override({ - enableAccessToHostTreeInFabric: () => true, -}); diff --git a/packages/react-native/src/private/webapis/intersectionobserver/__tests__/IntersectionObserver-itest.js b/packages/react-native/src/private/webapis/intersectionobserver/__tests__/IntersectionObserver-itest.js index f034867e8fa..e6687af4c8e 100644 --- a/packages/react-native/src/private/webapis/intersectionobserver/__tests__/IntersectionObserver-itest.js +++ b/packages/react-native/src/private/webapis/intersectionobserver/__tests__/IntersectionObserver-itest.js @@ -7,6 +7,7 @@ * @flow strict-local * @format * @oncall react_native + * @fantom_flags enableAccessToHostTreeInFabric:true */ /* eslint-disable lint/sort-imports */ @@ -19,7 +20,6 @@ import ReactNativeElement from '../../dom/nodes/ReactNativeElement'; import IntersectionObserverEntry from '../IntersectionObserverEntry'; import * as React from 'react'; -import './setUpFeatureFlags'; import '../../../../../Libraries/Core/InitializeCore.js'; import ScrollView from '../../../../../Libraries/Components/ScrollView/ScrollView'; diff --git a/packages/react-native/src/private/webapis/intersectionobserver/__tests__/setUpFeatureFlags.js b/packages/react-native/src/private/webapis/intersectionobserver/__tests__/setUpFeatureFlags.js deleted file mode 100644 index 5af0f6f71dd..00000000000 --- a/packages/react-native/src/private/webapis/intersectionobserver/__tests__/setUpFeatureFlags.js +++ /dev/null @@ -1,16 +0,0 @@ -/** - * Copyright (c) Meta Platforms, Inc. and affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - * - * @flow strict-local - * @format - * @oncall react_native - */ - -import * as ReactNativeFeatureFlags from '../../../featureflags/ReactNativeFeatureFlags'; - -ReactNativeFeatureFlags.override({ - enableAccessToHostTreeInFabric: () => true, -}); diff --git a/packages/react-native/src/private/webapis/mutationobserver/__tests__/MutationObserver-itest.js b/packages/react-native/src/private/webapis/mutationobserver/__tests__/MutationObserver-itest.js index d14ec74a2dc..695ea2c608f 100644 --- a/packages/react-native/src/private/webapis/mutationobserver/__tests__/MutationObserver-itest.js +++ b/packages/react-native/src/private/webapis/mutationobserver/__tests__/MutationObserver-itest.js @@ -7,6 +7,7 @@ * @flow strict-local * @format * @oncall react_native + * @fantom_flags enableAccessToHostTreeInFabric:true */ import type MutationObserverType from '../MutationObserver'; @@ -18,7 +19,6 @@ import ReactNativeElement from '../../dom/nodes/ReactNativeElement'; import nullthrows from 'nullthrows'; import * as React from 'react'; -import './setUpFeatureFlags'; import '../../../../../Libraries/Core/InitializeCore.js'; declare const MutationObserver: Class; diff --git a/packages/react-native/src/private/webapis/mutationobserver/__tests__/setUpFeatureFlags.js b/packages/react-native/src/private/webapis/mutationobserver/__tests__/setUpFeatureFlags.js deleted file mode 100644 index 5af0f6f71dd..00000000000 --- a/packages/react-native/src/private/webapis/mutationobserver/__tests__/setUpFeatureFlags.js +++ /dev/null @@ -1,16 +0,0 @@ -/** - * Copyright (c) Meta Platforms, Inc. and affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - * - * @flow strict-local - * @format - * @oncall react_native - */ - -import * as ReactNativeFeatureFlags from '../../../featureflags/ReactNativeFeatureFlags'; - -ReactNativeFeatureFlags.override({ - enableAccessToHostTreeInFabric: () => true, -});