Remove offscreen image request downgrading feature flag (#57226)

Summary:
Pull Request resolved: https://github.com/react/react-native/pull/57226

This removes the experimental `enableImageRequestDowngradingForNonVisibleImages` feature flag and backs out the behavior it gated. When enabled, `ImageShadowNode` downgraded image requests to prefetch priority for images that layout determined did not intersect the viewport — threading an `ImageRequestPriority` through `ImageRequestParams` and the Apple image managers, and propagating per-node viewport frames during Yoga layout via `experimental_layoutOrigin`/`experimental_layoutFrame` on `LayoutContext`.

The flag defaulted to off and was never enabled in a release, and the gated behavior did not deliver the expected improvement, so the feature is removed entirely: `<Image>` once again always requests at immediate priority. This deletes the feature flag, the `ImageRequestPriority` enum and the `ImageRequestParams::priority` field, the priority parameter on `RCTImageManager`/`RCTSyncImageManager`/`RCTImageManagerProtocol`, the `experimental_layout*` `LayoutContext` fields and their Yoga propagation, the iOS request-priority debug overlay, and the associated Fantom test scaffolding. The generated feature-flag sources and the C++ API snapshots are regenerated accordingly.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D108411690

fbshipit-source-id: 1538ec699ed2857f3d3154d666fac43a1dc64cd1
This commit is contained in:
Samuel Susla authored and meta-codesync[bot] committed 2026-06-17 05:26:37 -07:00
1 parent 0cdb59f1b4
commit 79adce3942
53 files changed
+105 -1034

No files matched your search

@@ -2611,7 +2611,6 @@ class facebook::react::ImageRequestParams {
public facebook::react::Float blurRadius;
public facebook::react::Float fadeDuration;
public facebook::react::Float resizeMultiplier;
public facebook::react::ImageRequestPriority priority;
public facebook::react::ImageResizeMode resizeMode;
public facebook::react::ImageSource defaultSource;
public facebook::react::ImageSource loadingIndicatorSource;
@@ -6227,11 +6226,6 @@ enum facebook::react::HyphenationFrequency {
Normal,
}
enum facebook::react::ImageRequestPriority : int8_t {
Immediate,
Prefetch,
}
enum facebook::react::ImageResizeMode : int8_t {
Center,
Contain,
@@ -2593,7 +2593,6 @@ class facebook::react::ImageRequestParams {
public facebook::react::Float blurRadius;
public facebook::react::Float fadeDuration;
public facebook::react::Float resizeMultiplier;
public facebook::react::ImageRequestPriority priority;
public facebook::react::ImageResizeMode resizeMode;
public facebook::react::ImageSource defaultSource;
public facebook::react::ImageSource loadingIndicatorSource;
@@ -6041,11 +6040,6 @@ enum facebook::react::HyphenationFrequency {
Normal,
}
enum facebook::react::ImageRequestPriority : int8_t {
Immediate,
Prefetch,
}
enum facebook::react::ImageResizeMode : int8_t {
Center,
Contain,
@@ -2608,7 +2608,6 @@ class facebook::react::ImageRequestParams {
public facebook::react::Float blurRadius;
public facebook::react::Float fadeDuration;
public facebook::react::Float resizeMultiplier;
public facebook::react::ImageRequestPriority priority;
public facebook::react::ImageResizeMode resizeMode;
public facebook::react::ImageSource defaultSource;
public facebook::react::ImageSource loadingIndicatorSource;
@@ -6218,11 +6217,6 @@ enum facebook::react::HyphenationFrequency {
Normal,
}
enum facebook::react::ImageRequestPriority : int8_t {
Immediate,
Prefetch,
}
enum facebook::react::ImageResizeMode : int8_t {
Center,
Contain,
@@ -1201,7 +1201,7 @@ interface RCTImageLoader : public NSObject <RCTBridgeModule, RCTImageLoaderProto
}
interface RCTImageManager : public NSObject <RCTImageManagerProtocol> {
public virtual facebook::react::ImageRequest requestImage:surfaceId:priority:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId, facebook::react::ImageRequestPriority priority);
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
public virtual instancetype initWithImageLoader:(id<RCTImageLoaderWithAttributionProtocol> imageLoader);
}
@@ -1940,7 +1940,7 @@ interface RCTSwitchComponentView : public RCTViewComponentView {
}
interface RCTSyncImageManager : public NSObject <RCTImageManagerProtocol> {
public virtual facebook::react::ImageRequest requestImage:surfaceId:priority:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId, facebook::react::ImageRequestPriority priority);
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
public virtual instancetype initWithImageLoader:(id<RCTImageLoaderWithAttributionProtocol> imageLoader);
}
@@ -2871,7 +2871,7 @@ protocol RCTImageLoaderWithAttributionProtocol : public RCTImageLoaderProtocol,
}
protocol RCTImageManagerProtocol : public NSObject {
public virtual facebook::react::ImageRequest requestImage:surfaceId:priority:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId, facebook::react::ImageRequestPriority priority);
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
}
protocol RCTImageRedirectProtocol {
@@ -5009,10 +5009,9 @@ class facebook::react::ImageRequest {
class facebook::react::ImageRequestParams {
public ImageRequestParams();
public ImageRequestParams(facebook::react::Float blurRadius, facebook::react::ImageRequestPriority priority = facebook::react::ImageRequestPriority::Immediate);
public ImageRequestParams(facebook::react::Float blurRadius);
public bool operator==(const facebook::react::ImageRequestParams& rhs) const = default;
public facebook::react::Float blurRadius;
public facebook::react::ImageRequestPriority priority;
}
class facebook::react::ImageResponse {
@@ -8370,11 +8369,6 @@ enum facebook::react::HyphenationFrequency {
Normal,
}
enum facebook::react::ImageRequestPriority : int8_t {
Immediate,
Prefetch,
}
enum facebook::react::ImageResizeMode : int8_t {
Center,
Contain,
@@ -1199,7 +1199,7 @@ interface RCTImageLoader : public NSObject <RCTBridgeModule, RCTImageLoaderProto
}
interface RCTImageManager : public NSObject <RCTImageManagerProtocol> {
public virtual facebook::react::ImageRequest requestImage:surfaceId:priority:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId, facebook::react::ImageRequestPriority priority);
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
public virtual instancetype initWithImageLoader:(id<RCTImageLoaderWithAttributionProtocol> imageLoader);
}
@@ -1929,7 +1929,7 @@ interface RCTSwitchComponentView : public RCTViewComponentView {
}
interface RCTSyncImageManager : public NSObject <RCTImageManagerProtocol> {
public virtual facebook::react::ImageRequest requestImage:surfaceId:priority:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId, facebook::react::ImageRequestPriority priority);
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
public virtual instancetype initWithImageLoader:(id<RCTImageLoaderWithAttributionProtocol> imageLoader);
}
@@ -2859,7 +2859,7 @@ protocol RCTImageLoaderWithAttributionProtocol : public RCTImageLoaderProtocol,
}
protocol RCTImageManagerProtocol : public NSObject {
public virtual facebook::react::ImageRequest requestImage:surfaceId:priority:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId, facebook::react::ImageRequestPriority priority);
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
}
protocol RCTImageRedirectProtocol {
@@ -4980,10 +4980,9 @@ class facebook::react::ImageRequest {
class facebook::react::ImageRequestParams {
public ImageRequestParams();
public ImageRequestParams(facebook::react::Float blurRadius, facebook::react::ImageRequestPriority priority = facebook::react::ImageRequestPriority::Immediate);
public ImageRequestParams(facebook::react::Float blurRadius);
public bool operator==(const facebook::react::ImageRequestParams& rhs) const = default;
public facebook::react::Float blurRadius;
public facebook::react::ImageRequestPriority priority;
}
class facebook::react::ImageResponse {
@@ -8212,11 +8211,6 @@ enum facebook::react::HyphenationFrequency {
Normal,
}
enum facebook::react::ImageRequestPriority : int8_t {
Immediate,
Prefetch,
}
enum facebook::react::ImageResizeMode : int8_t {
Center,
Contain,
@@ -1201,7 +1201,7 @@ interface RCTImageLoader : public NSObject <RCTBridgeModule, RCTImageLoaderProto
}
interface RCTImageManager : public NSObject <RCTImageManagerProtocol> {
public virtual facebook::react::ImageRequest requestImage:surfaceId:priority:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId, facebook::react::ImageRequestPriority priority);
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
public virtual instancetype initWithImageLoader:(id<RCTImageLoaderWithAttributionProtocol> imageLoader);
}
@@ -1940,7 +1940,7 @@ interface RCTSwitchComponentView : public RCTViewComponentView {
}
interface RCTSyncImageManager : public NSObject <RCTImageManagerProtocol> {
public virtual facebook::react::ImageRequest requestImage:surfaceId:priority:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId, facebook::react::ImageRequestPriority priority);
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
public virtual instancetype initWithImageLoader:(id<RCTImageLoaderWithAttributionProtocol> imageLoader);
}
@@ -2871,7 +2871,7 @@ protocol RCTImageLoaderWithAttributionProtocol : public RCTImageLoaderProtocol,
}
protocol RCTImageManagerProtocol : public NSObject {
public virtual facebook::react::ImageRequest requestImage:surfaceId:priority:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId, facebook::react::ImageRequestPriority priority);
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
}
protocol RCTImageRedirectProtocol {
@@ -5006,10 +5006,9 @@ class facebook::react::ImageRequest {
class facebook::react::ImageRequestParams {
public ImageRequestParams();
public ImageRequestParams(facebook::react::Float blurRadius, facebook::react::ImageRequestPriority priority = facebook::react::ImageRequestPriority::Immediate);
public ImageRequestParams(facebook::react::Float blurRadius);
public bool operator==(const facebook::react::ImageRequestParams& rhs) const = default;
public facebook::react::Float blurRadius;
public facebook::react::ImageRequestPriority priority;
}
class facebook::react::ImageResponse {
@@ -8361,11 +8360,6 @@ enum facebook::react::HyphenationFrequency {
Normal,
}
enum facebook::react::ImageRequestPriority : int8_t {
Immediate,
Prefetch,
}
enum facebook::react::ImageResizeMode : int8_t {
Center,
Contain,
@@ -4589,11 +4589,6 @@ enum facebook::react::HyphenationFrequency {
Normal,
}
enum facebook::react::ImageRequestPriority : int8_t {
Immediate,
Prefetch,
}
enum facebook::react::ImageResizeMode : int8_t {
Center,
Contain,
@@ -4443,11 +4443,6 @@ enum facebook::react::HyphenationFrequency {
Normal,
}
enum facebook::react::ImageRequestPriority : int8_t {
Immediate,
Prefetch,
}
enum facebook::react::ImageResizeMode : int8_t {
Center,
Contain,
@@ -4580,11 +4580,6 @@ enum facebook::react::HyphenationFrequency {
Normal,
}
enum facebook::react::ImageRequestPriority : int8_t {
Immediate,
Prefetch,
}
enum facebook::react::ImageResizeMode : int8_t {
Center,
Contain,