From 79a562960dbe5de3b99a2ca4531acc8dab620c0e Mon Sep 17 00:00:00 2001 From: Gregory Moskaliuk Date: Wed, 21 Oct 2026 12:16:37 -0700 Subject: [PATCH] Use a static cast for View nodes when building ShadowView layout metrics (#59290) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: `ShadowView`'s constructor reads the node's layout metrics through `layoutMetricsFromShadowNode`, which uses `dynamic_cast` to find out whether the node has layout. The differ builds a `ShadowView` for every child it visits when it slices a node's children, so this runs for every visited node on every commit, including the per-frame commits that update a ScrollView's content offset. **Current behavior.** Every call pays for a `dynamic_cast`, which walks the type's inheritance information at runtime; for a `View`, the node's type is `ConcreteViewShadowNode<...>`, several levels below `LayoutableShadowNode`. In the profiles below, `__dynamic_cast` takes 19–21% of the differ's time while scrolling. **With this change.** A node with the `ViewKind` trait takes a `static_cast`. `ShadowNodeTraits` documents `ViewKind` as "Inherits `ConcreteViewShadowNode<>` template", and `ConcreteViewShadowNode::BaseTraits()` is the only place that sets it; `ConcreteViewShadowNode` derives from `YogaLayoutableShadowNode`, so such a node is always a `LayoutableShadowNode` and the result is the same as the `dynamic_cast`'s. Other nodes (for example raw text) keep the checked cast. Core code already relies on the trait the same way: `PointerEventsProcessor`, `YogaLayoutableShadowNode` and `LayoutAnimationKeyFrameManager` check `ViewKind` and then `static_cast` the props to `ViewProps`. ## Changelog: [GENERAL] [CHANGED] - Building a `ShadowView` for a View node no longer uses a `dynamic_cast` to read its layout metrics Pull Request resolved: https://github.com/react/react-native/pull/59290 Test Plan: - `clang-format --dry-run --Werror` on the changed file passes. - `yarn fantom` (full suite, with the tester rebuilt from this change): 188 test suites and 3,288 tests pass (108 skipped by their configuration). - RNTester built with `xcodebuild` in Release and run on a physical iPhone 15 Pro (iOS 26.6.1). - **Measurement.** The two arms are the same binary with the change switched by a launch argument, in the order before, after, after, before. Interactions were driven by [Argent](https://github.com/software-mansion/argent) on the physical iPhone, under Instruments' Time Profiler. Values are main-thread sampled time per launch inside `calculateShadowViewMutations` (the differ), averaged over the 2 launches of each arm. iPhone 15 Pro, Release: | RNTester screen, 10 flings (Playground chat: 40) | differ before | this PR | change | `__dynamic_cast` in the differ, before → this PR | |---|--:|--:|--:|--:| | Playground, chat of 500 messages | 338 ms | 280 ms | −17% | 64 → 14 ms | | FlatList basic | 187 ms | 150 ms | −20% | 38 → 0 ms | | SectionList scrollable | 296 ms | 290 ms | −2% | 63 → 10 ms | SectionList is mostly bound by the JS thread and renders a different amount in each launch, so its differ time varied from 237 to 356 ms between launches of the same arm; the time in `__dynamic_cast` is the stable number there. The differ is 7–9% of the main thread's time on these screens. Mounting 1000 views five times took 24–31 ms of differ time per launch in both arms, too little for the profiler's 1 ms samples to show a difference. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Reviewed By: christophpurrer Differential Revision: D126687891 Pulled By: javache fbshipit-source-id: 83440573d6fdb644843f3961a8e8ceade7875624 --- .../react/renderer/core/LayoutableShadowNode.h | 7 ++++++- .../ReactCommon/react/renderer/core/ShadowNode.h | 10 ++++++++++ .../ReactCommon/react/renderer/mounting/ShadowView.cpp | 3 +-- scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api | 2 ++ .../api-snapshots/ReactAndroidFrameworksCxx.api | 2 ++ .../cxx-api/api-snapshots/ReactAndroidNewarchCxx.api | 2 ++ .../cxx-api/api-snapshots/ReactAndroidReleaseCxx.api | 2 ++ scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api | 2 ++ .../cxx-api/api-snapshots/ReactAppleFrameworksCxx.api | 2 ++ scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api | 2 ++ scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api | 2 ++ scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api | 2 ++ .../cxx-api/api-snapshots/ReactCommonFrameworksCxx.api | 2 ++ .../cxx-api/api-snapshots/ReactCommonNewarchCxx.api | 2 ++ .../cxx-api/api-snapshots/ReactCommonReleaseCxx.api | 2 ++ 15 files changed, 41 insertions(+), 3 deletions(-) diff --git a/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.h b/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.h index 8655de5f396..2fdf36483d8 100644 --- a/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.h +++ b/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.h @@ -117,6 +117,11 @@ class LayoutableShadowNode : public ShadowNode { */ LayoutMetrics getLayoutMetrics() const; + const LayoutableShadowNode *asLayoutable() const override + { + return this; + } + /* * Returns a transform object that represents transformations that will/should * be applied on top of regular layout metrics by mounting layer. @@ -170,7 +175,7 @@ class LayoutableShadowNode : public ShadowNode { #pragma mark - DebugStringConvertible #if RN_DEBUG_STRING_CONVERTIBLE - SharedDebugStringConvertibleList getDebugProps() const; + SharedDebugStringConvertibleList getDebugProps() const override; #endif LayoutMetrics layoutMetrics_; diff --git a/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.h b/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.h index 2426c9065fc..b21cb21b4f3 100644 --- a/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.h +++ b/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.h @@ -27,6 +27,7 @@ namespace facebook::react { class ComponentDescriptor; +class LayoutableShadowNode; struct ShadowNodeFragment; struct ShadowNodeWrapper; @@ -122,6 +123,15 @@ class ShadowNode : public Sealable, public DebugStringConvertible, public jsi::N */ virtual void completeClone(const ShadowNode & /* sourceShadowNode */, const ShadowNodeFragment & /* fragment */) {} + /** + * Returns this node as a `LayoutableShadowNode`, or `nullptr` if it isn't + * one. Cheaper than a `dynamic_cast`. + */ + virtual const LayoutableShadowNode *asLayoutable() const + { + return nullptr; + } + #pragma mark - Getters ComponentName getComponentName() const; diff --git a/packages/react-native/ReactCommon/react/renderer/mounting/ShadowView.cpp b/packages/react-native/ReactCommon/react/renderer/mounting/ShadowView.cpp index d59525e8749..1f4a7e0aa2a 100644 --- a/packages/react-native/ReactCommon/react/renderer/mounting/ShadowView.cpp +++ b/packages/react-native/ReactCommon/react/renderer/mounting/ShadowView.cpp @@ -13,8 +13,7 @@ namespace facebook::react { static LayoutMetrics layoutMetricsFromShadowNode(const ShadowNode& shadowNode) { - auto layoutableShadowNode = - dynamic_cast(&shadowNode); + auto layoutableShadowNode = shadowNode.asLayoutable(); return layoutableShadowNode != nullptr ? layoutableShadowNode->getLayoutMetrics() : EmptyLayoutMetrics; diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api index 374d6ab4e82..333251a9a6e 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api @@ -1719,6 +1719,7 @@ class facebook::react::LayoutableShadowNode : public facebook::react::ShadowNode public virtual bool canBeTouchTarget() const; public virtual bool canChildrenBeTouchTarget() const; public virtual bool getIsLayoutClean() const = 0; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const override; public virtual facebook::react::Float baseline(const facebook::react::LayoutContext& layoutContext, facebook::react::Size size) const; public virtual facebook::react::Point getContentOriginOffset(bool includeTransform) const; public virtual facebook::react::Size measure(const facebook::react::LayoutContext& layoutContext, const facebook::react::LayoutConstraints& layoutConstraints) const; @@ -2250,6 +2251,7 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac public std::shared_ptr cloneMultiple(const std::unordered_set>& familiesToUpdate, const std::function(const facebook::react::ShadowNode& oldShadowNode, const facebook::react::ShadowNodeFragment& fragment)>& callback) const; public std::shared_ptr cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function(const facebook::react::ShadowNode& oldShadowNode)>& callback) const; public using AncestorList = std::vector, int>>; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const; public virtual void appendChild(const std::shared_ptr& child); public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&); public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr& newChild, size_t suggestedIndex = std::numeric_limits::max()); diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api index b15017d872b..15895518dad 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api @@ -2595,6 +2595,7 @@ class facebook::react::LayoutableShadowNode : public facebook::react::ShadowNode public virtual bool canBeTouchTarget() const; public virtual bool canChildrenBeTouchTarget() const; public virtual bool getIsLayoutClean() const = 0; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const override; public virtual facebook::react::Float baseline(const facebook::react::LayoutContext& layoutContext, facebook::react::Size size) const; public virtual facebook::react::Point getContentOriginOffset(bool includeTransform) const; public virtual facebook::react::Size measure(const facebook::react::LayoutContext& layoutContext, const facebook::react::LayoutConstraints& layoutConstraints) const; @@ -3642,6 +3643,7 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac public std::shared_ptr cloneMultiple(const std::unordered_set>& familiesToUpdate, const std::function(const facebook::react::ShadowNode& oldShadowNode, const facebook::react::ShadowNodeFragment& fragment)>& callback) const; public std::shared_ptr cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function(const facebook::react::ShadowNode& oldShadowNode)>& callback) const; public using AncestorList = std::vector, int>>; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const; public virtual void appendChild(const std::shared_ptr& child); public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&); public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr& newChild, size_t suggestedIndex = std::numeric_limits::max()); diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api index ceafbff61af..b700de9a234 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api @@ -1718,6 +1718,7 @@ class facebook::react::LayoutableShadowNode : public facebook::react::ShadowNode public virtual bool canBeTouchTarget() const; public virtual bool canChildrenBeTouchTarget() const; public virtual bool getIsLayoutClean() const = 0; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const override; public virtual facebook::react::Float baseline(const facebook::react::LayoutContext& layoutContext, facebook::react::Size size) const; public virtual facebook::react::Point getContentOriginOffset(bool includeTransform) const; public virtual facebook::react::Size measure(const facebook::react::LayoutContext& layoutContext, const facebook::react::LayoutConstraints& layoutConstraints) const; @@ -2243,6 +2244,7 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac public std::shared_ptr cloneMultiple(const std::unordered_set>& familiesToUpdate, const std::function(const facebook::react::ShadowNode& oldShadowNode, const facebook::react::ShadowNodeFragment& fragment)>& callback) const; public std::shared_ptr cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function(const facebook::react::ShadowNode& oldShadowNode)>& callback) const; public using AncestorList = std::vector, int>>; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const; public virtual void appendChild(const std::shared_ptr& child); public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&); public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr& newChild, size_t suggestedIndex = std::numeric_limits::max()); diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api index ceafbff61af..b700de9a234 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api @@ -1718,6 +1718,7 @@ class facebook::react::LayoutableShadowNode : public facebook::react::ShadowNode public virtual bool canBeTouchTarget() const; public virtual bool canChildrenBeTouchTarget() const; public virtual bool getIsLayoutClean() const = 0; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const override; public virtual facebook::react::Float baseline(const facebook::react::LayoutContext& layoutContext, facebook::react::Size size) const; public virtual facebook::react::Point getContentOriginOffset(bool includeTransform) const; public virtual facebook::react::Size measure(const facebook::react::LayoutContext& layoutContext, const facebook::react::LayoutConstraints& layoutConstraints) const; @@ -2243,6 +2244,7 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac public std::shared_ptr cloneMultiple(const std::unordered_set>& familiesToUpdate, const std::function(const facebook::react::ShadowNode& oldShadowNode, const facebook::react::ShadowNodeFragment& fragment)>& callback) const; public std::shared_ptr cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function(const facebook::react::ShadowNode& oldShadowNode)>& callback) const; public using AncestorList = std::vector, int>>; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const; public virtual void appendChild(const std::shared_ptr& child); public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&); public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr& newChild, size_t suggestedIndex = std::numeric_limits::max()); diff --git a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api index cd7cd6ba81f..0afcd995b2f 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api @@ -4002,6 +4002,7 @@ class facebook::react::LayoutableShadowNode : public facebook::react::ShadowNode public virtual bool canBeTouchTarget() const; public virtual bool canChildrenBeTouchTarget() const; public virtual bool getIsLayoutClean() const = 0; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const override; public virtual facebook::react::Float baseline(const facebook::react::LayoutContext& layoutContext, facebook::react::Size size) const; public virtual facebook::react::Point getContentOriginOffset(bool includeTransform) const; public virtual facebook::react::Size measure(const facebook::react::LayoutContext& layoutContext, const facebook::react::LayoutConstraints& layoutConstraints) const; @@ -4510,6 +4511,7 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac public std::shared_ptr cloneMultiple(const std::unordered_set>& familiesToUpdate, const std::function(const facebook::react::ShadowNode& oldShadowNode, const facebook::react::ShadowNodeFragment& fragment)>& callback) const; public std::shared_ptr cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function(const facebook::react::ShadowNode& oldShadowNode)>& callback) const; public using AncestorList = std::vector, int>>; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const; public virtual void appendChild(const std::shared_ptr& child); public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&); public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr& newChild, size_t suggestedIndex = std::numeric_limits::max()); diff --git a/scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api index 86fe29de9b6..d6c96235c3e 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api @@ -4811,6 +4811,7 @@ class facebook::react::LayoutableShadowNode : public facebook::react::ShadowNode public virtual bool canBeTouchTarget() const; public virtual bool canChildrenBeTouchTarget() const; public virtual bool getIsLayoutClean() const = 0; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const override; public virtual facebook::react::Float baseline(const facebook::react::LayoutContext& layoutContext, facebook::react::Size size) const; public virtual facebook::react::Point getContentOriginOffset(bool includeTransform) const; public virtual facebook::react::Size measure(const facebook::react::LayoutContext& layoutContext, const facebook::react::LayoutConstraints& layoutConstraints) const; @@ -5849,6 +5850,7 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac public std::shared_ptr cloneMultiple(const std::unordered_set>& familiesToUpdate, const std::function(const facebook::react::ShadowNode& oldShadowNode, const facebook::react::ShadowNodeFragment& fragment)>& callback) const; public std::shared_ptr cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function(const facebook::react::ShadowNode& oldShadowNode)>& callback) const; public using AncestorList = std::vector, int>>; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const; public virtual void appendChild(const std::shared_ptr& child); public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&); public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr& newChild, size_t suggestedIndex = std::numeric_limits::max()); diff --git a/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api index aab9559c8f3..e2676272484 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api @@ -3993,6 +3993,7 @@ class facebook::react::LayoutableShadowNode : public facebook::react::ShadowNode public virtual bool canBeTouchTarget() const; public virtual bool canChildrenBeTouchTarget() const; public virtual bool getIsLayoutClean() const = 0; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const override; public virtual facebook::react::Float baseline(const facebook::react::LayoutContext& layoutContext, facebook::react::Size size) const; public virtual facebook::react::Point getContentOriginOffset(bool includeTransform) const; public virtual facebook::react::Size measure(const facebook::react::LayoutContext& layoutContext, const facebook::react::LayoutConstraints& layoutConstraints) const; @@ -4495,6 +4496,7 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac public std::shared_ptr cloneMultiple(const std::unordered_set>& familiesToUpdate, const std::function(const facebook::react::ShadowNode& oldShadowNode, const facebook::react::ShadowNodeFragment& fragment)>& callback) const; public std::shared_ptr cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function(const facebook::react::ShadowNode& oldShadowNode)>& callback) const; public using AncestorList = std::vector, int>>; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const; public virtual void appendChild(const std::shared_ptr& child); public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&); public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr& newChild, size_t suggestedIndex = std::numeric_limits::max()); diff --git a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api index 47e70d959eb..5f21f38534c 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api @@ -4001,6 +4001,7 @@ class facebook::react::LayoutableShadowNode : public facebook::react::ShadowNode public virtual bool canBeTouchTarget() const; public virtual bool canChildrenBeTouchTarget() const; public virtual bool getIsLayoutClean() const = 0; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const override; public virtual facebook::react::Float baseline(const facebook::react::LayoutContext& layoutContext, facebook::react::Size size) const; public virtual facebook::react::Point getContentOriginOffset(bool includeTransform) const; public virtual facebook::react::Size measure(const facebook::react::LayoutContext& layoutContext, const facebook::react::LayoutConstraints& layoutConstraints) const; @@ -4503,6 +4504,7 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac public std::shared_ptr cloneMultiple(const std::unordered_set>& familiesToUpdate, const std::function(const facebook::react::ShadowNode& oldShadowNode, const facebook::react::ShadowNodeFragment& fragment)>& callback) const; public std::shared_ptr cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function(const facebook::react::ShadowNode& oldShadowNode)>& callback) const; public using AncestorList = std::vector, int>>; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const; public virtual void appendChild(const std::shared_ptr& child); public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&); public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr& newChild, size_t suggestedIndex = std::numeric_limits::max()); diff --git a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api index b8735f0528a..cd608ca12bc 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api @@ -843,6 +843,7 @@ class facebook::react::LayoutableShadowNode : public facebook::react::ShadowNode public virtual bool canBeTouchTarget() const; public virtual bool canChildrenBeTouchTarget() const; public virtual bool getIsLayoutClean() const = 0; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const override; public virtual facebook::react::Point getContentOriginOffset(bool includeTransform) const; public virtual facebook::react::Size measure(const facebook::react::LayoutContext& layoutContext, const facebook::react::LayoutConstraints& layoutConstraints) const; public virtual facebook::react::Size measureContent(const facebook::react::LayoutContext& layoutContext, const facebook::react::LayoutConstraints& layoutConstraints) const; @@ -1057,6 +1058,7 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac public std::shared_ptr cloneMultiple(const std::unordered_set>& familiesToUpdate, const std::function(const facebook::react::ShadowNode& oldShadowNode, const facebook::react::ShadowNodeFragment& fragment)>& callback) const; public std::shared_ptr cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function(const facebook::react::ShadowNode& oldShadowNode)>& callback) const; public using AncestorList = std::vector, int>>; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const; public virtual void appendChild(const std::shared_ptr& child); public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&); public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr& newChild, size_t suggestedIndex = std::numeric_limits::max()); diff --git a/scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api index 7cd2395b5ba..c06d3fc44d2 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api @@ -1527,6 +1527,7 @@ class facebook::react::LayoutableShadowNode : public facebook::react::ShadowNode public virtual bool canBeTouchTarget() const; public virtual bool canChildrenBeTouchTarget() const; public virtual bool getIsLayoutClean() const = 0; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const override; public virtual facebook::react::Point getContentOriginOffset(bool includeTransform) const; public virtual facebook::react::Size measure(const facebook::react::LayoutContext& layoutContext, const facebook::react::LayoutConstraints& layoutConstraints) const; public virtual facebook::react::Size measureContent(const facebook::react::LayoutContext& layoutContext, const facebook::react::LayoutConstraints& layoutConstraints) const; @@ -2236,6 +2237,7 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac public std::shared_ptr cloneMultiple(const std::unordered_set>& familiesToUpdate, const std::function(const facebook::react::ShadowNode& oldShadowNode, const facebook::react::ShadowNodeFragment& fragment)>& callback) const; public std::shared_ptr cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function(const facebook::react::ShadowNode& oldShadowNode)>& callback) const; public using AncestorList = std::vector, int>>; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const; public virtual void appendChild(const std::shared_ptr& child); public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&); public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr& newChild, size_t suggestedIndex = std::numeric_limits::max()); diff --git a/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api index 6b1ebcc6d52..1da6bfffd24 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api @@ -842,6 +842,7 @@ class facebook::react::LayoutableShadowNode : public facebook::react::ShadowNode public virtual bool canBeTouchTarget() const; public virtual bool canChildrenBeTouchTarget() const; public virtual bool getIsLayoutClean() const = 0; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const override; public virtual facebook::react::Point getContentOriginOffset(bool includeTransform) const; public virtual facebook::react::Size measure(const facebook::react::LayoutContext& layoutContext, const facebook::react::LayoutConstraints& layoutConstraints) const; public virtual facebook::react::Size measureContent(const facebook::react::LayoutContext& layoutContext, const facebook::react::LayoutConstraints& layoutConstraints) const; @@ -1050,6 +1051,7 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac public std::shared_ptr cloneMultiple(const std::unordered_set>& familiesToUpdate, const std::function(const facebook::react::ShadowNode& oldShadowNode, const facebook::react::ShadowNodeFragment& fragment)>& callback) const; public std::shared_ptr cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function(const facebook::react::ShadowNode& oldShadowNode)>& callback) const; public using AncestorList = std::vector, int>>; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const; public virtual void appendChild(const std::shared_ptr& child); public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&); public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr& newChild, size_t suggestedIndex = std::numeric_limits::max()); diff --git a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api index 6b1ebcc6d52..1da6bfffd24 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api @@ -842,6 +842,7 @@ class facebook::react::LayoutableShadowNode : public facebook::react::ShadowNode public virtual bool canBeTouchTarget() const; public virtual bool canChildrenBeTouchTarget() const; public virtual bool getIsLayoutClean() const = 0; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const override; public virtual facebook::react::Point getContentOriginOffset(bool includeTransform) const; public virtual facebook::react::Size measure(const facebook::react::LayoutContext& layoutContext, const facebook::react::LayoutConstraints& layoutConstraints) const; public virtual facebook::react::Size measureContent(const facebook::react::LayoutContext& layoutContext, const facebook::react::LayoutConstraints& layoutConstraints) const; @@ -1050,6 +1051,7 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac public std::shared_ptr cloneMultiple(const std::unordered_set>& familiesToUpdate, const std::function(const facebook::react::ShadowNode& oldShadowNode, const facebook::react::ShadowNodeFragment& fragment)>& callback) const; public std::shared_ptr cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function(const facebook::react::ShadowNode& oldShadowNode)>& callback) const; public using AncestorList = std::vector, int>>; + public virtual const facebook::react::LayoutableShadowNode* asLayoutable() const; public virtual void appendChild(const std::shared_ptr& child); public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&); public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr& newChild, size_t suggestedIndex = std::numeric_limits::max());