From 795d9022707d543540217c72bf05d4e5893ecfe2 Mon Sep 17 00:00:00 2001 From: Ingrid Wang Date: Wed, 29 Apr 2026 09:59:25 -0700 Subject: [PATCH] Fix unreachable-code-break (#56648) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/56648 Changelog: [iOS][Fixed] - Fixing unreachable-code-break Reviewed By: fkgozali Differential Revision: D102855020 fbshipit-source-id: 9f57faa06ee4101da875ec06b7d1e6e37f2de98e --- .../React/CxxLogUtils/RCTDefaultCxxLogFunction.mm | 1 - packages/react-native/ReactCommon/logger/react_native_log.cpp | 1 - .../renderer/imagemanager/RCTImagePrimitivesConversions.h | 4 ---- 3 files changed, 6 deletions(-) diff --git a/packages/react-native/React/CxxLogUtils/RCTDefaultCxxLogFunction.mm b/packages/react-native/React/CxxLogUtils/RCTDefaultCxxLogFunction.mm index 2eec0dda176..138dc553c68 100644 --- a/packages/react-native/React/CxxLogUtils/RCTDefaultCxxLogFunction.mm +++ b/packages/react-native/React/CxxLogUtils/RCTDefaultCxxLogFunction.mm @@ -28,7 +28,6 @@ void RCTDefaultCxxLogFunction(ReactNativeLogLevel level, const char *message) break; case ReactNativeLogLevelFatal: LOG(FATAL) << message; - break; } } diff --git a/packages/react-native/ReactCommon/logger/react_native_log.cpp b/packages/react-native/ReactCommon/logger/react_native_log.cpp index a15ff7cd587..344e61770e5 100644 --- a/packages/react-native/ReactCommon/logger/react_native_log.cpp +++ b/packages/react-native/ReactCommon/logger/react_native_log.cpp @@ -47,6 +47,5 @@ void _react_native_log_default(ReactNativeLogLevel level, const char* message) { break; case ReactNativeLogLevelFatal: LOG(FATAL) << message; - break; } } diff --git a/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/ios/react/renderer/imagemanager/RCTImagePrimitivesConversions.h b/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/ios/react/renderer/imagemanager/RCTImagePrimitivesConversions.h index 905cfe8f269..a13e6fb6d40 100644 --- a/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/ios/react/renderer/imagemanager/RCTImagePrimitivesConversions.h +++ b/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/ios/react/renderer/imagemanager/RCTImagePrimitivesConversions.h @@ -55,16 +55,12 @@ inline static NSURLRequestCachePolicy NSURLRequestCachePolicyFromImageSource( switch (imageSource.cache) { case facebook::react::ImageSource::CacheStategy::Reload: return NSURLRequestReloadIgnoringLocalCacheData; - break; case facebook::react::ImageSource::CacheStategy::ForceCache: return NSURLRequestReturnCacheDataElseLoad; - break; case facebook::react::ImageSource::CacheStategy::OnlyIfCached: return NSURLRequestReturnCacheDataDontLoad; - break; default: return NSURLRequestUseProtocolCachePolicy; - break; } }