From 786df48b50c5a478dca4f64c97a172c98c69d46f Mon Sep 17 00:00:00 2001
From: Valentin Shergin <shergin@fb.com>
Date: Tue, 6 Nov 2018 10:58:51 -0800
Subject: [PATCH] Fabric: Making some picky compilers happy

Summary: Trivial nits.

Reviewed By: mdvacca

Differential Revision: D12897927

fbshipit-source-id: 61cec4a070218606d52f05740aacbfae1d2efd31
---
 ReactCommon/fabric/components/view/conversions.h      | 3 ++-
 ReactCommon/fabric/core/layout/LayoutableShadowNode.h | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/ReactCommon/fabric/components/view/conversions.h b/ReactCommon/fabric/components/view/conversions.h
index 0b541379e4e..b5683c0d70f 100644
--- a/ReactCommon/fabric/components/view/conversions.h
+++ b/ReactCommon/fabric/components/view/conversions.h
@@ -14,6 +14,7 @@
 #include <folly/dynamic.h>
 #include <yoga/YGNode.h>
 #include <yoga/Yoga.h>
+#include <cmath>
 
 namespace facebook {
 namespace react {
@@ -51,7 +52,7 @@ inline YGFloatOptional yogaOptionalFloatFromFloat(Float value) {
 }
 
 inline YGValue yogaStyleValueFromFloat(const Float &value) {
-  if (isnan(value) || value == kFloatUndefined) {
+  if (std::isnan(value) || value == kFloatUndefined) {
     return YGValueUndefined;
   }
 
diff --git a/ReactCommon/fabric/core/layout/LayoutableShadowNode.h b/ReactCommon/fabric/core/layout/LayoutableShadowNode.h
index a419be119cf..50d57a0e686 100644
--- a/ReactCommon/fabric/core/layout/LayoutableShadowNode.h
+++ b/ReactCommon/fabric/core/layout/LayoutableShadowNode.h
@@ -28,6 +28,8 @@ struct LayoutContext;
  */
 class LayoutableShadowNode : public virtual Sealable {
  public:
+  virtual ~LayoutableShadowNode() noexcept = default;
+
   /*
    * Measures the node (and node content, propbably recursivly) with
    * given constrains and relying on possible layout.