From 77c1eb615400c07fd2a7d7f4a47dd87cef1c8743 Mon Sep 17 00:00:00 2001 From: Tim Yung Date: Sun, 11 May 2025 00:30:21 -0700 Subject: [PATCH] RN: Migrate `VirtualView` to Feature Flags (#51233) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/51233 Migrates internal operational and experimental feature flags to React Native's feature flag system, in order to simplify integration of other infrastructure features (e.g. Fantom). Changelog: [Internal] Reviewed By: lunaleaps Differential Revision: D74534921 fbshipit-source-id: 1559cba4f208a554bb043a203f331062036c60de --- .../ReactNativeFeatureFlags.config.js | 21 +++++++++++++++++++ .../featureflags/ReactNativeFeatureFlags.js | 14 ++++++++++++- 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js b/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js index a31a59ce66f..7241c928229 100644 --- a/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js +++ b/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js @@ -610,6 +610,27 @@ const definitions: FeatureFlagDefinitions = { }, ossReleaseStage: 'none', }, + enableVirtualViewDebugFeatures: { + defaultValue: false, + metadata: { + description: + 'Enables VirtualView debug features such as logging and overlays.', + expectedReleaseValue: false, + purpose: 'operational', + }, + ossReleaseStage: 'none', + }, + enableVirtualViewDoubleStateHidden: { + defaultValue: false, + metadata: { + dateAdded: '2025-05-10', + description: + 'Enables a VirtualView workaround that triggers a second state update when changing to hidden mode.', + expectedReleaseValue: false, + purpose: 'experimentation', + }, + ossReleaseStage: 'none', + }, fixVirtualizeListCollapseWindowSize: { defaultValue: false, metadata: { diff --git a/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js b/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js index 9d151e6f1e5..4adc17c92dc 100644 --- a/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js +++ b/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js @@ -4,7 +4,7 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @generated SignedSource<<73bd98850713966c32d122c3d3283df9>> + * @generated SignedSource<<24076ce2a95804d6dda128740cbbae8f>> * @flow strict */ @@ -33,6 +33,8 @@ export type ReactNativeFeatureFlagsJsOnly = $ReadOnly<{ avoidStateUpdateInAnimatedPropsMemo: Getter, disableInteractionManager: Getter, enableAccessToHostTreeInFabric: Getter, + enableVirtualViewDebugFeatures: Getter, + enableVirtualViewDoubleStateHidden: Getter, fixVirtualizeListCollapseWindowSize: Getter, isLayoutAnimationEnabled: Getter, scheduleAnimatedCleanupInMicrotask: Getter, @@ -127,6 +129,16 @@ export const disableInteractionManager: Getter = createJavaScriptFlagGe */ export const enableAccessToHostTreeInFabric: Getter = createJavaScriptFlagGetter('enableAccessToHostTreeInFabric', false); +/** + * Enables VirtualView debug features such as logging and overlays. + */ +export const enableVirtualViewDebugFeatures: Getter = createJavaScriptFlagGetter('enableVirtualViewDebugFeatures', false); + +/** + * Enables a VirtualView workaround that triggers a second state update when changing to hidden mode. + */ +export const enableVirtualViewDoubleStateHidden: Getter = createJavaScriptFlagGetter('enableVirtualViewDoubleStateHidden', false); + /** * Fixing an edge case where the current window size is not properly calculated with fast scrolling. Window size collapsed to 1 element even if windowSize more than the current amount of elements */