From 779e3be1069a415c7634052b6742dbaeedbcac6e Mon Sep 17 00:00:00 2001 From: David Vacca Date: Wed, 28 Feb 2024 08:47:35 -0800 Subject: [PATCH] Mark classes of package uimanager as @Nullsafe Summary: All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future bypass-github-export-checks changelog: [internal] internal Reviewed By: arushikesarwani94 Differential Revision: D54027177 fbshipit-source-id: 13b4352f0b61eec69bfdcb6a3e369faa4dfcc750 --- .../java/com/facebook/react/uimanager/ReactStylesDiffMap.java | 2 ++ .../com/facebook/react/uimanager/ReactYogaConfigProvider.java | 2 ++ .../main/java/com/facebook/react/uimanager/RootViewManager.java | 2 ++ 3 files changed, 6 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactStylesDiffMap.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactStylesDiffMap.java index 504bedbfe22..7f7982597e8 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactStylesDiffMap.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactStylesDiffMap.java @@ -9,6 +9,7 @@ package com.facebook.react.uimanager; import android.view.View; import androidx.annotation.Nullable; +import com.facebook.infer.annotation.Nullsafe; import com.facebook.react.bridge.Dynamic; import com.facebook.react.bridge.ReadableArray; import com.facebook.react.bridge.ReadableMap; @@ -32,6 +33,7 @@ import java.util.Map; * shouldn't be updated (whereas in all other cases it should be updated to the new value or the * property should be reset). */ +@Nullsafe(Nullsafe.Mode.LOCAL) public class ReactStylesDiffMap { /* package */ final ReadableMap mBackingMap; diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactYogaConfigProvider.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactYogaConfigProvider.java index 16fbb71ae11..67c80d2c80f 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactYogaConfigProvider.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactYogaConfigProvider.java @@ -7,10 +7,12 @@ package com.facebook.react.uimanager; +import com.facebook.infer.annotation.Nullsafe; import com.facebook.yoga.YogaConfig; import com.facebook.yoga.YogaConfigFactory; import com.facebook.yoga.YogaErrata; +@Nullsafe(Nullsafe.Mode.LOCAL) public class ReactYogaConfigProvider { private static YogaConfig YOGA_CONFIG; diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/RootViewManager.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/RootViewManager.java index 4393528caac..3a09de11df8 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/RootViewManager.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/RootViewManager.java @@ -9,8 +9,10 @@ package com.facebook.react.uimanager; import android.view.ViewGroup; import android.widget.FrameLayout; +import com.facebook.infer.annotation.Nullsafe; /** View manager for ReactRootView components. */ +@Nullsafe(Nullsafe.Mode.LOCAL) public class RootViewManager extends ViewGroupManager { public static final String REACT_CLASS = "RootView";