Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Introduce general API for setting C++ State from the View layer and getting a notification if it fails, with Android impl

Browse Source 
Summary:
iOS will need to be implemented separately, but the shared C++ bits are in place.

Explanation: there is currently no way for the View layer to /know/ if an UpdateState call has succeeded or failed. Generally we just assume it succeeds, but if it fails we have no way of knowing or retrying.

This can cause some UI bugs. To mitigate this, I'm introducing a "failure" notification callback mechanism. The JNI bridging for this is a little complicated to avoid passing Runnable across the JNI, but it
should be much simpler on iOS.

In development this seems to make View components much more reliable.

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D22940187

fbshipit-source-id: 917f2932ae22d421f91fe8f4fca3f07dc089f820
This commit is contained in:
Joshua Gross
2020-08-05 06:35:41 -07:00
committed by Facebook GitHub Bot
parent b6ba6f5808
commit 774dec1e17
12 changed files with 197 additions and 175 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/fabric/StateWrapperImpl.java
+32
View File
@@ -8,11 +8,13 @@
package com.facebook.react.fabric;
import android.annotation.SuppressLint;
import androidx.annotation.AnyThread;
import androidx.annotation.NonNull;
import com.facebook.jni.HybridData;
import com.facebook.proguard.annotations.DoNotStrip;
import com.facebook.react.bridge.NativeMap;
import com.facebook.react.bridge.ReadableNativeMap;
import com.facebook.react.bridge.UiThreadUtil;
import com.facebook.react.bridge.WritableMap;
import com.facebook.react.uimanager.StateWrapper;
@@ -28,6 +30,9 @@ public class StateWrapperImpl implements StateWrapper {
@DoNotStrip private final HybridData mHybridData;
private Runnable mFailureCallback = null;
private int mUpdateStateId = 0;
private static native HybridData initHybrid();
private StateWrapperImpl() {
@@ -39,8 +44,35 @@ public class StateWrapperImpl implements StateWrapper {
public native void updateStateImpl(@NonNull NativeMap map);
public native void updateStateWithFailureCallbackImpl(
@NonNull NativeMap map, Object self, int updateStateId);
@Override
public void updateState(@NonNull WritableMap map) {
mUpdateStateId++;
updateStateImpl((NativeMap) map);
}
@Override
public void updateState(@NonNull WritableMap map, Runnable failureCallback) {
mUpdateStateId++;
mFailureCallback = failureCallback;
updateStateWithFailureCallbackImpl((NativeMap) map, this, mUpdateStateId);
}
@DoNotStrip
@AnyThread
public void updateStateFailed(int callbackRefId) {
// If the callback ref ID doesn't match the ID of the most-recent updateState call,
// then it's an outdated failure callback and we ignore it.
if (callbackRefId != mUpdateStateId) {
return;
}
final Runnable failureCallback = mFailureCallback;
mFailureCallback = null;
if (failureCallback != null) {
UiThreadUtil.runOnUiThread(failureCallback);
}
}
}